Re: [Gen-art] Gen-art review of draft-ietf-rmt-bb-fec-basic-schemes-revised-05
Elwyn Davies <elwynd@dial.pipex.com> Fri, 31 October 2008 20:23 UTC
Return-Path: <gen-art-bounces@ietf.org>
X-Original-To: gen-art-archive@optimus.ietf.org
Delivered-To: ietfarch-gen-art-archive@core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 1F5003A6BFE; Fri, 31 Oct 2008 13:23:39 -0700 (PDT)
X-Original-To: gen-art@core3.amsl.com
Delivered-To: gen-art@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 8F7633A6B20; Fri, 31 Oct 2008 13:23:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -94.167
X-Spam-Level:
X-Spam-Status: No, score=-94.167 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FH_HOST_EQ_D_D_D_D=0.765, FH_HOST_EQ_D_D_D_DB=0.888, HELO_DYNAMIC_SPLIT_IP=3.493, HELO_EQ_IP_ADDR=1.119, RCVD_NUMERIC_HELO=2.067, RDNS_DYNAMIC=0.1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OcJV+opYONHh; Fri, 31 Oct 2008 13:23:36 -0700 (PDT)
Received: from a.painless.aaisp.net.uk (d.5.0.d.2.7.e.f.f.f.8.4.0.3.2.0.0.3.0.0.0.0.0.0.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:0:30:230:48ff:fe72:d05d]) by core3.amsl.com (Postfix) with ESMTP id 1F3E63A6AAB; Fri, 31 Oct 2008 13:23:36 -0700 (PDT)
Received: from 247.254.187.81.in-addr.arpa ([81.187.254.247]) by a.painless.aaisp.net.uk with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from <elwynd@dial.pipex.com>) id 1Kw0Wp-0006XP-FW; Fri, 31 Oct 2008 20:23:31 +0000
Message-ID: <490B6A53.5010807@dial.pipex.com>
Date: Fri, 31 Oct 2008 20:28:03 +0000
From: Elwyn Davies <elwynd@dial.pipex.com>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Mark Watson <mark@digitalfountain.com>
References: <C530894F.2FC8D%mark@digitalfountain.com>
In-Reply-To: <C530894F.2FC8D%mark@digitalfountain.com>
Cc: rmt-chairs@tools.ietf.org, General Area Review Team <gen-art@ietf.org>, rmt-ads@tools.ietf.org, IETF Discussion <ietf@ietf.org>, Elwyn Davies <elwynd@googlemail.com>
Subject: Re: [Gen-art] Gen-art review of draft-ietf-rmt-bb-fec-basic-schemes-revised-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: gen-art-bounces@ietf.org
Errors-To: gen-art-bounces@ietf.org
This all seems fine to me.. I'll take a look at the next version when it appears. No worries on the delay... you should see some of mine ;-) /Elwyn Mark Watson wrote: > Elwyn, all, > > Please accept my apologies for the excessive delay in addressing these > comments. My plan for addressing these in the -06 draft is below. > > Regards, > > Mark > > > On 7/18/08 8:57 AM, "Elwyn Davies" <elwynd@googlemail.com> wrote: > > >> I have been selected as the General Area Review Team (Gen-ART) >> reviewer for this draft (for background on Gen-ART, please see >> _http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html_). >> >> Please resolve these comments along with any other Last Call comments >> you may receive. >> >> >> Document: draft-ietf-rmt-bb-fec-basic-schemes-revised-05.txt >> Reviewer: Elwyn Davies >> Review Date: 18 July 2008 >> IETF LC End Date: 29 July 2008 >> IESG Telechat date: n/a >> >> Summary: >> Nearly ready for IESG. A few minor issues mainly with failure to >> specify encodings and a couple of corner cases. A few editorial nits >> noted below. >> >> Comments: >> >> s3.2.1: Need to explicitly document the encoding used for SBNs (also >> applies to s4.2.1 and s5.2.1. s5.2.1 also needs to specify encoding for >> Source Block Length). >> > > - Add a clarifying sentence in the introduction that all integer fields are > in network byte order. > - In the individual sections, specify that the fields are 'x-bit unsigned > integers' with suitable values of x. > > >> s3.2.1, bottom of page 6/top of page 7: s/is processed at/to process the >> block by/ (two places) (or some such .. it doesn't read well at present). >> > > New sentence: "The transport time of a source block includes the amount of > time needed to process the source block at the sender transport layer, the > network transit time for packets, and the amount of time needed to process > the source block at the receiver transport." > > >> s3.2.2.2: need to explicitly state encoding of various values (unsigned >> integers I assume). (also applies to s4.2.2.2, s4.2.2.3, s5.2.2.2 >> > > Ok. I will add a paragraph under each figure. > > >> s4.2.2.3: The case where the length is zero is a lttle odd! I think it >> would be worth explicitly stating that (either) the whole object is just >> one octet long (or) it is four octets padded with zeroes. The latter >> case might make processing more consistent since otherwise the zero case >> is special and the only case where the object is not four octet aligned. >> > > Ok - I believe there are no users of this field at present so it is safe to > include the padding for four-octet alignment. > > >> s5.1: it is not possible to encode the source block length of 65536 in >> 16 bits unless 0 is overloaded to mean 2^^16. This isn't specified. (I >> assume 'at most' to be read as 'less than or equal'). >> >> > > The maximum size should be 65535. > > >> Editorial: >> >> Abstract: Need to expand FEC at least once! >> s1, 2nd para after bullets: genrally not recommended to mention WG >> s1, last para: s/listed/are listed/ >> s3.2.1: Need to asociate Source Block Number and SBN explicitly (well, I >> assume that is what SBN means!). >> s3.4.1, next to last para: s/implementor of/implementor/ >> s3.4.2, lastpara: s/substracting/subtracting/ >> s4.4.2.2: I take the reference in the last para of the section (just >> above Fig 4) should be to s3.2.2.2. >> > > Actually it should be to the figure. > > >> s10, 2nd bullet: s/th/the/ >> s10, 3rd bullet: s/sis/did/ >> >> > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art > > _______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Gen-art review of draft-ietf-rmt-bb-fec… Elwyn Davies
- Re: [Gen-art] Gen-art review of draft-ietf-rmt-bb… Mark Watson
- Re: [Gen-art] Gen-art review of draft-ietf-rmt-bb… Elwyn Davies