IETF Logo Mail Archive

Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-tls-keylogfile-01

Russ Housley <housley@vigilsec.com> Sun, 14 April 2024 16:35 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF42FC14F6A0; Sun, 14 Apr 2024 09:35:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.098
X-Spam-Level:
X-Spam-Status: No, score=-7.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=vigilsec.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MeOPyLgWtN5T; Sun, 14 Apr 2024 09:35:19 -0700 (PDT)
Received: from mail3.g24.pair.com (mail3.g24.pair.com [66.39.134.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AA067C14F689; Sun, 14 Apr 2024 09:35:19 -0700 (PDT)
Received: from mail3.g24.pair.com (localhost [127.0.0.1]) by mail3.g24.pair.com (Postfix) with ESMTP id 9FB92156F47; Sun, 14 Apr 2024 12:35:18 -0400 (EDT)
Received: from smtpclient.apple (pfs.iad.rg.net [198.180.150.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail3.g24.pair.com (Postfix) with ESMTPSA id 71357155DF1; Sun, 14 Apr 2024 12:35:18 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <bf9d2025-2925-4092-a85f-2a7c4014c08d@app.fastmail.com>
Date: Sun, 14 Apr 2024 12:35:08 -0400
Cc: IETF Gen-ART <gen-art@ietf.org>, draft-ietf-tls-keylogfile.all@ietf.org, Last Call <last-call@ietf.org>, IETF TLS <tls@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <74EA765E-DB1F-4242-BA2D-EA0056F32526@vigilsec.com>
References: <171294664943.62605.7873105311521971417@ietfa.amsl.com> <bf9d2025-2925-4092-a85f-2a7c4014c08d@app.fastmail.com>
To: Martin Thomson <mt@lowentropy.net>
X-Mailer: Apple Mail (2.3731.700.6.1.1)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vigilsec.com; h=content-type:mime-version:subject:from:in-reply-to:date:cc:content-transfer-encoding:message-id:references:to; s=pair-202402141609; bh=m1/KRnazNB3mSmY51ciAuKTmAxKooudmYXjihXTxzuI=; b=TalARKzO2nCpob3TrsrCbZbOgQE0Iz0LGXpMwHbgD8/DRAvyE9gU686A6dHFPrRWLZGpM+06dZVyWAbxaQdIaxeREUTuvW6J0z3sA+/n++G86fJvv2iWk26Q1GyKmPK4c2J7MRl9AIfPWH1BJKiCIRoO08ZtHXbuEuK8EdCEQxC1IBs6UZON8DjhyUGXdsXuRUC0Y6ne0wAv96+JICnpA4QOlrtO9NzFEex8gKqy8BGxeTE6khVQamdmf1F0yZZmF3n4CzfdNK99gdToHCPQtyb/NBXXc5JJvwdODi0TySdduV3T3XmOv9bPggDXZ9MJP4SdT+8T1hm8JbbngnBaSg==
X-Scanned-By: mailmunge 3.11 on 66.39.134.11
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/IEHyosc0354laqCIWTPYbsnL6es>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-tls-keylogfile-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Apr 2024 16:35:24 -0000

Yes, indeed.

Russ

> On Apr 14, 2024, at 6:22 AM, Martin Thomson <mt@lowentropy.net> wrote:
> 
> Thanks  Russ,
> 
> https://github.com/tlswg/sslkeylogfile/pull/11 and https://mailarchive.ietf.org/arch/msg/media-types/5IW3tN6mJkqZMyuYWLwoOMNVhgM/ should address those issues.
> 
> Cheers,
> Martin
> 
> On Fri, Apr 12, 2024, at 14:30, Russ Housley via Datatracker wrote:
>> Reviewer: Russ Housley
>> Review result: Ready
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair. Please wait for direction from your
>> document shepherd or AD before posting a new version of the draft.
>> 
>> For more information, please see the FAQ at
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-tls-keylogfile-01
>> Reviewer: Russ Housley
>> Review Date: 2024-04-12
>> IETF LC End Date: 2024-04-18
>> IESG Telechat date: unknown
>> 
>> Summary: Ready
>> 
>> 
>> Major Concerns:
>> 
>> None
>> 
>> 
>> Minor Concerns:
>> 
>> Section 3: The text says: "Access to the content of a file in
>> SSLKEYLOGFILE format allows an attacker to break the
>> confidentiality protection on any TLS connections that are
>> included in the file."  This is clearly true.  However, the
>> attacker this access to the keys can also break the integrity
>> protections.
>> 
>> Section 4: The registration of the new application/sslkeylogfile
>> media-type for all IETF registrations in the standards tree
>> requires a posting to the media-types@iana.org mail list.  A search
>> of the mail archive id not uncover "sslkeylogfile".  To avoid delay,
>> that mail list discussion should probably get started now.
>> 
>> 
>> Nits:
>> 
>> Section 1: s/file format that logging/file format for logging/
> 
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email