[Gen-art] Gen-ART Last Call review of draft-ietf-lsr-ospf-l2bundles-06

Paul Kyzivat <pkyzivat@alum.mit.edu> Fri, 16 September 2022 17:57 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E147C1522C0; Fri, 16 Sep 2022 10:57:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.01
X-Spam-Level:
X-Spam-Status: No, score=-2.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=alum.mit.edu
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LgRz2SZRPfZv; Fri, 16 Sep 2022 10:57:45 -0700 (PDT)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 272BAC14CF0E; Fri, 16 Sep 2022 10:57:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NKeflT9Q0WWAnHcB82pbaOTK+1FpaPBoNTS7bSSw0hhfOFZAU425d0g4Hv1hRXFYTdwj+GB3bv9vzISo+43FEzFTo4FL5sEzxPaMMsXLyIzM9T7NTolXzorzKewNztqDM3wGIHq7nyFNkDpOCslhbNOf92GZgXG4iVVSrUbtFvrkub6tlPjUfBMZftwOObcquGwGEqh8lbPI4N5M290LJgcmFaKOP6Ho44eZzEbCT51z/jhrMY9duPJFuRGRzm+lSsSikKJXhj6cLSDxuWCrBs8+rkChcGXuCey62Vq3QjXxLaz9QEw1V3x30nqdxQUYnK5LyaodkgFeuauIXPGO+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+EQhUOS+iNUdALZ1PQVqCrIr4sAGZo1GpcYmUyNa2yg=; b=huhOJpKwK9mUOmLhC36DF2P9rduQB3r65N+52ldxbTyfi+RbjJ5iokI0cIxXmhsN2ezyli3Yl+4cjdGSX3VMTqb7tDYA9Z4jf5iHNbryLLHVzwxI+uANIW9N0hTNe2bfDkgKS0StOD18K2b3Ha4sBzc7Ei1lJ+EmEMlzmsWo9qFBlZ2gIjuLQ8xTiXrrBu6OD7RzL68zPDgKXLQ4WbktKNwz5APbUAzL59KGD+uu1oK0etjWv5J2OB8Bl0+XrVQq+sB0lxVg2kslZNdvcscxxIN1hWxsIfpnPWOitNRQuc3DYc8Lo2wBPsaHI+tIE2peVnoMuj8WnUNN0p8kWWPpsg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 18.7.68.33) smtp.rcpttodomain=ietf.org smtp.mailfrom=alum.mit.edu; dmarc=pass (p=none sp=none pct=100) action=none header.from=alum.mit.edu; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alum.mit.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+EQhUOS+iNUdALZ1PQVqCrIr4sAGZo1GpcYmUyNa2yg=; b=fMTbQ9+EZVEAO/+VnyIOFTq4oKPaJRE38EZqd5UJ/59/aD3VzPLQe+IbnR0tzSo1pPGq9Xf/dbWBdNJMzrdzkL6WvzQh2oRn2+bKGs7mqNPsFdgo1m1csQWluMeyXIepZv9JZt1PHxmtKGXTGQsKSe685VkFHjVqOO1nMuIwJXE=
Received: from BN0PR03CA0039.namprd03.prod.outlook.com (2603:10b6:408:e7::14) by LV2PR12MB5942.namprd12.prod.outlook.com (2603:10b6:408:171::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Fri, 16 Sep 2022 17:57:39 +0000
Received: from BN1NAM02FT020.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e7:cafe::a9) by BN0PR03CA0039.outlook.office365.com (2603:10b6:408:e7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16 via Frontend Transport; Fri, 16 Sep 2022 17:57:39 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 18.7.68.33) smtp.mailfrom=alum.mit.edu; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=alum.mit.edu;
Received-SPF: Pass (protection.outlook.com: domain of alum.mit.edu designates 18.7.68.33 as permitted sender) receiver=protection.outlook.com; client-ip=18.7.68.33; helo=outgoing-alum.mit.edu; pr=C
Received: from outgoing-alum.mit.edu (18.7.68.33) by BN1NAM02FT020.mail.protection.outlook.com (10.13.2.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Fri, 16 Sep 2022 17:57:38 +0000
Received: from [192.168.1.52] (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.14.7/8.12.4) with ESMTP id 28GHvbT3010984 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 16 Sep 2022 13:57:37 -0400
Message-ID: <7cdddc6b-2b97-c321-4cc4-fdad869d6e08@alum.mit.edu>
Date: Fri, 16 Sep 2022 13:57:37 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: draft-ietf-lsr-ospf-l2bundles.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>
Content-Language: en-US
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN1NAM02FT020:EE_|LV2PR12MB5942:EE_
X-MS-Office365-Filtering-Correlation-Id: b09e478c-de22-4508-5e44-08da980cf19f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7xQ2T6/97+A8FHdRvIVCjmatFVPmj+Tufv3fdVDGvtYDGFwXkLfrOuV5D/yU4/z5NfoEDeCSOwHdph8q0JrQPsYHYV2Dwp6JqWCSrukFd5ny5Uwnye2vW/HtYvw2OoCMviYzyATuvn7ujn918sDKlyoRIKKXuqk8WCVzbU1vhNScri47D5gXxTavz4Tj77gzjSNNVUCWtAUoDSFDgS+KI60sBqyBQowibEdzYJ/xTeWc6uQli+xVuqPPw+96qt68/XuqUnqd8Qdx6g0YYMVsGmI6PjC2C4oGF0rwRKDlUl3eHYjD9aEa0beAbz4xO5413JOMlwNHja48J7S7+egagylIxqjLwHHEQ4RyfLHC9jTgEIqWoRGFw+CQc/VfDI7IwSIAAjPSTf6hYs1Y7O9cEiFDejVFDJaxyoU2U7KCHmM9l6/GOF8DM4cSLqPD8GwLXsQc9SftmY1IQ2KlVqeJJe7zX5rfMs7gCtfH4rGCEp72d604fdz3HvGOtWHiGMhll8dmFsr42DY3L6laRM011kU9Qleim/bouSwlBpRPm3Q+DtHy6KXo+3K+kCe7x2S+1j7lFzOsa/Ax5QCJq/xXpGZVDrVYz7EWbaPRq9xQnYKeJ3/c1SLD708v/ib4Jt+ORa/vpMfWMphM9GUn1Vb3lSyIp2u2cI/fNhvjUrfDAdn75MvbruyCzoIJ3BvVeqWtFCTQN641BEeT/gyxFyInOZMXiWTL+L0mdTnIqSic9RfVTz6dYM47LAfzNme5r2qyn53YZP540AWrVj5GnjZ/cv/njzaHkQHNo+R9KbBCyVPS5VEZBKPm7VDW1usrAHIRHF5E99nO0it/W9qkgACRNg==
X-Forefront-Antispam-Report: CIP:18.7.68.33; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:outgoing-alum.mit.edu; PTR:outgoing-alum.mit.edu; CAT:NONE; SFS:(13230022)(136003)(396003)(39860400002)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(8676002)(82740400003)(31696002)(86362001)(356005)(36860700001)(7596003)(31686004)(41320700001)(2906002)(40460700003)(956004)(75432002)(47076005)(478600001)(41300700001)(26005)(83380400001)(2616005)(336012)(4326008)(186003)(40480700001)(450100002)(70586007)(82310400005)(316002)(70206006)(5660300002)(8936002)(6916009)(786003)(43740500002); DIR:OUT; SFP:1101;
X-OriginatorOrg: alum.mit.edu
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 17:57:38.6348 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b09e478c-de22-4508-5e44-08da980cf19f
X-MS-Exchange-CrossTenant-Id: 3326b102-c043-408b-a990-b89e477d582f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3326b102-c043-408b-a990-b89e477d582f; Ip=[18.7.68.33]; Helo=[outgoing-alum.mit.edu]
X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT020.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5942
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/IqLhVi63YKAt6GINPOKUQ0sGt3g>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-lsr-ospf-l2bundles-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2022 17:57:49 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lsr-ospf-l2bundles-06
Reviewer: Paul Kyzivat
Review Date: 2022-09-16
IETF LC End Date: 2022-09-29
IESG Telechat date: ?

Summary:

This draft is on the right track but has open issues, described in the 
review.

Issues:

Major: 0
Minor: 1
Nits:  1

1) NIT: 1 Introduction

IDNITS reports:

    -- Possible downref: Non-RFC (?) normative reference: ref.
    'IEEE802.1AX'

As best I can tell there is no need for this reference to be normative. 
(Its only an example in the introduction.) I suggest making this a 
non-normative reference.

2) MINOR: Section 2: Normative requirements on future documents

While I don't fully understand all the document dependencies, the 
following normative requirement:

    ... Specifications that introduce new sub-TLVs of the Extended Link
    TLV MUST indicate their applicability for the L2 Bundle Member
    Attributes Sub-TLV.  An implementation MUST ignore any sub-TLVs
    received that are not applicable in the context of the L2 Bundle
    Member Attribute Sub-TLV.

looks to me like it may be imposing requirements on future work that may 
not itself be aware of or normatively linked to this document. The 
registry in question is defined only by RFC7684. Figure 2 further 
supports this point by effectively revising the format for the registry, 
adding an additional column.

I suggest it would be appropriate to formally update the registry to 
reference this document to impose requirements on future registrations, 
and add a column indicating applicability in the context of the L2 
Bundle Member Attribute Sub-TLV.

The same logic applies to Figure 3 and the IANA OSPFv3 Extended-LSA 
Sub-TLVs registry. I suggest the same sort of fix for it.