IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-nottingham-how-did-that-get-into-the-repo-01

Mark Nottingham <mnot@mnot.net> Mon, 09 March 2020 23:39 UTC

Return-Path: <mnot@mnot.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6CCC43A0802; Mon, 9 Mar 2020 16:39:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=mnot.net header.b=SIN8BypT; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=ah7ZvHQd
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z5SeUWYzjH25; Mon, 9 Mar 2020 16:39:06 -0700 (PDT)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DFF1F3A07CB; Mon, 9 Mar 2020 16:39:02 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E4A045C1; Mon, 9 Mar 2020 19:39:01 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 09 Mar 2020 19:39:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mnot.net; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm2; bh=e 1PUWTXPhIONSZ/DGsXBDVIS9r1SDUxbPIh8GreL1lI=; b=SIN8BypT8c3mcKvx1 JnRjuGT1ss6VMoGeC5oahQalugxdBUVM/ChlvCytV7BKv0LIJ9GytzJ+FjM9k9LW DdprVMCbm37frUjEuy6lA/kBXRcpv4rWFfJsdHpKssFRE1ichIBqqOu4hSzp/gmp LkU87GGsUZ8aalWVAWN9Gmff+W5JBxPfTe6y18Cvr1q9+BItGM6GPWo1fPxSqYk5 GIb924j6wrSZjJm+1R7ErWBXV4RruS+Ge0M56bz0oHye13k9hEOD0rkvR/XdOmCc aivIw409zHtHJzjJrMSR0bbLud6aTjsGuKxrrgo89e5b3dBoi8Z8LIv7Gz1BGg6Q 3Kdww==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=e1PUWTXPhIONSZ/DGsXBDVIS9r1SDUxbPIh8GreL1 lI=; b=ah7ZvHQdteQrMUbR0sprOYBg6+/rSUO7aTCDL683ZNsCjZGsxKSa5BfR8 XTsTH1bv325ryBx6oRt4okcuSH0C9u0UeQfxUkeGYUBW6eZ3VskAEhmVUJx+umIi 7drrounviIIE46g/ibxbCvQOkmN3iXk4TPW+x6zdM0aldYS7rPXt6TIjuO/qeh55 i69D8dI0EgcMfWK2zi+kA0HZYvy0nl5siOrrlrFRUo0OF+fCgFgELYcCZsnhlPUb +bLNr64xZN10rcq7+D+PrzOC+qoZVQawStmeCXdrd16lZfqmTc9n+E9NBz9fJOEh Doba8tTHfLdhafIZqcpj496PViCMw==
X-ME-Sender: <xms:lNNmXs0t4ewNx0kSqOcwpUSw3JpcAbrASR3kTPmlh8d2Db_Xd9gfzw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudduledgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegtggfuhfgjfffgkfhfvffosehtqh hmtdhhtddvnecuhfhrohhmpeforghrkhcupfhothhtihhnghhhrghmuceomhhnohhtsehm nhhothdrnhgvtheqnecuffhomhgrihhnpehivghtfhdrohhrghdpmhhnohhtrdhnvghtne cukfhppeduudelrddujedrudehkedrvdehudenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehmnhhothesmhhnohhtrdhnvght
X-ME-Proxy: <xmx:lNNmXtlNcI8QukUlptNYN7IYL9vsxFEEekBU19nu-8Pg3XAQwiQ3TA> <xmx:lNNmXi4muIMkRUOz93iT6X1NXMLLK4LQJCTPd6LyoSMEla3ET5A4GA> <xmx:lNNmXonhx6vJGtATaIBn4ibAL4tycq9X2aObuiR6ZUcRJt1H1_PbHQ> <xmx:ldNmXvdSHpdDg4YHKHsCn4m4-L29j-WArQFJvxefUYNPuynWC8ahRQ>
Received: from macbook-pro.mnot.net (unknown [119.17.158.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 34B61306130A; Mon, 9 Mar 2020 19:38:58 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
From: Mark Nottingham <mnot@mnot.net>
In-Reply-To: <158369879405.6771.17101707412474038344@ietfa.amsl.com>
Date: Tue, 10 Mar 2020 10:38:57 +1100
Cc: gen-art@ietf.org, draft-nottingham-how-did-that-get-into-the-repo.all@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <7C1532B9-3432-4EAF-B36A-7B37C3CCF436@mnot.net>
References: <158369879405.6771.17101707412474038344@ietfa.amsl.com>
To: Jouni Korhonen <jouni.nospam@gmail.com>
X-Mailer: Apple Mail (2.3608.60.0.2.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/K81nD0uF5pcpHLel5aHkDnKQWjk>
Subject: Re: [Gen-art] Genart last call review of draft-nottingham-how-did-that-get-into-the-repo-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Mar 2020 23:39:08 -0000

Hi Jouni,

Thanks for the review. Responses below.

> On 9 Mar 2020, at 7:19 am, Jouni Korhonen via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Jouni Korhonen
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-nottingham-how-did-that-get-into-the-repo-??
> Reviewer: Jouni Korhonen
> Review Date: 2020-03-08
> IETF LC End Date: 2020-03-12
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> This very needed document is ready for publication as an Informational RFC with
> few minor nits.
> 
> Major issues:
> None.
> 
> Minor issues:
> 1) Line 116-117 states "This document uses ABNF [RFC5234], including by
> reference the  following rules: ALPHA, DIGIT." Why RFC5234 APLHA and DIGIT
> rules need to be specifically called out?

Good question; I suspect that's from an earlier revision. Removed.


> Nits/editorial comments:
> 1) Line 106   s/ike/like
> 2) Line 106  Expand CSRF on the first use (and possibly give an informative
> reference to it).

Fixed in source, thanks!

--
Mark Nottingham   https://www.mnot.net/

v2.23.0 | Report a Bug | By Email