Re: [Gen-art] Gen-ART Last Call review of draft-ietf-i2rs-yang-l3-topology-13

"Alexander Clemm" <ludwig@clemm.org> Wed, 13 December 2017 16:53 UTC

Return-Path: <ludwig@clemm.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3990127077; Wed, 13 Dec 2017 08:53:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.92
X-Spam-Level:
X-Spam-Status: No, score=-1.92 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lx6qhwSTNvLe; Wed, 13 Dec 2017 08:53:17 -0800 (PST)
Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 31A14126D0C; Wed, 13 Dec 2017 08:53:17 -0800 (PST)
Received: from LAPTOPR7T053C2 ([73.71.191.170]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0MPWh5-1eKTRz0tLV-004hIp; Wed, 13 Dec 2017 17:52:58 +0100
From: Alexander Clemm <ludwig@clemm.org>
To: 'Paul Kyzivat' <pkyzivat@alum.mit.edu>, draft-ietf-i2rs-yang-l3-topology.all@ietf.org
Cc: 'General Area Review Team' <gen-art@ietf.org>, 'Susan Hares' <shares@ndzh.com>
References: <5f018277-3875-6eec-9235-fbae998aa0c7@alum.mit.edu> <ec8fe19f-546f-9969-ff3f-b13c4ac89afa@alum.mit.edu>
In-Reply-To: <ec8fe19f-546f-9969-ff3f-b13c4ac89afa@alum.mit.edu>
Date: Wed, 13 Dec 2017 08:53:08 -0800
Message-ID: <007001d37432$db946a40$92bd3ec0$@clemm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHOHuPYP9dJLJdmGXJewj7y6ECWggIhv3ybozsZnPA=
Content-Language: en-us
X-Provags-ID: V03:K0:e2MqVAvIGR4UjCowB63PlSAGoADXstSGxjKRAwnTAjsSCAZ+HTb fTSk4WoUu2ke6SQA9fjEsQok6Vy6lTMAia99ufN/JifccweEw36hqDFuVYMeCF9pTmb0u4v VchWZBO0BwWqWXGUYi5dNLFgpPXg2odjTPa/ZlvAcyzhw1s9VC/zeyQxowlOL5s9jO7kXG/ rzMmS5BFDFhaEln1OdD9g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ir5DOBRsq2I=:WfvYSiL6MdkTwGE9a4W9UO dZFfatbXWlBb647qLde7lZGZzrtEu/bG/JgYUMi0tM7wms2ta2O5WFBy9zM+2uyot9XfGWS17 7WTQa0eLym88G/a/2qQ6yc/zQLnm0nqagEbu98F4f7FedFwz8C9MaVTEr5Be370z3N/JQLIGM QdjEXvH2nYII0puMUDJRw3vPicL+GqNAMSWSrFlx13H4pCMAGzTf8tqdLlbyZ+3l6l5v7YLum 2KrGzsnhCEA98crX4INZL5kdbstT+V2996n8d4iw0ym5Le+OTLq2SA2YlzTYL1pSwE5Sk6sXi 1bwyyMjV3p5tZd7CjB6rhPyaZDIIOUOM1Z9/yB9WfLF4sGLgHnGGwbUpe3h4o4NI1mTrmDfEw PzYNxywaeBMZif+MvTVQ+7OB76Q7b0xPTrDUoFX6FaeshEpuuU6jnnHgaugemSgXC2RuEdWra U2LevgeNcJEnT+HItq6B4mWWldM7RQOqyvHLUqVQ0/vh+Sf3M4Fscxm3Eu5xRpwWMZn2lMLxA uTONmoO6c/gQiz7f7JYciZTCqBXqjM7Jzq41RAxfIH9ZGlmC6P6lTCOg4iUGtXwybbMdU8w3S VltevreddNDnsYuZmkbT2Gu+8pe7PeZYHmnrRp5YYuMmVcRCr02CKicj2um94tEWamYKyoQn8 3sk1x6zW2hTRsvXQoDpQQ6tbbag4ErqOj6aWRTUaxgcCP6VdaYQ4p2OEyZiabMinTPKvqF87r bWp7zsD2UkD10FCz3MRnKxSZ8kZXFKwTev6SJad+zXrETNaPJ8XhiwhqJa8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/KC0Rn7GDPn3ausK2hWgjJOiQX4k>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-i2rs-yang-l3-topology-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2017 16:53:19 -0000

Dear Paul,

Thank you very much for your comments!  They are all good catches, corrected in -14 (that we will post shortly).  

Kind regards
--- Alex

-----Original Message-----
From: Paul Kyzivat [mailto:pkyzivat@alum.mit.edu] 
Sent: Friday, December 1, 2017 9:54 AM
To: draft-ietf-i2rs-yang-l3-topology.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-i2rs-yang-l3-topology-13

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <​http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-i2rs-yang-l3-topology-13
Reviewer: Paul Kyzivat
Review Date: 2017-12-01
IETF LC End Date: 2017-12-11
IESG Telechat date: TBD

Summary:

This draft is basically ready for publication, but has nits that should be fixed before publication.

Disclaimer:

I conducted this review without any knowledge of YANG modeling. So the sort of review I can do is superficial.

Issues:

Major: 0
Minor: 0
Nits:  2

(1) NIT: Section 1 - Language

s/example model is/an example model is/
s/full-blown OSPF model/a complete OSPF model/ s/augments general network/augments the general network/


(2) NIT: Section 4 - typo

Something is wrong with:

    The YANG modules ietf-network and ietf-network are designed to be
    used in conjunction with implementations that support the Network

Did you perhaps mean:

    The YANG modules ietf-network and ietf-network-topology are ...