[Gen-art] Gen-ART review of draft-ietf-rserpool-common-param-16.txt
Suresh Krishnan <suresh.krishnan@ericsson.com> Tue, 15 April 2008 20:54 UTC
Return-Path: <gen-art-bounces@ietf.org>
X-Original-To: gen-art-archive@optimus.ietf.org
Delivered-To: ietfarch-gen-art-archive@core3.amsl.com
Received: from core3.amsl.com (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id EA7DD3A6D2C; Tue, 15 Apr 2008 13:54:50 -0700 (PDT)
X-Original-To: gen-art@core3.amsl.com
Delivered-To: gen-art@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id EEF4C3A6D2C for <gen-art@core3.amsl.com>; Tue, 15 Apr 2008 13:54:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.476
X-Spam-Level:
X-Spam-Status: No, score=-5.476 tagged_above=-999 required=5 tests=[AWL=1.123, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5FO-X8Qsifbd for <gen-art@core3.amsl.com>; Tue, 15 Apr 2008 13:54:49 -0700 (PDT)
Received: from imr2.ericy.com (imr2.ericy.com [198.24.6.3]) by core3.amsl.com (Postfix) with ESMTP id E4BAB3A6A01 for <gen-art@ietf.org>; Tue, 15 Apr 2008 13:54:48 -0700 (PDT)
Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) by imr2.ericy.com (8.13.1/8.13.1) with ESMTP id m3FKtLZu021247; Tue, 15 Apr 2008 15:55:22 -0500
Received: from eusrcmw751.eamcs.ericsson.se ([138.85.77.56]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Tue, 15 Apr 2008 15:55:21 -0500
Received: from [142.133.10.140] ([142.133.10.140]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Tue, 15 Apr 2008 15:55:21 -0500
Message-ID: <480515DF.3070700@ericsson.com>
Date: Tue, 15 Apr 2008 16:53:51 -0400
From: Suresh Krishnan <suresh.krishnan@ericsson.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080227)
MIME-Version: 1.0
To: General Area Review Team <gen-art@ietf.org>, draft-ietf-rserpool-common-param@tools.ietf.org
X-OriginalArrivalTime: 15 Apr 2008 20:55:21.0209 (UTC) FILETIME=[04C6E690:01C89F3B]
Cc: rserpool-chairs@tools.ietf.org, Magnus Westerlund <magnus.westerlund@ericsson.com>
Subject: [Gen-art] Gen-ART review of draft-ietf-rserpool-common-param-16.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: gen-art-bounces@ietf.org
Errors-To: gen-art-bounces@ietf.org
I am the assigned Gen-ART reviewer for draft-ietf-rserpool-common-param-16.txt For background on Gen-ART, please see the FAQ at <http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html>. Please resolve these comments along with any other Last Call comments you may receive. Summary: This draft is on the right track but there are a few issues that need to be fixed. Major ===== * The usage of the Operational Error parameter is not very well specified. Let's say I have an unrecognized parameter of type 0xdead. - What is the actual content of the Unrecognized Parameter cause? Is it just the type code or is it the complete parameter? - When multiple nodes along the path do not recognize a given parameter (say 0xdead - two MSBs are 11) will they each add an Unknown parameter error cause for the same parameter? * IANA considerations The semantics of the message type field described in this document are completely lost since there is no direction to IANA. If you look at the enrp document for example, it requests message types from IANA, but the IANA registry will not contain the semantics about the first two bits. Minor ===== * Section 3 "The value of 65535 is reserved for IETF-defined extensions" This is not shown in the initial allocation request for the IANA. Please fix this. * Section 3.9 What is the namespace that the "Policy Type" comes out of? I could not see a definition of this namespace anywhere. e.g. What does the value 3 mean in this field? This needs to be clarified. * Section 3.15 PE Checksum parameter explicitly shows the padding while the other parameters do not. Please remove the explicit padding from this. I do realize this is the only parameter whose parameter value is not a multiple of 4 octets long Editorial ========= * Section 3.12 ENRP is misspelled as ENPR. Cheers Suresh _______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Gen-ART review of draft-ietf-rserpool-c… Suresh Krishnan
- Re: [Gen-art] Gen-ART review of draft-ietf-rserpo… Michael Tuexen
- Re: [Gen-art] Gen-ART review of draft-ietf-rserpo… Suresh Krishnan