[Gen-art] Gen-art LC (and telechat) review for draft-ietf-regext-epp-rdap-status-mapping-01

Robert Sparks <rjsparks@nostrum.com> Wed, 05 October 2016 20:58 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36539129434; Wed, 5 Oct 2016 13:58:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.896
X-Spam-Level:
X-Spam-Status: No, score=-4.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-2.996] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FCWjB63XgHCB; Wed, 5 Oct 2016 13:58:04 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E653129473; Wed, 5 Oct 2016 13:58:01 -0700 (PDT)
Received: from unnumerable.local ([173.57.161.14]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id u95Kw0Yv051885 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Wed, 5 Oct 2016 15:58:00 -0500 (CDT) (envelope-from rjsparks@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host [173.57.161.14] claimed to be unnumerable.local
To: General Area Review Team <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, regext@ietf.org, draft-ietf-regext-epp-rdap-status-mapping.all@ietf.org
From: Robert Sparks <rjsparks@nostrum.com>
Message-ID: <1016282d-9f98-fc86-572d-ca80c10db3a5@nostrum.com>
Date: Wed, 05 Oct 2016 15:58:00 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Nfgz7-F-x538Y3aAx3n_enq0j-4>
Subject: [Gen-art] Gen-art LC (and telechat) review for draft-ietf-regext-epp-rdap-status-mapping-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2016 20:58:07 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-regext-epp-rdap-status-mapping-01
Reviewer: Robert Sparks
Review Date: 5 Oct 2016
IETF LC End Date: 10 Oct 2016
IESG Telechat date: 13 Oct 2016

Summary: This draft is on the right track but has open issues, described 
in the review.

Major Issue:

Many of the descriptions describe only side-effects of the status 
instead of the status itself.

All of the descriptions for the new rdap status codes start with "For 
DNR that indicates". This implies that there is a "For not DNR" case 
that's not discussed. I don't think the phrase is necessary and each 
description should look more like the other descriptions already 
registered at 
http://www.iana.org/assignments/rdap-json-values/rdap-json-values.xhtml.

For instance, at 'auto renew period' the document currently says:

"For DNR that indicates if the object is deleted by the registrar during 
this period, the registry provides a credit to the registrar for the 
cost of the auto renewal"

That discusses something (and not the only thing) that can happen while 
the object is in that state. It does not describe the state.

I suggest it should instead say (based on the text in 3915 and the 
current registry entry style):

"The object instance is in a grace period provided between when its 
registration period expires and when its registration is automatically 
renewed by the registry."

I don't think it's important to include the commentary about providing a 
credit if the entity is deleted by the registrar during this period, but 
since that commentary exists in 3915, you can include it if you want. 
The _important_ part to convey is the actual status.

All of the descriptions will need similar attention. Some of them (such 
as clientUpdateProhibited) currently have 2119 words in the description. 
That doesn't make sense - this is a status, not an protocol instruction, 
and trying to put normative language in a registry will lead to 
confusion about where the behavior you are trying to describe is 
actually defined. (To be fair, 5731 has this same problem). Again, I 
suggest following the style that's already in the registry and say 
something like "The client has requested that any requests to update 
this object instance be rejected."


Minor Issues:

You're setting up a minor maintenance headache for any future work that 
might update this document by having the descriptions listed in two 
places. I don't think it's necessary to list the descriptions in section 
2 (currently the bulk of page 4 and the beginning of page 5). Instead, 
stop after the paragraph that ends at the top of page 4, and note that 
the descriptions of each new status code are provided in section 3.

Nits:

Near the end of page 3, the document says "In the DNR, the client and 
server prohibited statuses are separate an RDAP MUST support the same 
separation." There are several nits to address with this. That MUST is 
not a good use of 2119. DNR hasn't been expanded (and "the DNR" is not 
particularly clear).

I suggest you replace that sentence, and the one immediately before it with:

"EPP provides status codes that allow distinguishing the case that an 
action is prohibited because of server policy from the case that an 
action is prohibited because of a client request. The ability to make 
this distinction needs to be preserved in RDAP."