Re: [Gen-art] Gen-art last call review: draft-housley-ct-keypackage-receipt-n-error-05

Russ Housley <housley@vigilsec.com> Sun, 01 December 2013 15:36 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4528F1A1F08 for <gen-art@ietfa.amsl.com>; Sun, 1 Dec 2013 07:36:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aGSvFHMoSYq3 for <gen-art@ietfa.amsl.com>; Sun, 1 Dec 2013 07:36:06 -0800 (PST)
Received: from odin.smetech.net (mail.smetech.net [209.135.209.4]) by ietfa.amsl.com (Postfix) with ESMTP id 88B961ACC89 for <gen-art@ietf.org>; Sun, 1 Dec 2013 07:35:54 -0800 (PST)
Received: from localhost (unknown [209.135.209.5]) by odin.smetech.net (Postfix) with ESMTP id 76A7EF24097; Sun, 1 Dec 2013 10:35:42 -0500 (EST)
X-Virus-Scanned: amavisd-new at smetech.net
Received: from odin.smetech.net ([209.135.209.4]) by localhost (ronin.smeinc.net [209.135.209.5]) (amavisd-new, port 10024) with ESMTP id IgcDZOJRX4Xc; Sun, 1 Dec 2013 10:35:21 -0500 (EST)
Received: from [192.168.2.110] (pool-96-241-225-66.washdc.fios.verizon.net [96.241.225.66]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by odin.smetech.net (Postfix) with ESMTP id 552F7F24085; Sun, 1 Dec 2013 10:35:21 -0500 (EST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Apple Message framework v1085)
From: Russ Housley <housley@vigilsec.com>
Date: Sun, 01 Dec 2013 10:35:10 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <71C7F6F1-E6B1-4894-9653-5969E2806723@vigilsec.com>
References: <529511C9.2090005@nostrum.com>
To: Robert Sparks <rjsparks@nostrum.com>
X-Mailer: Apple Mail (2.1085)
Cc: IETF Gen-ART <gen-art@ietf.org>, Stephen Farrell <stephen.farrell@cs.tcd.ie>
Subject: Re: [Gen-art] Gen-art last call review: draft-housley-ct-keypackage-receipt-n-error-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Dec 2013 15:36:28 -0000

> Document: draft-housley-ct-keypackage-receipt-n-error-05
> Reviewer: Robert Sparks
> Review Date: 26 Nov 2013
> IETF LC End Date: 27 Nov 2013
> IESG Telechat date: not yet scheduled
> 
> Summary: Ready
> 
> Two nit-level comments:
> 
> I found the formulation 'The key package error content type MUST be signed if the entity generating it is capable of signing it' awkward. Protocols break if you don't follow a MUST. As written, this says its ok to break the protocol. Is this, instead, really trying to say something about the thing that's going to evaluate the error content type (like "expect a signature unless you're explicitly configured to allow a lack of one")?

Given that this is an error response, I was trying to allow for the situation where the signature cannot be created.  I was trying to say: If it can be signed, please do so.

> The word "above" in "Error codes above this point" is ambiguous. It can mean either "earlier in the document" or "with numbers greater than this value".
> That ambiguity may be harmless (it's easy to resolve by looking at the referenced document), but if you want to remove it, I suggest saying "The error codes listed here with values <=33".

No problem.  Fixed in -06.  I shortened the suggested phrase to avoid a line wrap:

   --  Error codes with values <= 33 are aligned with [RFC5934]

Russ