[Gen-art] Gen-ART review of draft-ietf-6man-udpchecksums-04
"Peter Yee" <peter@akayla.com> Tue, 02 October 2012 23:49 UTC
Return-Path: <peter@akayla.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB54C21F860B; Tue, 2 Oct 2012 16:49:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KWb+dGoseKBF; Tue, 2 Oct 2012 16:49:39 -0700 (PDT)
Received: from p3plsmtpa06-05.prod.phx3.secureserver.net (p3plsmtpa06-05.prod.phx3.secureserver.net [173.201.192.106]) by ietfa.amsl.com (Postfix) with ESMTP id 1BC9321F8608; Tue, 2 Oct 2012 16:49:39 -0700 (PDT)
Received: from spectre ([173.8.184.78]) by p3plsmtpa06-05.prod.phx3.secureserver.net with id 6Ppd1k00G1huGat01PpeKF; Tue, 02 Oct 2012 16:49:38 -0700
From: Peter Yee <peter@akayla.com>
To: draft-ietf-6man-udpchecksums.all@tools.ietf.org
Date: Tue, 02 Oct 2012 16:49:43 -0700
Message-ID: <002e01cda0f8$98f8d3f0$caea7bd0$@akayla.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: Ac2g8orrJo+0BFndRS2G2P+THDWYgQ==
Content-Language: en-us
Cc: gen-art@ietf.org, ietf@ietf.org
Subject: [Gen-art] Gen-ART review of draft-ietf-6man-udpchecksums-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2012 23:49:39 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> Document: draft-ietf-6man-udpchecksums-04 Reviewer: Peter Yee Review Date: Sep-30-2012 IETF LC End Date: Oct-2-2012 IESG Telechat date: Oct-11-2012 Summary: This draft is basically ready for publication, but has nits that should be fixed before publication. [Ready with nits.] Presuming the assumptions in I-D.ietf-6man-udpzero are valid and agreed to by the community, this document provides an update to 2460 to allow the use of zero checksum UDP packets over IPv6 in certain cases involving protocols tunneled inside of UDP packets. Nits: General: references throughout the document to various Internet Drafts will, of course, need to be cleaned up. General: a comma after "e.g." is preferred in American English. Abstract, last sentence: "defines" -> "define" Section 3, first sentence: "tunnelled" -> "tunneled" Change the comma after "checksum" to a period to split the sentence, capitalizing the following "there". Then change "compute" -> "computing" and "check" -> "checking" for parseability. Section 3, last sentence: "cost, " -> "cost". Section 4, 4th paragraph: "The below" -> "The points below" Also: "an UDP" -> "a UDP" Section 4, 1st bullet item, last sentence: "reception UDP" -> "reception of UDP" Section 4, 4th bullet item, 1st sentence: "port, destination" -> "port, and destination" Also: "fields :" -> "fields:" (eliminate a superfluous space character) Section 5, paragraph 5 (the replacement text), last sentence: you refer to RFC 2460. That would seem to read oddly when the replacement text is actually inserted into RFC 2460. I think it would be preferable to put in a specific cross-reference to where in 2460 the existing method resides instead of the document itself. Section 5, item 2, last sentence: "call," -> "call" Section 5, item 5, 1st sentence: "UDP Tunnels" -> "UDP tunnels" for consistency. Section 5, item 6, 2 occurrences: "Non-IP" -> "non-IP" Section 5, item 8, parenthetical: " Necessary" -> "necessary". Note the leading space before "Necessary" that is omitted in the replacement. Section 8 includes one incredibly long run-on sentence. I would suggest splitting it as follows: However, this does not lead to any significant new vulnerabilities as checksums are not a security measure and can be easily generated by any attacker. Properly configured tunnels should check the validity of the inner packet and perform any needed security checks regardless of the checksum status. Most attacks are generated from compromised hosts which automatically create checksummed packets (in other words, it would generally be more, not less, effort for most attackers to generate zero UDP checksums on the host). Authors' Addresses: Unused Fax and URI fields may be omitted. Phone numbers should be presented in international dialing format to facilitate use, e.g., +1 703 501 4376 and +46 10 714 82 87.