[Gen-art] Genart last call review of draft-allan-5g-fmc-encapsulation-07

[Russ Housley via Datatracker <[e-mail]>]

Reviewer: Russ Housley
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-allan-5g-fmc-encapsulation-07
Reviewer: Russ Housley
Review Date: 2021-01-28
IETF LC End Date: 2021-02-05
IESG Telechat date: Unknown


Summary: Almost Ready

Thank you for addressing all of the concerns raie in my earlier review.


Major Concerns:

Section 1 says:

   This encapsulation is expected to be used in environments where RFC
   2516 is deployed. Therefore implementations are required to examine
   the version number and react accordingly.

Please reword as a MUST statement.  Also, a simple sentence that tells
the implementer how to "react accordingly" is needed.  I suspect that
one should follow RFC 2516 if the version is 0x01 and follow this
memo if the version is 0x02.


Minor Concerns:

None.


Nits:

Section 1 says: "... same offset as the [RFC2516] PPPoE data ...".
The [RFC2516] is placed in an awkward location in the sentence.