[Gen-art] Genart last call review of draft-allan-5g-fmc-encapsulation-07
Russ Housley via Datatracker <noreply@ietf.org> Thu, 28 January 2021 16:02 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 235873A1654; Thu, 28 Jan 2021 08:02:24 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-allan-5g-fmc-encapsulation.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.24.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161184974409.10546.4997528219479351790@ietfa.amsl.com>
Reply-To: Russ Housley <housley@vigilsec.com>
Date: Thu, 28 Jan 2021 08:02:24 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/VbdFMCJW38n1JxbmEz0QhZB0FN8>
Subject: [Gen-art] Genart last call review of draft-allan-5g-fmc-encapsulation-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2021 16:02:29 -0000
Reviewer: Russ Housley Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Document: draft-allan-5g-fmc-encapsulation-07 Reviewer: Russ Housley Review Date: 2021-01-28 IETF LC End Date: 2021-02-05 IESG Telechat date: Unknown Summary: Almost Ready Thank you for addressing all of the concerns raie in my earlier review. Major Concerns: Section 1 says: This encapsulation is expected to be used in environments where RFC 2516 is deployed. Therefore implementations are required to examine the version number and react accordingly. Please reword as a MUST statement. Also, a simple sentence that tells the implementer how to "react accordingly" is needed. I suspect that one should follow RFC 2516 if the version is 0x01 and follow this memo if the version is 0x02. Minor Concerns: None. Nits: Section 1 says: "... same offset as the [RFC2516] PPPoE data ...". The [RFC2516] is placed in an awkward location in the sentence.
- [Gen-art] Genart last call review of draft-allan-… Russ Housley via Datatracker
- Re: [Gen-art] Genart last call review of draft-al… David Allan I
- Re: [Gen-art] Genart last call review of draft-al… Russ Housley