[Gen-art] gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04

"Roni Even" <ron.even.tlv@gmail.com> Sun, 08 December 2013 18:18 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D5831AE04A; Sun, 8 Dec 2013 10:18:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id twC4ZoTKsQBi; Sun, 8 Dec 2013 10:18:26 -0800 (PST)
Received: from mail-ea0-x233.google.com (mail-ea0-x233.google.com [IPv6:2a00:1450:4013:c01::233]) by ietfa.amsl.com (Postfix) with ESMTP id 670451ADFC9; Sun, 8 Dec 2013 10:18:26 -0800 (PST)
Received: by mail-ea0-f179.google.com with SMTP id r15so1166581ead.38 for <multiple recipients>; Sun, 08 Dec 2013 10:18:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type :thread-index:content-language; bh=nTei3gglG6TGqwyKQBA0zoQYxFdIv3yyS2xQu9w0PfY=; b=CqUeUWjmYvmzqpIAI9WNUiir9G8xBrkRFgLlBPmswP+rCMcbMIuGguZgvQ8vew6tle T8bLqF1ZIScumPSfnBl+kypN30oRCIQ7yKq7WWBo3VR34wmIaM7A7pWLGKLrl0b7CUZr i/zocVY3zREmj35iIaCoBVcCiX4YvO8/g6WMMK7p/jJsi25ukMBcBy0fUGWZCNsRvirC OtqzH9wh55FV2FIB4K+r87Qgcyyn9hCXieN527QzD0KKmTqxxfKZakxUOad7yzopQL8O KYJBSzhnnMgBX4jNlvbPQfucqSR/u23oLHTZPWTAY6/9x9kJ5uku5koLKud1z5ig1ZGv R/KA==
X-Received: by 10.15.41.140 with SMTP id s12mr9925280eev.50.1386526701341; Sun, 08 Dec 2013 10:18:21 -0800 (PST)
Received: from RoniE ([109.67.11.64]) by mx.google.com with ESMTPSA id a51sm19686320eeh.8.2013.12.08.10.18.17 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Dec 2013 10:18:20 -0800 (PST)
From: Roni Even <ron.even.tlv@gmail.com>
To: draft-ietf-mpls-mldp-hsmp.all@tools.ietf.org, ietf@ietf.org, gen-art@ietf.org
Date: Sun, 08 Dec 2013 20:14:46 +0200
Message-ID: <02c601cef441$64352860$2c9f7920$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_02C7_01CEF452.27BEE2C0"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: Ac70QWA6aBcpRpeSTTGvVsdC1SWomw==
Content-Language: en-us
Subject: [Gen-art] gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Dec 2013 18:18:29 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments you
may receive.

Document: draft-ietf-mpls-mldp-hsmp-04

Reviewer: Roni Even

Review Date:2013-12-8

IETF LC End Date: 2013-12-10

IESG Telechat date: 

 

Summary: This draft is ready for publication as an standard track RFC.

 

 

Major issues:

 

Minor issues:

 

1.  In section 3.1 last paragraph  "If the peer has not advertised the
corresponding capability, then label messages using the HSMP FEC Element
SHOULD NOT be sent to the  peer. ". Why use a SHOULD NOT and not MUSR NOT

 

 

 

Nits/editorial comments:

1.	In section 2 for PTP IEEE1588 need a reference. There is a reference
in the reference section but it is not used. Also the tictoc reference is
not used.