[Gen-art] Gen-ART review of draft-ietf-avt-rtp-amr-bis-05

Harald Alvestrand <harald@alvestrand.no> Fri, 22 September 2006 12:42 UTC

Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1GQkMN-0006ZQ-1l; Fri, 22 Sep 2006 08:42:27 -0400
Received: from [10.91.34.44] (helo=ietf-mx.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1GQkML-0006ZK-SI for gen-art@ietf.org; Fri, 22 Sep 2006 08:42:25 -0400
Received: from eikenes.alvestrand.no ([158.38.152.233]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1GQkMJ-0005Z2-CT for gen-art@ietf.org; Fri, 22 Sep 2006 08:42:25 -0400
Received: from localhost (eikenes.alvestrand.no [127.0.0.1]) by eikenes.alvestrand.no (Postfix) with ESMTP id 23F272596EB; Fri, 22 Sep 2006 14:40:00 +0200 (CEST)
Received: from eikenes.alvestrand.no ([127.0.0.1]) by localhost (eikenes.alvestrand.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 24241-03; Fri, 22 Sep 2006 14:39:49 +0200 (CEST)
Received: from [127.0.0.1] (eikenes.alvestrand.no [127.0.0.1]) by eikenes.alvestrand.no (Postfix) with ESMTP id 5C7C32596F2; Fri, 22 Sep 2006 14:39:49 +0200 (CEST)
Message-ID: <4513DA1F.5000408@alvestrand.no>
Date: Fri, 22 Sep 2006 05:42:07 -0700
From: Harald Alvestrand <harald@alvestrand.no>
User-Agent: Thunderbird 1.5.0.5 (X11/20060719)
MIME-Version: 1.0
To: gen-art@ietf.org, Johan.Sjoberg@ericsson.com, Magnus.Westerlund@ericsson.com, ari.lakaniemi@nokia.com, qxie1@email.mot.com, Cullen Jennings <fluffy@cisco.com>, csp@csperkins.org, taylor@nortel.com, roni.even@polycom.co.il
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new at alvestrand.no
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 8b30eb7682a596edff707698f4a80f7d
Cc:
Subject: [Gen-art] Gen-ART review of draft-ietf-avt-rtp-amr-bis-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Errors-To: gen-art-bounces@ietf.org

I have been selected as the General Area Review Team (Gen-ART)
reviewer for this draft (for background on Gen-ART, please see
http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).

Please resolve these comments along with any other Last Call comments
you may receive.


Document: draft-ietf-avt-rtp-amr-bis-05
Reviewer: Harald Alvestrand
Review Date:  September 22, 2006
IETF LC Date: 2006-09-11
IESG Telechat date: (if known)

Summary: Almost ready for reissuing as Proposed

Comments:

I found this a very slow document to read. It's fairly information-dense, and is in an unfamiliar area.
That is not a complaint; it is more an explanation of why the review has taken longer than I'd have liked.

This document is an update to RFC 3267. This means that the technology basically can't change much without harming interoperability, and I mainly read it for understandability and new features.

I found the technology described difficult to get to grips with. It is a type of communication that relies enormously on out-of-band negotiation (witness the number of parameters in section 8), where any error in negotiation will cause an inability to communicate, while also doing a little bit of inband negotiation (the CMR feature described in section 3.3).
This also means that it's really hard to decode a bitstream captured on the wire without also having captured the out-of-band negotiation; since there is only a dozen or two modes, that's no security, but it makes debugging more difficult.
However, that's a decision that was made before 3267 was written, so it's not reasonable to ask for a change here.

I found the "required to implement" hard to find in this document. Section 3.3 says that all codecs have to support *all* of the bit rates defined there, but that the transport system might limit the available modes (without specifying why) while section 4.5 states that *none* of the operating modes are mandatory to implement. There is a SHOULD for 2 modes of single audio channel in that section; I don't understand why it is not a MUST.

If SHOULD is the desired thing, then I think it would be wise to say something on the order of "any specification that uses this codec SHOULD specify at least one operating mode as mandatory for that application of the codec". See the discussion of interoperable ciphers in TLS for a parallel.

There are some language and spelling errors ("tothe"), and some stylistic choices I disagree with (I like CRCs, not CRC's - the CRC doesn't own anything). These can be handled at the RFC Editor stage.

Apart from the issue of "required to implement", I found no technical choice that I disagreed with and see as reasonable to change at this stage in the process.






_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www1.ietf.org/mailman/listinfo/gen-art