IETF Logo Mail Archive

Re: [Gen-art] Gen-ART Last Call review of draft-ietf-geopriv-held-measurements-07

Martin Thomson <martin.thomson@skype.net> Wed, 08 May 2013 21:06 UTC

Return-Path: <martin.thomson@skype.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6544221F8613 for <gen-art@ietfa.amsl.com>; Wed, 8 May 2013 14:06:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FSyDMP58sakC for <gen-art@ietfa.amsl.com>; Wed, 8 May 2013 14:05:55 -0700 (PDT)
Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2lp0208.outbound.protection.outlook.com [207.46.163.208]) by ietfa.amsl.com (Postfix) with ESMTP id 0127321F8574 for <gen-art@ietf.org>; Wed, 8 May 2013 14:05:54 -0700 (PDT)
Received: from BL2FFO11FD007.protection.gbl (10.173.161.203) by BL2FFO11HUB030.protection.gbl (10.173.161.54) with Microsoft SMTP Server (TLS) id 15.0.687.1; Wed, 8 May 2013 21:05:53 +0000
Received: from TK5EX14HUBC105.redmond.corp.microsoft.com (131.107.125.37) by BL2FFO11FD007.mail.protection.outlook.com (10.173.161.3) with Microsoft SMTP Server (TLS) id 15.0.687.1 via Frontend Transport; Wed, 8 May 2013 21:05:52 +0000
Received: from TK5EX14MBXC254.redmond.corp.microsoft.com ([169.254.2.16]) by TK5EX14HUBC105.redmond.corp.microsoft.com ([157.54.80.48]) with mapi id 14.02.0318.003; Wed, 8 May 2013 21:05:40 +0000
From: Martin Thomson <martin.thomson@skype.net>
To: Suresh Krishnan <suresh.krishnan@ericsson.com>, General Area Review Team <gen-art@ietf.org>, "draft-ietf-geopriv-held-measurements.all@tools.ietf.org" <draft-ietf-geopriv-held-measurements.all@tools.ietf.org>
Thread-Topic: Gen-ART Last Call review of draft-ietf-geopriv-held-measurements-07
Thread-Index: AQHOS6JCXy44NGIX60+anB+zwzcMcJj7jJAQ
Date: Wed, 08 May 2013 21:05:39 +0000
Message-ID: <88EA7D224AA4F24F9D7628368F7572A911BE62DB@TK5EX14MBXC254.redmond.corp.microsoft.com>
References: <5189CE88.2070902@ericsson.com>
In-Reply-To: <5189CE88.2070902@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [157.54.51.72]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Forefront-Antispam-Report: CIP:131.107.125.37; CTRY:US; IPV:CAL; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(51444003)(199002)(189002)(51704005)(85664002)(63696002)(23726002)(20776003)(47776003)(55846006)(47736001)(81542001)(49866001)(51856001)(46102001)(47976001)(16406001)(46406003)(4396001)(31966008)(66066001)(44976003)(53806001)(54356001)(56816002)(76482001)(54316002)(74662001)(6806003)(74366001)(56776001)(69226001)(47446002)(65816001)(74876001)(80022001)(59766001)(33656001)(77982001)(81342001)(50466002)(74706001)(50986001)(74502001)(79102001); DIR:OUT; SFP:; SCL:1; SRVR:BL2FFO11HUB030; H:TK5EX14HUBC105.redmond.corp.microsoft.com; RD:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-OriginatorOrg: microsoft.onmicrosoft.com
X-Forefront-PRVS: 084080FC15
X-Mailman-Approved-At: Wed, 08 May 2013 14:08:39 -0700
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-geopriv-held-measurements-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 May 2013 21:06:01 -0000

Thanks Suresh.

I've made the changes in the -08 that I'm holding for AD go-ahead.  I'll try to remember to send you a note when this goes out.

> Summary: This draft is almost ready for publication as a Proposed
> Standard, but I have a few minor comments that you may wish to address.
> 
> * Section 5.2
> 
> - The Interface-Id option is the DHCPv6 equivalent of the circuit
> identifier defined in RFC3046. Please add a reference to Section 22.18 of
> RFC3315 that describes this option.

Got it.  Thanks.

> - Is there any specific reason that the giaddr is being specified using
> the IPv4-mapped IPv6 address format? From my reading giaddr is of type
> bt:ipAddressType and it allows specification of both IPv4 and IPv6
> addresses natively.

Yeah, that is strange.  I'll use a "normal" address.  (I think that I was just testing out schema validation in the examples and it leaked out.)

> * Section 8.3 Page 44
> 
> IPv4-compatible addresses have been deprecated in the IPv6 addressing
> architecture (RFC4291) and need not be supported here.

That's true, but deprecated != MUST NOT use.  If it's all the same to you, I'd rather just leave as is.  If I were to make a change, it would be to remove acceptance of the dotted quad portion entirely.  But I think that the mapped address form is in use.  I'd have to check with the working group on that.

> * Section 8.7 Page 53
> 
> I think there may be an off-by-one error here.
>  <xs:maxInclusive value="268435456"/>

Yes, good catch.  Either down by one or maxExclusive :)

v2.23.0 | Report a Bug | By Email