IETF Logo Mail Archive

Re: [Gen-art] Gen-ART review of draft-ietf-ppsp-peer-protocol-10

Jari Arkko <jari.arkko@ericsson.com> Tue, 08 July 2014 12:49 UTC

Return-Path: <jari.arkko@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2F061B2837; Tue, 8 Jul 2014 05:49:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jZ9fEhTR40Wz; Tue, 8 Jul 2014 05:49:35 -0700 (PDT)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8C971B2833; Tue, 8 Jul 2014 05:49:34 -0700 (PDT)
X-AuditID: c1b4fb25-f79da6d000004ad3-c6-53bbe8dc2f08
Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.253.124]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id E6.FD.19155.CD8EBB35; Tue, 8 Jul 2014 14:49:32 +0200 (CEST)
Received: from mail.lmf.ericsson.se (153.88.183.153) by smtp.internal.ericsson.com (153.88.183.50) with Microsoft SMTP Server id 14.3.174.1; Tue, 8 Jul 2014 14:49:31 +0200
Received: from nomadiclab.lmf.ericsson.se (nomadiclab.lmf.ericsson.se [131.160.33.3]) by mail.lmf.ericsson.se (Postfix) with ESMTP id 27C01110295; Tue, 8 Jul 2014 15:49:32 +0300 (EEST)
Received: from nomadiclab.lmf.ericsson.se (localhost [127.0.0.1]) by nomadiclab.lmf.ericsson.se (Postfix) with ESMTP id 2FDEF4EA38; Tue, 8 Jul 2014 15:50:18 +0300 (EEST)
Received: from [IPv6:::1] (localhost [127.0.0.1]) by nomadiclab.lmf.ericsson.se (Postfix) with ESMTP id 339B34E98F; Tue, 8 Jul 2014 15:50:17 +0300 (EEST)
Content-Type: multipart/signed; boundary="Apple-Mail=_E5475A45-3AD0-4562-B693-E50CEE8435A6"; protocol="application/pkcs7-signature"; micalg="sha1"
MIME-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
From: Jari Arkko <jari.arkko@ericsson.com>
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B1D3AB180@ESESSMB209.ericsson.se>
Date: Tue, 08 Jul 2014 08:49:27 -0400
Message-ID: <3D7C8F0B-3B28-4C7F-90A8-B52CF3BCBC16@ericsson.com>
References: <7594FB04B1934943A5C02806D1A2204B1D3AB180@ESESSMB209.ericsson.se>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.1878.2)
X-Virus-Scanned: ClamAV using ClamSMTP
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42KZGfG3RvfOi93BBl+vaVucX3mD1eLqq88s FjP+TGR2YPZYsuQnk8eXy5/ZApiiuGxSUnMyy1KL9O0SuDJOTj7AUjDNqeJNQxd7A+Mimy5G Tg4JAROJ3pv72SFsMYkL99azdTFycQgJHGWUuNU+mQnCWc8o8eruDXYIZy+jxJqLq6Ey6xgl /ly+xArhzGOUOLXzLliGWWAKo8SSzfuYQSbzChhIrFt8jBHEFhbwlPh3/jALiM0moCWxcfkC NhCbU8BPon3NDFYQm0VARaJ99kqwGmaQFZtPZUHMsZd42PUV7FohAV+JfXvXg9WICJhJXP/c ywTxhbzEjPYTUB+pSVw9t4kZol5F4tbfs2wTGEVmIbtvFpL7ZoHt05ZYtvA1M4RtIPG08xUr hG0q8froR6gaa4kZvw6yQdiKElO6H7IvYGRfxShanFqclJtuZKyXWpSZXFycn6eXl1qyiREY bQe3/FbdwXj5jeMhRgEORiUeXoUHu4KFWBPLiitzDzFKc7AoifMuPDcvWEggPbEkNTs1tSC1 KL6oNCe1+BAjEwenVAOjpnvskeanSXurWKPVd/wSeKx/IljG+auL/2KreXGvv0R9PRYYUJu2 ybNwlfoco63vEtoDf7QxzTRwCcq7LfngMMMMpb9eZ+O9pST+ha3YwfP7XYfQlN/zDm5Ja7Ln D/mSHPkhW7ps1yxN+dRIoQmPSrv17HPCVHnn6+7X9+bPM2U9t2KXZIwSS3FGoqEWc1FxIgCc JW4ZlwIAAA==
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/X75BRqPSOkPv4xN6JJszAKL4zuU
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-ppsp-peer-protocol.all@tools.ietf.org" <draft-ietf-ppsp-peer-protocol.all@tools.ietf.org>, The IESG <iesg@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-ppsp-peer-protocol-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jul 2014 12:49:37 -0000

Thank you for the review, Christer.

FWIW, I agree with the points that Christer raises. Any thoughts from the authors?

When I read sections 8.14 and 8.15 they do not give as precise instruction for the implementer about how to handle keepalives and dead peer detection as I’d personally like to see. Perhaps a sentence could be added to explain what a node does (or stops doing) when it declares a peer dead.

Jari

On 30 Jun 2014, at 06:07, Christer Holmberg <christer.holmberg@ericsson.com> wrote:

> 
> I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
> 
> Document:                         draft-ietf-ppsp-peer-protocol-10
> 
> Reviewer:                           Christer Holmberg
> 
> Review Date:                     30 June 2014
> 
> IETF LC End Date:             1 July 2014
> 
> IETF Telechat Date:         10 July 2014
> 
> Summary:                         The document is well written, and almost ready for publication. However, there is a minor issue which I ask the authors to address.
> 
> Major Issues: None
> 
> Minor Issues:
> 
> Section 3.12 talks about keep alive signaling.
> 
> Q1: The sending of keep alives is a SHOULD, and there are no procedures on how to act if keep alives are not received. There isn't even a mechanism to negotiate the sending of keep alives. 
> 
> So, I assume it means that a peer shall not take any actions if it does NOT receive keep alives, or even rely on receiving keep alives to begin with? If so, I think it would be good to clarify that.
> 
> Q2: As the sending of keep alives is a SHOULD, are there example cases when keep alives would NOT be sent?
> 
> Q3: The text saying "to each peer it wants to interact with in the future" sounds a little strange to me. How does a peer know with whom it wants to interact in the future? Perhaps the text instead should talk about peers with whom one wants to maintain a signaling channel, or something like that?
> 
> 
> Editorial nits: None
> 
> 
> Regards,
> 
> Christer
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email