Re: [Gen-art] Genart last call review of draft-ietf-spring-segment-routing-ldp-interop-11
Joel Halpern Direct <jmh.direct@joelhalpern.com> Mon, 21 May 2018 16:13 UTC
Return-Path: <jmh.direct@joelhalpern.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0F5F12E8D3; Mon, 21 May 2018 09:13:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=joelhalpern.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cDsfST0uEm9p; Mon, 21 May 2018 09:13:15 -0700 (PDT)
Received: from mailb1.tigertech.net (mailb1.tigertech.net [208.80.4.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12B8D128959; Mon, 21 May 2018 09:13:14 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailb1.tigertech.net (Postfix) with ESMTP id E735DD4038A; Mon, 21 May 2018 09:13:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelhalpern.com; s=2.tigertech; t=1526919193; bh=kekTtZIrVJ+DASwmhRaQJ0NYVHhhuoDCrv3OTODpERM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=JSn7Hr3XKUxt/QxMA7mNwOe4Dupze+tiA369L8/6uMq4O7L3+gyv8ZSYGf7sbaU3M B2xu770tC+xsj4nCeDtumu0HMpk3BI1BRj89lfClM4SW//xX9HN9e/LpGYE+/F0ZcW zSYYcgar8IweViH8F4F5XCBlCj5eOSBLvulyi1Fs=
X-Virus-Scanned: Debian amavisd-new at mailb1.tigertech.net
Received: from Joels-MacBook-Pro.local (209-255-163-147.ip.mcleodusa.net [209.255.163.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailb1.tigertech.net (Postfix) with ESMTPSA id 2D77BD408B6; Mon, 21 May 2018 09:13:13 -0700 (PDT)
To: Ahmed Bashandy <abashandy.ietf@gmail.com>, gen-art@ietf.org
Cc: draft-ietf-spring-segment-routing-ldp-interop.all@ietf.org, spring@ietf.org, ietf@ietf.org
References: <152632807068.10078.4478550408904407310@ietfa.amsl.com> <4022c55b-e3f9-2b3d-079e-6eb5acb2e08a@gmail.com>
From: Joel Halpern Direct <jmh.direct@joelhalpern.com>
Message-ID: <5e9a4f57-15a0-19f0-d88a-6cf7dcc704a7@joelhalpern.com>
Date: Mon, 21 May 2018 12:13:12 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <4022c55b-e3f9-2b3d-079e-6eb5acb2e08a@gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/_8BasiNgfkSnBAhkJZqFegkIBDo>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-spring-segment-routing-ldp-interop-11
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2018 16:13:28 -0000
Thank you. I apologize for missing the other normative items. With those, plus the elaboration on the SRMS, the status as PS makes good sense. Yours, Joel On 5/21/18 11:45 AM, Ahmed Bashandy wrote: > Thanks a lot for the review > > The document specifies externally visible behavior that must be > implemented by routers, otherwise SR and LDP routers cannot talk to each > other. For example, section 4.2.2 specifies preference rules. Another > example is the last two paragraphs in section 4.2.1. Hence I do not > think it can be informational. A third example is section 4.2 which > requires the existence of one SRMS in order for SR-only to speak to > LDP-only routers > > But I agree that a more crisp description of SRMS is warranted. I will > add a section describing the SRMS functionality and specifying what to > do when receiving both prefix-SID sub-tlv and SRMS advertisements in the > next version, which I plan to send out in the next few days > > > Ahmed > > > > On 5/14/18 1:01 PM, Joel Halpern wrote: >> Reviewer: Joel Halpern >> Review result: Ready with Issues >> >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please treat these comments just >> like any other last call comments. >> >> For more information, please see the FAQ at >> >> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. >> >> Document: draft-ietf-spring-segment-routing-ldp-interop-11 >> Reviewer: Joel Halpern >> Review Date: 2018-05-14 >> IETF LC End Date: 2018-05-24 >> IESG Telechat date: Not scheduled for a telechat >> >> Summary: This document appears to be ready for publication as an RFC. >> The >> question of whether it is an Informational RFC or a Proposed Standards >> track >> RFC is one that the ADs should examine. >> >> Major issues: >> This document is quite readable, and quite useful. If my reading >> below >> (minor comment about section 4.2) is wrong, then everything is fine. >> However, reading the text, it does not appear to define SRMS. >> Rather, it >> describes a good way to use SRMS to achive smooth SR - LDP >> integration and >> migration. As such, this seems to me to be a really good >> Informational >> Document. >> >> Minor issues: >> Section 4.2 states that it defines the SRMS (Segment Routing Mapping >> Server). Looking at the relevant routing protocol document, they >> point to >> >> https://tools.ietf.org/html/draft-ietf-spring-conflict-resolution-05 >> as the >> defining source for the SRMS. And that document does appear to >> define the >> SRMS. >> >> Nits/editorial comments: >> >> >
- [Gen-art] Genart last call review of draft-ietf-s… Joel Halpern
- Re: [Gen-art] [spring] Genart last call review of… Les Ginsberg (ginsberg)
- Re: [Gen-art] [spring] Genart last call review of… Joel Halpern Direct
- Re: [Gen-art] [spring] Genart last call review of… Les Ginsberg (ginsberg)
- Re: [Gen-art] [spring] Genart last call review of… Joel Halpern Direct
- Re: [Gen-art] Genart last call review of draft-ie… Ahmed Bashandy
- Re: [Gen-art] Genart last call review of draft-ie… Joel Halpern Direct
- Re: [Gen-art] Genart last call review of draft-ie… Ahmed Bashandy