[Gen-art] Gen-ART Last Call review of draft-ietf-teep-architecture-16
Paul Kyzivat <pkyzivat@alum.mit.edu> Mon, 04 April 2022 21:28 UTC
Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 349E13A19EC; Mon, 4 Apr 2022 14:28:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.01
X-Spam-Level:
X-Spam-Status: No, score=-2.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=alum.mit.edu
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2ZJROXAKpVcr; Mon, 4 Apr 2022 14:28:03 -0700 (PDT)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20628.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::628]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 67A083A19ED; Mon, 4 Apr 2022 14:28:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNswdgstve/tDiGtL7M3p2zOt/RLbEo+iACp1eZi6VWzbThINO0F6wRRdw9pKYuHTli7LmfBIxeAzKvejdPZECq+KCYQq+juQ0ybTB0th6ODIHeJ7Crt8YrUjhH/hC+ANk4sFn4t3DJ/3ZaxTIAhpSY9ff8ff4nMxWtYPOgp5Vh02c0LgNcOIrJZcwr9EK4+xPCy1XXuE1yU/ZhNhZwohmBKyryM5qbEdFXbV6/jq8fdIHlzr9BEDY3FDvMbcnnyZebPEz2a3kdlNExifvvtC1eFZrpn5omlp63wxQOUFO4v2r/mWu7s3xTyzc1q6VrnBGQ+XlS6zTYJN9RQT7NjSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gxWSo0iFDnIDl0xpALZrwRjpzBrjBNrWYw0jx5sIp9Q=; b=MIWc/RQ/W9W/Er/zW+WT93gYsRkrU9j/CvUMEz5kE7K0hufUfE6aJtbI35Xfvh2cp0bZOgamT9rE43wkwX1VWG1SfSqxAbR7hlZfAkF+TpI5vi08AI2sinf2784gkS8F3dljs4lYbOkoNu6Q/Uw4K3j1pf1m71QPjezE99nepPgbEGds+YG2wyE3LtAGbO8rmVTocW5QjV5kdHAmrReFekrgjl5US+ScWQE4Lemjm1VPITPw4+eP7oJoHNrl/3CKsZ/0SSjMDC7N9iiw0iYKXbOpSedOxwFo2l94wOXEu1CpMJ004vOCovInJMJZQQyephhJLWouWyDhMT/oiey0Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 18.7.68.33) smtp.rcpttodomain=ietf.org smtp.mailfrom=alum.mit.edu; dmarc=pass (p=none sp=none pct=100) action=none header.from=alum.mit.edu; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alum.mit.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gxWSo0iFDnIDl0xpALZrwRjpzBrjBNrWYw0jx5sIp9Q=; b=CfPRd8rrM9lk0tn3MvEMYthdsJIdrdlda8mtIaWRK6egSmjluW09pQGWMy00oWCWSNz9vf1ee/xJeBgUWUZjUHedJqXwGjdMr9TBrBRmwY1ev5pfEVlaO8YQzIlh0oiMDK/2XcOa7rmtrOM5yhXu7FhwFNC3s3c8G8CMsKO21Zc=
Received: from SN4PR0501CA0125.namprd05.prod.outlook.com (2603:10b6:803:42::42) by BN8PR12MB3345.namprd12.prod.outlook.com (2603:10b6:408:64::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 21:27:58 +0000
Received: from SN1NAM02FT0043.eop-nam02.prod.protection.outlook.com (2603:10b6:803:42:cafe::8c) by SN4PR0501CA0125.outlook.office365.com (2603:10b6:803:42::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.19 via Frontend Transport; Mon, 4 Apr 2022 21:27:58 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 18.7.68.33) smtp.mailfrom=alum.mit.edu; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=alum.mit.edu;
Received-SPF: Pass (protection.outlook.com: domain of alum.mit.edu designates 18.7.68.33 as permitted sender) receiver=protection.outlook.com; client-ip=18.7.68.33; helo=outgoing-alum.mit.edu;
Received: from outgoing-alum.mit.edu (18.7.68.33) by SN1NAM02FT0043.mail.protection.outlook.com (10.97.5.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19 via Frontend Transport; Mon, 4 Apr 2022 21:27:57 +0000
Received: from [192.168.1.52] (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.14.7/8.12.4) with ESMTP id 234LRsBb030036 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 4 Apr 2022 17:27:55 -0400
Message-ID: <1d5bee64-402c-b14a-20f2-b9a5787af5a3@alum.mit.edu>
Date: Mon, 04 Apr 2022 17:27:54 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: draft-ietf-teep-architecture.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>
Content-Language: en-US
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e72a993-8f96-41fa-bcbd-08da1681fcb7
X-MS-TrafficTypeDiagnostic: BN8PR12MB3345:EE_
X-Microsoft-Antispam-PRVS: <BN8PR12MB33459CA58BAD4094958D5A9FF9E59@BN8PR12MB3345.namprd12.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tThfGNGlE3ZOE2E110K8VMKfEIpyn3HvEO29Id3knF46tdvE/hNoNnxHO15zJuZI+BWzrp9LF+6kSuhVkN7TvaO+v9OX41D1qHiVlnkTJpltg3t1hCkbRIClj/QPQBZxfAM7vaX0K49a61Xj5AjmEvkezZD6czegYM3cgbR7QRdCGBk6YfSKbFyTfsfycdPEUN5qgJr+L4qiwwtCY54GVU3H4Jnq2yQ37cV3FtDvDQgZ5en31nk7ZjgD2d25b/3ZetpPQUw7FtPzpuD3/SN1CQizGpXS22Sod74n5ASpvYOB505piqGOfB3kErSAENwOG0+xwIDvOEFHZpoUTdxLmJkZeLln0mkdBUvBYcYA+0oFgDVtV4YcFOocgRPFA6eCDMVMTkyZwOFgoVZzKhrzRg6xjvS168kAaK1/Xg5CZNlPJyCm+/sNBFQVWyVO2RBKTlvI2AG+FVKy/RhtteShPHSj2a5nRA3eNF5H0b9hvB8Sk795bco4sESYW/xvRq4nsP9w/Mj48OEJEEqKE6SdPYGoln9sf15nj1Ex7XJ6b23aBI819mbA1BNc5k4eYIslxxznReJkIBPsmrqmq0Kv6w1hhl9Jpj/y0/eLvyRtt2DBg5PmNhu06WB3RY9bVpg8kFlrIFAXJ92T90jM3+riKXdGFMqGd/uxGzaNtghwJUL4cqqeHB3+UU6caPWTNmgxAqHgku2KnACD3L/vI63Nq2/xJmImHYr8qTTvD0emDSZdWqlgfAf5CZ1Gr4JmAurz
X-Forefront-Antispam-Report: CIP:18.7.68.33; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:outgoing-alum.mit.edu; PTR:outgoing-alum.mit.edu; CAT:NONE; SFS:(13230001)(46966006)(36840700001)(26005)(336012)(186003)(7596003)(450100002)(70206006)(4326008)(70586007)(8676002)(6916009)(31686004)(83380400001)(316002)(786003)(47076005)(86362001)(508600001)(31696002)(5660300002)(2616005)(75432002)(356005)(82310400004)(36860700001)(8936002)(956004)(2906002)(43740500002); DIR:OUT; SFP:1101;
X-OriginatorOrg: alum.mit.edu
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 21:27:57.0963 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e72a993-8f96-41fa-bcbd-08da1681fcb7
X-MS-Exchange-CrossTenant-Id: 3326b102-c043-408b-a990-b89e477d582f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3326b102-c043-408b-a990-b89e477d582f; Ip=[18.7.68.33]; Helo=[outgoing-alum.mit.edu]
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0043.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3345
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/_PQLgwbAxaVsfWgfg62QZHYYlYs>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-teep-architecture-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Apr 2022 21:28:09 -0000
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please treat these comments just
like any other last call comments.
For more information, please see the FAQ at
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
Document: draft-ietf-teep-architecture-16
Reviewer: Paul Kyzivat
Review Date: 2022-04-??
IETF LC End Date: 2022-04-07
IESG Telechat date: ?
Summary:
This draft is on the right track but has open issues, described in the
review.
Issues:
Major: 0
Minor: 2
Nits: 3
1) MINOR: Section 4.5, Fig 3
I find this figure confusing. It starts out looking like a sequence
diagram, where time flows from top to bottom. But then overlayed on it
is a nested text outline that seems to interact with the sequence
diagram. Based on the outline numbering I expect the time sequence to be
2a,2b,3,4. but based on positioning within the sequence diagram it seems
that the order should be 2a,3,2b,4. I don't understand how this is
intended to be read.
2) MINOR: Section 6.2.1:
Is any persistent state assumed in this API or is it stateless? If state
is assumed, I would like to see the state model described.
3) NIT: Section 1: NIT
TEEs use hardware enforcement combined with software protection to
secure TAs and its data.
s/its/their/
4) NIT: Section 2: Device User:...
The last sentence is a fragment. Needs to be reworded.
5) NIT: IdNits
IdNits reports a couple of outdated references that need updating.
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Lars Eggert