IETF Logo Mail Archive

Re: [Gen-art] Gen-ART Last Call review of draft-ietf-teep-architecture-16

Lars Eggert <lars@eggert.org> Wed, 07 September 2022 17:53 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E4D3C06E160; Wed, 7 Sep 2022 10:53:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0rjQOSzQKYaF; Wed, 7 Sep 2022 10:53:39 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2C2DC06E17A; Wed, 7 Sep 2022 10:53:38 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:1495:40e:6d8d:a96f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id A98F41D4151; Wed, 7 Sep 2022 20:53:28 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1662573208; bh=25DgonxtETt1Ofpg0mEeSsiG4wSCYBd5zKZM7k++Knc=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=RMjJTwPYOD26mwwj0wWiACenV5Ift2hrjeOYAbclhZVk+9xIO0/ClISayLhdPvZMq DOvd2JmyPbD4Ka3t2wRXsx4QWBvhp+PdVdORcUwhUrMi+rRyP7GOT+ZRp49ijtYppp tkTm0Lq3I1IuOoC0LEpfUU7PDQ7HjSxGN4yu0daM=
Content-Type: multipart/signed; boundary="Apple-Mail=_7AB2D5A8-57F4-4533-88C8-BC45F6297B27"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <1d5bee64-402c-b14a-20f2-b9a5787af5a3@alum.mit.edu>
Date: Wed, 07 Sep 2022 20:53:28 +0300
Cc: draft-ietf-teep-architecture.all@ietf.org, General Area Review Team <gen-art@ietf.org>
Message-Id: <EF9F9FE2-9022-4263-9F41-BA2AE1ECEC55@eggert.org>
References: <1d5bee64-402c-b14a-20f2-b9a5787af5a3@alum.mit.edu>
To: Paul Kyzivat <pkyzivat@alum.mit.edu>
X-MailScanner-ID: A98F41D4151.A325D
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/xf8x3ziF-uhlltLM5N6mNqpGvII>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-teep-architecture-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Sep 2022 17:53:42 -0000

Paul, thank you for your review. I have entered a No Objection ballot for this document.

Authors, please take Paul's comments into account if you end up preparing a revision.

Thanks,
Lars


> On 2022-4-5, at 0:27, Paul Kyzivat <pkyzivat@alum.mit.edu> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-teep-architecture-16
> Reviewer: Paul Kyzivat
> Review Date: 2022-04-??
> IETF LC End Date: 2022-04-07
> IESG Telechat date: ?
> 
> Summary:
> 
> This draft is on the right track but has open issues, described in the review.
> 
> Issues:
> 
> Major: 0
> Minor: 2
> Nits:  3
> 
> 1) MINOR: Section 4.5, Fig 3
> 
> I find this figure confusing. It starts out looking like a sequence diagram, where time flows from top to bottom. But then overlayed on it is a nested text outline that seems to interact with the sequence diagram. Based on the outline numbering I expect the time sequence to be 2a,2b,3,4. but based on positioning within the sequence diagram it seems that the order should be 2a,3,2b,4. I don't understand how this is intended to be read.
> 
> 2) MINOR: Section 6.2.1:
> 
> Is any persistent state assumed in this API or is it stateless? If state is assumed, I would like to see the state model described.
> 
> 3) NIT: Section 1: NIT
> 
>   TEEs use hardware enforcement combined with software protection to
>   secure TAs and its data.
> 
> s/its/their/
> 
> 4) NIT: Section 2: Device User:...
> 
> The last sentence is a fragment. Needs to be reworded.
> 
> 5) NIT: IdNits
> 
> IdNits reports a couple of outdated references that need updating.
> 
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email