[Gen-art] Gen-ART review of draft-ietf-dhc-dhcpv4-active-leasequery-05

Christer Holmberg <christer.holmberg@ericsson.com> Sun, 06 September 2015 13:16 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE6161B4B62 for <gen-art@ietfa.amsl.com>; Sun, 6 Sep 2015 06:16:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nxAjnbXR8RdH for <gen-art@ietfa.amsl.com>; Sun, 6 Sep 2015 06:16:32 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A5FE1B46D8 for <gen-art@ietf.org>; Sun, 6 Sep 2015 06:16:31 -0700 (PDT)
X-AuditID: c1b4fb3a-f79136d0000071e2-e1-55ec3cad1a8c
Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.253.124]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id D1.53.29154.DAC3CE55; Sun, 6 Sep 2015 15:16:29 +0200 (CEST)
Received: from ESESSMB209.ericsson.se ([169.254.9.81]) by ESESSHC010.ericsson.se ([153.88.183.48]) with mapi id 14.03.0248.002; Sun, 6 Sep 2015 15:16:28 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-dhc-dhcpv4-active-leasequery-05
Thread-Index: AdDoo8TDZSm9VhPBT2ODTrMHkCxgQQ==
Date: Sun, 06 Sep 2015 13:16:28 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B37A4AD80@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.150]
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B37A4AD80ESESSMB209erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsUyM+Jvje5amzehBi2rpCx6di1htrj66jOL A5PHkiU/mTy+XP7MFsAUxWWTkpqTWZZapG+XwJXx/NZ5poLl8RXb+1cwNzBeD+5i5OSQEDCR uLnqFxuELSZx4d56IJuLQ0jgKKPEmY2/WSCcRYwS31vmATkcHGwCFhLd/7RBGkQENCXmrnjL BBJmFqiX+P7EGiQsLOAq8fLeayaIEi+Jn7u+MkPYehKb534Ci7MIqEiseNbADtLKK+ArsfpS IUiYEeiE76fWgJUwC4hL3HoynwniNAGJJXvOM0PYohIvH/9jhbCVJFZsv8QIUZ8vserQK3YQ m1dAUOLkzCcsExiFZyEZNQtJ2SwkZRBxHYkFuz+xQdjaEssWvmaGsc8ceMyELL6AkX0Vo2hx anFxbrqRkV5qUWZycXF+nl5easkmRmDsHNzy22oH48HnjocYBTgYlXh4Fea9DhViTSwrrsw9 xCjNwaIkztvM9CBUSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2P5v5x3z4qWX1A3m/R9aa3/ RwFlln8Pt5gZTOnl2fu2v+XhKVWzIx41V9O2XmS6xKxalP7r0P2ri58rROj/X8J34vDS/y3l +SsVxJeHLHn1XPzGpLL6WrnFCdFveMOO3FkcKH7xU631u1UlJ6/PPqEw6bB4DPOfe99SwvsC j8z2/KnsYdPzd7uvEktxRqKhFnNRcSIAPY1Z7X4CAAA=
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/_z1fR0VgGhRCQSQRyu77oHEIQHU>
Cc: "draft-ietf-dhc-dhcpv4-active-leasequery.all@tools.ietf.org" <draft-ietf-dhc-dhcpv4-active-leasequery.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-dhc-dhcpv4-active-leasequery-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Sep 2015 13:16:34 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                                   draft-ietf-dhc-dhcpv4-active-leasequery-05
Reviewer:                                     Christer Holmberg
Review Date:                               6 September 2015
IETF LC End Date:                       8 September 2015
IETF Telechat Date:                   N/A
Summary:         The document is well written, but I have a few comments and issues I'd like the authors to address.
Major Issues: None
Minor Issues: None
Editorial Issues:

General:
-----------
QGEN_1:
The text says that the document updates RFC 6926, but it is a little unclear to figure out exactly what is updated.
I think it would be good to have an explicit "Update to RFC 6926" section which explains exactly which parts are updated.

QGEN_2:
The draft talks about "secure mode" and "insecure mode" in a few places, and defined different procedures based on which mode is used.
However, there is no generic definition for "secure mode" and "insecure mode". I wonder whether it would be useful to add some text somewhere, e.g. to section 2?

Abstract:
------------

QA_1:

The text says:

"The Dynamic Host Configuration Protocol for IPv4 (DHCPv4) has been
              extended with a Leasequery capability that allows a requestor to
              request information about DHCPv4 bindings."

Please indicate in which specification (RFC?) this extension has been done.


Section 1 (Introduction):
---------------------------------

Q1_1:

The text says:

              "Requirements exist for external entities to keep up to date on the
              correspondence between DHCPv4 clients and their bindings."

Are these documented requirements, or generic requirements coming from the industry? Please clarify.


Q1_2:

The text says:

              "This document updates DHCPv4 Bulk Leasequery [RFC6926] in that it
              specifies the DHCPv4 server should close the TCP connection if..."

Is "should" the correct wording? Section 8.4 contains both MAY, SHOULD and MUST procedures, and I am not quite sure which procedure(s) the text above refers.