Re: [Gen-art] Genart last call review of draft-kucherawy-dispatch-zstd-01
Yann Collet <cyan@fb.com> Fri, 20 April 2018 23:22 UTC
Return-Path: <prvs=7648db95f6=cyan@fb.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1647312D950; Fri, 20 Apr 2018 16:22:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.721
X-Spam-Level:
X-Spam-Status: No, score=-2.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, T_DKIMWL_WL_MED=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fb.com header.b=N+gARzhD; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.b=G4c56Lbo
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5QYO9D4BzN6f; Fri, 20 Apr 2018 16:22:16 -0700 (PDT)
Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DC83D12D882; Fri, 20 Apr 2018 16:22:12 -0700 (PDT)
Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3KNJFpj004335; Fri, 20 Apr 2018 16:22:11 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=CYj1HIlsWWGXXaBX5BE8LAr0SxKCYokxewgu8REe8zA=; b=N+gARzhDpXj6gA49Ki3xjCHi23hKeGkRuPdpU8BgaYJr/uwSMj+jb9+77Wa4+pKXb7L6 16JsQ7F7GJSF4ruHsN/OHdRwFZwo35Tz2jla1YjQlc1bObtQXvS3d3iqcEpVVB56IOBZ 4SCV2DSJfWeoWfX2ewkoWBInjerabtsSyNk=
Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2hfrfk08s0-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 20 Apr 2018 16:22:10 -0700
Received: from NAM01-BY2-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.25) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 20 Apr 2018 19:22:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CYj1HIlsWWGXXaBX5BE8LAr0SxKCYokxewgu8REe8zA=; b=G4c56LboUqf/krBLf14ycLdeWM4n5nw3+wk2kwQoq/LNjUpW+SUtnZyHup1RqiDI68M3WocN0ZgrmJsviXF65iaJZykzRmSjcogGh+2rbOi8dX/u7ygbIY5dBtoE4lFcV/lVR/vnLvwVtNuAHSevM2hufWALZOwards1dC//Aas=
Received: from SN6PR15MB2205.namprd15.prod.outlook.com (52.135.64.145) by SN6PR15MB2493.namprd15.prod.outlook.com (52.135.66.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Fri, 20 Apr 2018 23:22:08 +0000
Received: from SN6PR15MB2205.namprd15.prod.outlook.com ([fe80::71c1:30c3:9a65:3aa4]) by SN6PR15MB2205.namprd15.prod.outlook.com ([fe80::71c1:30c3:9a65:3aa4%13]) with mapi id 15.20.0696.013; Fri, 20 Apr 2018 23:22:08 +0000
From: Yann Collet <cyan@fb.com>
To: Vijay Gurbani <vkg@acm.org>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "ietf@ietf.org" <ietf@ietf.org>, "draft-kucherawy-dispatch-zstd.all@ietf.org" <draft-kucherawy-dispatch-zstd.all@ietf.org>
Thread-Topic: Genart last call review of draft-kucherawy-dispatch-zstd-01
Thread-Index: AQHT1+5kbYIkz6OReUKZJTDPIj+Cv6QJ15UA
Date: Fri, 20 Apr 2018 23:22:08 +0000
Message-ID: <2A5406E6-1816-43C3-AB88-14718B2AB3E8@fb.com>
References: <152414967505.28757.13931035798486807912@ietfa.amsl.com>
In-Reply-To: <152414967505.28757.13931035798486807912@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: acm.org; dkim=none (message not signed) header.d=none;acm.org; dmarc=none action=none header.from=fb.com;
x-originating-ip: [2620:10d:c090:200::6:6503]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; SN6PR15MB2493; 7:8TsLm3z5VRniVlo3Sv8/y0YhvpcXma0jWdGp2NWhwCoUSCiuSUqCb9s8dT/d6vi+8B9VsJdK5Hy65YFMT/gBamXaQARJJ7e8hedLu4OWBxAdauYcQZmvJPRxKu3UlBr5lEEyeiKQvgNnkjNnsdeXHqRx1qFw9gl7JVhhu+dCBHxY/zZlfC+9ln2GZzdmVzd1fpzSGHkbGmcOqAu1ctFS7IQn2AZwsK8XREc9Fu59EbpemwQYzPb3XB1srGEB24xq; 20:i4K6q+nyPWMn+Ipwe++8VNXwy+TwC6SVl0Gal9PZaKaxMP5e4nZnIGPu8IbTO+LwIHcilnqT7EL4A7JArMD7R6W7LNlXeaVVYZxriGFvRIP2HVY7nIXAtnLnUykCKlmKVVyx/EF0hRHMsvtOAsnOeTXzfcMcPsqqoALMERjitks=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN6PR15MB2493;
x-ms-traffictypediagnostic: SN6PR15MB2493:
x-microsoft-antispam-prvs: <SN6PR15MB249360BF07C8F5A5CCA4A86CA4B40@SN6PR15MB2493.namprd15.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(10436049006162)(155532106045638)(81227570615382)(213716511872227);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231232)(11241501184)(944501399)(52105095)(10201501046)(3002001)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:SN6PR15MB2493; BCL:0; PCL:0; RULEID:; SRVR:SN6PR15MB2493;
x-forefront-prvs: 0648FCFFA8
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(366004)(346002)(396003)(376002)(39860400002)(377424004)(86362001)(5250100002)(229853002)(2906002)(114624004)(5660300001)(476003)(2616005)(6116002)(6486002)(446003)(4326008)(186003)(3660700001)(305945005)(7736002)(11346002)(25786009)(2900100001)(110136005)(3280700002)(36756003)(81166006)(6436002)(33656002)(46003)(6512007)(2501003)(102836004)(8936002)(8676002)(316002)(82746002)(6246003)(54906003)(76176011)(6306002)(6506007)(53936002)(83716003)(478600001)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR15MB2493; H:SN6PR15MB2205.namprd15.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv;
x-microsoft-antispam-message-info: rxFq/kUu46T357/DS3tSY4vPXXseUB6CcjtOXdo08Wktuajl1Wc2NDx0NYqojhEGs6GKWoPaZwSZmDxWot2S3uy8nuuoUvEkvCThapfga1dyHOg8JpEZyaeT+BEO5cRnTZRrW+UChFwEw2SrWen8G1l7tPKimmmlvxOOvSpxoKG94japZoT5ndxZxlqhtq4e
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <8D9A064A77655A479821A2616661CF89@namprd15.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: f1bc37d1-7810-4d89-e704-08d5a7158955
X-MS-Exchange-CrossTenant-Network-Message-Id: f1bc37d1-7810-4d89-e704-08d5a7158955
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2018 23:22:08.2272 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2493
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-04-20_10:, , signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/avoatRXFjtpgXS0NDYpZgF9y0m8>
Subject: Re: [Gen-art] Genart last call review of draft-kucherawy-dispatch-zstd-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 23:24:56 -0000
Hi I can answer the following 2 minor points: - S2.1.1.3.1.1: "Value ?0" --> should it be "Value 00"? `?0` means it can be either `10` or `00`. Aka, only the last bit `0` matters. - S2.1.1: The value of the magic number: 0xFD2FB528 --- is there any significance to it? This value was selected to be less probable to find at the beginning of some random file. It avoids trivial patterns (0x00, 0xFF, repeated bytes, increasing bytes, etc.), contains byte values outside of ASCII range, and doesn't map into UTF8 space. It reduces chances that a text file be able to represent this value by accident. For all other points, I have no comment, and agree with reviewer. Rgds Yann Collet Facebook On 4/19/18, 07:55, "Vijay Gurbani" <vkg@acm.org> wrote: Reviewer: Vijay Gurbani Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://urldefense.proofpoint.com/v2/url?u=https-3A__trac.ietf.org_trac_gen_wiki_GenArtfaq&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=_EwH5jTAHV32G13ENXwVrw&m=aMabi5qTp6wXqc6KXVjyGEgbdV5SaoN7tcHeDarFUI8&s=G_jKtEolxxcUUP2uN78WXkDdXi9KsGgZPh0RD34zvIw&e=>. Document: draft-kucherawy-dispatch-zstd-01 Reviewer: Vijay K. Gurbani Review Date: 2018-04-19 IETF LC End Date: 2018-04-23 IESG Telechat date: Not scheduled for a telechat Summary: Ready with 1 minor issue and some nits. Major issues: 0 Minor issues: 2 Nits/editorial comments: 3 Minor: - S4: "... and the usual precautions apply." Here, what are the "usual precautions"? Are they the ones enumerated below? If so, then perhaps restate as "... and the usual precautions apply, as enumerated below.". If the usual precautions are not enumerated below, then a reference should be provided to a resource(s) that enumerates such precautions. - S5: I am curious, why should we remove this section prior to publication? It contains pointers to code that is invaluable to implementors. At the most, I would advise excising company name (Facebook) from the section, but I would advocate strongly to retain this section as the draft becomes a RFC. Nits/Typos: - S2.1.1: The value of the magic number: 0xFD2FB528 --- is there any significance to it? Any insight on how you arrived at this will be interesting. (I am relating this magic number to the SIP magic cookie "z9hG4bK" which was chosen so that the probability was very small of older implementations to randomly pick a branch ID that started with these characters.) - S2.1.1: s/the origina/the original/ - S2.1.1.3.1.1: "Value ?0" --> should it be "Value 00"?
- [Gen-art] Genart last call review of draft-kucher… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ku… Yann Collet
- Re: [Gen-art] Genart last call review of draft-ku… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ku… Yann Collet
- Re: [Gen-art] Genart last call review of draft-ku… Alissa Cooper