IETF Logo Mail Archive

Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-lamps-crmf-update-algs-04

Lars Eggert <lars@eggert.org> Tue, 06 April 2021 12:53 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A7033A245B; Tue, 6 Apr 2021 05:53:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gee_XxAUWGym; Tue, 6 Apr 2021 05:53:37 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C929A3A2042; Tue, 6 Apr 2021 05:52:15 -0700 (PDT)
Received: from [IPv6:2a00:ac00:4000:400:68eb:fc77:3b2:d84e] (unknown [IPv6:2a00:ac00:4000:400:68eb:fc77:3b2:d84e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 138A6600314; Tue, 6 Apr 2021 15:52:10 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1617713530; bh=i3uD+6qrXhWd/e9fF2+kec1QAQTD8MT4Q8CDOcEO+ZM=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=LP5MtS6TZ3pRVC+IcVKcTsMO+ah8nGb5g4AcQlaLK2LbloFTl5Zo/cN8Zav8KLEda 7p2dmSTv2VWWtQKg+XRj6VYSRZa5OglnB8UC1mU6FXfw5jEvE4U/97fumNqy4LKSwE GGqpniya/iEpVZBHiJxaeXUSg/IOsb7w3SS1qkQg=
From: Lars Eggert <lars@eggert.org>
Message-Id: <BD699B71-C07D-49D0-9EB4-618DF3ACAF41@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_07EBE557-3D86-4E00-9670-21DBD0E107BA"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Date: Tue, 06 Apr 2021 15:52:09 +0300
In-Reply-To: <161677207615.11612.13922111242017074185@ietfa.amsl.com>
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-lamps-crmf-update-algs.all@ietf.org, Last Call <last-call@ietf.org>, spasm@ietf.org
To: Ines Robles <mariainesrobles@googlemail.com>
References: <161677207615.11612.13922111242017074185@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3654.60.0.2.21)
X-MailScanner-ID: 138A6600314.A261F
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/e2KZZgfFO1TFspoF6gwx8t6Aayw>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-lamps-crmf-update-algs-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 12:53:42 -0000

Ines, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2021-3-26, at 17:21, Ines Robles via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Ines Robles
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lamps-crmf-update-algs-04
> Reviewer: Ines Robles
> Review Date: 2021-03-26
> IETF LC End Date: 2021-03-26
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> The document updates the cryptographic algorithm requirements for the
> Password-Based Message Authentication Code in the Internet X.509 Public Key
> Infrastructure Certificate Request Message Format (CRMF).
> 
> The document is well written, I have minor comments/questions to the authors.
> 
> Major Issues: None
> 
> Minor Issues: None
> 
> Nits/Comments:
> 
> 1- Introduction: "however, these algorithms are no longer
>   considered the best choices. " => It would be nice to add 1 or more
>   sentences explaining why they are no longer the best choices
> 
> 2- Page 3: "id-PasswordBasedMAC as presented in Section 4.4 of this document"
> It should be perhaps be "id-PasswordBasedMAC as presented in Section 4.4 of
> [RFC4211]" ?
> 
> 3- If this document does not present privacy considerations, should it be
> explicitly mentioned in Section 6?
> 
> 4- Since the new updates include the use of PBMAC1, HMAC-SHA256, AES-GMAC AES.
> Should Section 6 include considerations about them or point to place where to
> find them? e.g. For information on security considerations for PBMAC1 see
> [rfc8018#section-8].
> 
> Thank you for this document,
> 
> Ines.
> 
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email