Re: [Gen-art] Genart last call review of draft-ietf-lamps-samples-05

Daniel Kahn Gillmor <dkg@fifthhorseman.net> Mon, 13 December 2021 22:56 UTC

Return-Path: <dkg@fifthhorseman.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67F4B3A0C05; Mon, 13 Dec 2021 14:56:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (unsupported algorithm ed25519-sha256)" header.d=fifthhorseman.net header.b=IfPajGSx; dkim=pass (2048-bit key) header.d=fifthhorseman.net header.b=a0V9DIGV
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cSBlIyWRFX4k; Mon, 13 Dec 2021 14:56:04 -0800 (PST)
Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9101E3A0C15; Mon, 13 Dec 2021 14:56:04 -0800 (PST)
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1639436162; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=w8bZ6B3yIvG7+7x+HQfhcn1O/zvv9Uuu5LVzfU8Cysc=; b=IfPajGSxJeUhZlXzAFt+R3//oEqtRY8CzeMx5AZNub0HjxS9Cx1qbM5wBcbfsSzMN8dwg WTtWCgPe4YY9bRTDA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1639436162; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=w8bZ6B3yIvG7+7x+HQfhcn1O/zvv9Uuu5LVzfU8Cysc=; b=a0V9DIGV+GB0VPKCbNXR6ibqZpFQC9z1WepegC6Qs+nEdNXXESWSXzdiguk+w3MLX62s9 lGJZMXpYQdeQuaWSoVHZBR45e5Vj/4tl/5n/WwxFjiS8PU9hB0gkKQKB25qwBzR5IjeS3Ow hc/2b9Bc+3xTY1UtxXCFd2/l4ZeAhw8Fi6+OhXPz7ayOzUAs3CRe4gyHsvi+EIo3etaOoxN gell2t24k0V5yYCimSJUePN0Nslq19jVrNByzZjfs4rRIS8ZcPn/gJsemh0K8pyagq/XpbW XyT5htbt+8ReELWC6ciWgUnTeGSGkBAncYMPnz20g6sIPcumwoXiXnZZ2NOA==
Received: from fifthhorseman.net (unknown [94.187.9.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 89DF0F9A5; Mon, 13 Dec 2021 17:56:01 -0500 (EST)
Received: by fifthhorseman.net (Postfix, from userid 1000) id CC4AB204BD; Tue, 14 Dec 2021 00:55:56 +0200 (EET)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: Stewart Bryant <stewart.bryant@gmail.com>, gen-art@ietf.org, draft-ietf-lamps-samples.all@ietf.org, last-call@ietf.org, spasm@ietf.org
In-Reply-To: <20211213034817.GY11486@mit.edu>
References: <163707453393.17796.13018883385449077212@ietfa.amsl.com> <87pmq87e5f.fsf@fifthhorseman.net> <20211213034817.GY11486@mit.edu>
Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH
Date: Tue, 14 Dec 2021 00:55:54 +0200
Message-ID: <87a6h4cdxh.fsf@fifthhorseman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/euyg7hy0SZWQ3liEGsfShVEFCK4>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lamps-samples-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Dec 2021 22:56:11 -0000

On Sun 2021-12-12 19:48:17 -0800, Benjamin Kaduk wrote:
> Hi dkg,
>
> On Tue, Dec 07, 2021 at 03:11:56PM +0200, Daniel Kahn Gillmor wrote:
>> I appreciate your catching these unexpanded acronyms.  I am happy to add
>> expansions for them, or maybe just outbound references if that seems
>> appropriate.
>> 
>> "OCSP" and "CRL" appear in the draft in reference to certificate
>> indicators, meaning specific X.509 extensions; for OCSP i would refer to
>> id-ad-ocsp in the Authority Information Access X.509 extension
>> (i.e., §4.2.2.1 of RFC 5280), and for CRL i would refer to the CRL
>> Distribution Points X.509 extension (i.e., §4.2.1.13 of RFC 5280).
>> 
>> For "PEM encoding" I would add an informative reference to RFC 7468,
>> where §5 describes certificates and §10 describes private keys.
>> 
>> Would that be a useful set of changes to the document?
>
> IMHO, yes.

OK, i just uploaded draft-ietf-lamps-samples-06 with these changes and
Roman's edits, but i somehow goofed and modified the PKCS#12 files from
how they were in -05.

I've subsequently uploaded -07 with the PKCS#12 restored to how it was
in -05, as you can see here:

https://www.ietf.org/rfcdiff?url1=draft-ietf-lamps-samples-05&url2=draft-ietf-lamps-samples-07

I note that there is also a change in how the text versions are
rendered, because the surrounding quotation marks have been dropped as
of xml2rfc version 3.7 (see
https://trac.ietf.org/trac/xml2rfc/ticket/600) -- the underlying xml
source has no changes for those elements.  I'd have preferred the text
version to actually do the quote-wrapping of the substrings, but not
enough to introduce quotation marks into the HTML version, which i think
is a cleaner way to read these samples anyway (easier to extract the
sourcecode blobs, at any rate).

So, I think this addresses all of the outstanding requests that i've
seen about this draft.  If there's anything else i can do to help move
this along, please let me know.

        --dkg