Re: [Gen-art] Re: Gen-ART Last Call Review of draft-ietf-avt-hc-over-mpls-protocol-07

Brian E Carpenter <brc@zurich.ibm.com> Thu, 08 February 2007 10:34 UTC

Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1HF6bk-0000Wc-EH; Thu, 08 Feb 2007 05:34:28 -0500
Received: from [10.91.34.44] (helo=ietf-mx.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1HF6bi-0000WX-LW for gen-art@ietf.org; Thu, 08 Feb 2007 05:34:26 -0500
Received: from mtagate1.de.ibm.com ([195.212.29.150]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1HF6bg-00018l-NN for gen-art@ietf.org; Thu, 08 Feb 2007 05:34:26 -0500
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l18AYO5A160966 for <gen-art@ietf.org>; Thu, 8 Feb 2007 10:34:24 GMT
Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com [9.149.165.212]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l18AYOdS561184 for <gen-art@ietf.org>; Thu, 8 Feb 2007 11:34:24 +0100
Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l18AYNEb021207 for <gen-art@ietf.org>; Thu, 8 Feb 2007 11:34:23 +0100
Received: from sihl.zurich.ibm.com (sihl.zurich.ibm.com [9.4.16.232]) by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l18AYMmj021175; Thu, 8 Feb 2007 11:34:22 +0100
Received: from [9.4.210.81] ([9.4.210.81]) by sihl.zurich.ibm.com (AIX4.3/8.9.3p2/8.9.3) with ESMTP id LAA206166; Thu, 8 Feb 2007 11:34:19 +0100
Message-ID: <45CAFCAB.4040100@zurich.ibm.com>
Date: Thu, 08 Feb 2007 11:34:19 +0100
From: Brian E Carpenter <brc@zurich.ibm.com>
Organization: IBM
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To: "Andrew G. Malis" <agmalis@gmail.com>
Subject: Re: [Gen-art] Re: Gen-ART Last Call Review of draft-ietf-avt-hc-over-mpls-protocol-07
References: <07a501c74adc$3d162330$ad600240@china.huawei.com> <8c99930d0702071411k74aef3a0w1888e3ffd7d35d52@mail.gmail.com> <085401c74b0f$365c9be0$ad600240@china.huawei.com> <8c99930d0702072206p2a04f2eduaea2b9c3507a1ca@mail.gmail.com>
In-Reply-To: <8c99930d0702072206p2a04f2eduaea2b9c3507a1ca@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Scan-Signature: bc102ac530ba955ef81f1f75b8bebe44
Cc: ext Cullen Jennings <fluffy@cisco.com>, Jerry Ash <gash@att.com>, pwe3-chairs@tools.ietf.org, jameshand@att.com, Mark Townsley <townsley@cisco.com>, andrew.g.malis@verizon.com, General Area Review Team <gen-art@ietf.org>, avt-chairs@tools.ietf.org
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Errors-To: gen-art-bounces@ietf.org

Andy,

On 2007-02-08 07:06, Andrew G. Malis wrote:
> Spencer,
> 
> Works for me. Generally, is there another spin of a draft following a
> gen-art review, or can the changed be handled by instructions to the RFC
> editor?

Generally, it depends ;-) The document shepherd should advise you on this.
A few small edits are often handled by a note to the RFC Editor, but
if that gets clumsy, a new spin may be appropriate.

     Brian
> 
> Jerry, if you're going to do another rev, my new contact information is:
> 
> Andrew G. Malis
> Verizon Communications
> 40 Sylvan Road
> Waltham, MA  02451
> USA
> Email: andrew.g.malis@verizon.com
> 
> Cheers,
> Andy
> 
> On 2/7/07, Spencer Dawkins <spencer@mcsr-labs.org> wrote:
>>
>>  Hi, Andy (and the rest of the crew)
>>
>> That's what I thought was happening, based on comments in the ID tracker.
>> This one is easy, I think.
>>
>> OId:
>>
>> The following PW type values have been set aside for
>>   assignment by IANA:
>>
>> New:
>>
>> IANA has set aside the following PW type values for assignment:
>>
>> May they always be so easy, if this works for you :-)
>>
>> Thanks,
>>
>> Spencer
>>
>> ----- Original Message -----
>> *From:* Andrew G. Malis <agmalis@gmail.com>
>> *To:* Spencer Dawkins <spencer@mcsr-labs.org>
>> *Cc:* avt-chairs@tools.ietf.org ; pwe3-chairs@tools.ietf.org ;
>> jameshand@att.com ; Jerry Ash <gash@att.com> ; Mark 
>> Townsley<townsley@cisco.com>; ext
>> Cullen Jennings <fluffy@cisco.com> ; General Area Review 
>> Team<gen-art@ietf.org>; Andrew
>> Malis <agmalis@gmail.com> ; andrew.g.malis@verizon.com
>> *Sent:* Wednesday, February 07, 2007 4:11 PM
>> *Subject:* Re: Gen-ART Last Call Review of
>> draft-ietf-avt-hc-over-mpls-protocol-07
>>
>>
>> Spencer,
>>
>> Thanks for your review.  Please note that I'm no longer at Tellabs -
>> Jerry, we can put in my new contact info in a note to the RFC Editor,
>> assuming we don't need to do another rev. If we do, we can put in my new
>> contact info there.
>>
>> As the primary editor, I'll let Jerry speak to the nits.  However, I can
>> reply regarding your comments on sections 5.1 and 5.2.  In these cases,
>> IANA actually has already reserved the included values for this draft, 
>> and
>> we're just reflecting the fact that IANA has already reserved them - 
>> we're
>> really not requesting the assignments, since they've already been 
>> done.  If
>> you can suggest a less confusing way to reflect that, we can put it 
>> in.  The
>> references to the other RFCs are where ROHC is specified, ECRTP is
>> specified, etc.
>>
>> Thanks again,
>> Andy
>>
>> On 2/7/07, Spencer Dawkins <spencer@mcsr-labs.org> wrote:
>> >
>> > I have been selected as the General Area Review Team (Gen-ART)
>> > reviewer for this draft (for background on Gen-ART, please see
>> > http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
>> >
>> > Please resolve these comments along with any other Last Call comments
>> > you may receive.
>> >
>> > Document: draft-ietf-avt-hc-over-mpls-protocol-07
>> > Reviewer: Spencer Dawkins
>> > Review Date: 2007-01-30
>> > IETF LC End Date: 2007-07-07
>> > IESG Telechat date: (not known)
>> >
>> > Summary: This document is on the right track for publication as 
>> Proposed
>> >
>> > Standard. I had some questions (please see below), but the quality
>> > seemed
>> > very good (thanks for that).
>> >
>> > I'd like to see some work on my comments in 5.1, 5.2 (especially 
>> 5.2.1),
>> > and
>> > 5.3. I had some comments on clarity in section 6, but these were
>> > more-than-nits-but-not-problems.
>> >
>> > Thanks!
>> >
>> > Spencer
>> >
>> > Comments:
>> >
>> > 1. Introduction
>> >
>> >   Voice over IP (VoIP) typically uses the encapsulation
>> >   voice/RTP/UDP/IP.  When MPLS labels [RFC3031] are added, this becomes
>> >   voice/RTP/UDP/IP/MPLS-labels.  MPLS VPNs (e.g., [RFC2547]) use label
>> >   stacking, and in the simplest case of IPv4 the total packet header is
>> >   at least 48 bytes, while the voice payload is often no more than 30
>> >   bytes, for example.  When IPv6 is used, the relative size of the
>> >   header in comparison to the payload is even greater.  The interest in
>> >   header compression (HC) is to exploit the possibility of
>> >   significantly reducing the overhead through various compression
>> >   mechanisms, such as with enhanced compressed RTP (ECRTP) [RFC3545]
>> >   and robust header compression (ROHC) [RFC3095], and also to increase
>> >   scalability of HC.  MPLS is used to route HC packets over an MPLS
>> >   label switched path (LSP) without compression/decompression cycles
>> >   at each router.  Such an HC over MPLS capability can increase
>> >   bandwidth efficiency as well as the processing scalability of the
>> >   maximum number of simultaneous compressed flows that use HC at each
>> >   router.  Goals and requirements for HC over MPLS are discussed in
>> >   [RFC4247].  The solution put forth in this document using MPLS
>> >   pseudowire (PW) technology has been designed to address these goals
>> >   and requirements.
>> >
>> > Spencer (Nit): I think the last sentence is actually "The solution 
>> using
>> > MPLS pseudowire
>> > (PW) technology put forth in this document has been designed to address
>> > these goals and requirements." (the solution wasn't actually put forth
>> > using
>> > MPLS PW technology :-)
>> >
>> > 2. Contributors
>> >
>> >   Besides the editors listed in Section 12, the following people
>> >   contributed to the document:
>> >
>> > Spencer (Nit): I like the use of this section, but it seems odd to have
>> > it
>> > so far from the acknowledgements section. I'm not sure if IESG has an
>> > agreed
>> > sense of taste for placement or not. Cullen?
>> >
>> > 3. Terminology
>> >
>> >   PSN Tunnel Signaling: Used to set up, maintain, and tear down the
>> >   underlying PSN tunnel
>> >
>> > Spencer (Nit): s/Used/A protocol used/ (all of the other definitions
>> > look
>> > like complete sentences, this one is a fragment)
>> >
>> > 5.1 MPLS Pseudowire Setup & Signaling
>> >
>> >   This specification defines new PW type values to be carried within
>> >   the FEC object to identify HC PWs for each HC scheme.  The PW type is
>> >   a 15-bit parameter assigned by IANA, as specified in the [RFC4446]
>> >   registry, and MUST be used to indicate the HC scheme being used on
>> >   the PW.  The following PW type values have been set aside for
>> >   assignment by IANA:
>> >
>> >   0x001A  ROHC Transport Header-compressed Packets    [RFC3095]
>> >   0x001B  ECRTP Transport Header-compressed Packets   [RFC3545]
>> >   0x001C  IPHC Transport Header-compressed Packets    [RFC2507]
>> >   0x001D  cRTP Transport Header-compressed Packets    [RFC2508]
>> >
>> > Spencer: "have been set aside for assignment by IANA", with RFC
>> > references,
>> > confused me badly here. I read this text as saying that these values
>> > were
>> > set aside IN [RFC3095], etc, which was wrong. Perhaps "IANA is 
>> requested
>> > to
>> > assign the following new PW type values:"?
>> >
>> >   The PW control word enables distinguishing between various packets
>> >   types (e.g., uncompressed, UDP compressed, RTP compressed,
>> >   context-state, etc.).  However, the PW control word indications are
>> >   not unique across HC schemes, and therefore the PW type value allows
>> >   the HC scheme to be identified.
>> >
>> > 5.2 Header Compression Scheme Setup, Negotiation, & Signaling
>> >
>> >   Pseudowire Interface Parameter Sub-TLV type values are specified in
>> >   [RFC4446].  Two code-points have been reserved, as follows:
>> >
>> >   Parameter ID Length        Description                     References
>> >   0x0D      up to 256 bytes  ROHC over MPLS configuration    RFC 3241
>> >   0x0F      up to 256 bytes  CRTP/ECRTP/IPHC HC over MPLS    RFC 3544
>> >                              configuration
>> >
>> > Spencer: Again, something like "IANA is requested to assign these new
>> > code-points" would help me with what seems to be ambiguous text.
>> >
>> > 5.2.1 Configuration Option Format [RFC3544]
>> >
>> >   Both the network control protocol for IPv4, IPCP [RFC1332] and the
>> >   IPv6 NCP, IPV6CP [RFC2472] may be used to negotiate IP HC parameters
>> >   for their respective protocols.  The format of the configuration
>> >
>> > Spencer (Nit): I understand what you're saying with "their respective
>> > protocols", but I don't think what you're saying, and what I'm hearing,
>> > is
>> > actually what these words mean. Perhaps "their respective controlled
>> > protocols"? That would be unambiguous.
>> >
>> >   option is the same for both IPCP and IPV6CP.  This configuration
>> >   option MUST be included for ECRTP, CRTP and IPHC PW types and MUST
>> >   NOT be included for ROHC PW types.
>> >
>> > Spencer: Is it obvious what the decompressor does if it sees this
>> > configuration option for ROHC PW types? It may be - I'm just asking. 
>> I'd
>> > have the same question elsewhere (in 5.2.2, for example), but will only
>> > ask
>> > it here.
>> >
>> > 5.2.3 Enhanced RTP-Compression Suboption [RFC3544]
>> >
>> >   To use the enhanced RTP HC defined in [RFC3545], a
>> >   new sub-option 2 is added.  Sub-option 2 is negotiated instead of,
>> >   not in addition to, sub-option 1.  This suboption MUST be included
>> >
>> > Spencer: is it obvious what the decompressor does if it sees a
>> > compressor
>> > specifying sub-option 1 AND sub-option 2?
>> >
>> >   for ECRTP PWs (0x001B) and MUST NOT be included for other PW types.
>> >
>> >   MAX_HEADER
>> >
>> >      NOTE: The four ROHC profiles defined in RFC 3095 do not provide
>> >      for a MAX_HEADER parameter.  The parameter MAX_HEADER defined by
>> >      this document is therefore without consequence in these profiles.
>> >      Other profiles (e.g., ones based on RFC 2507) can make use of the
>> >      parameter by explicitly referencing it.
>> >
>> > Spencer: is there any statement you can make about the largest header
>> > that
>> > can be compressed in these profiles? Even if not, it might be good to
>> > say so
>> > explicitly - I don't know what "without consequence" says about what
>> > implementations may encounter in practice.
>> >
>> > 5.4 Packet Reordering
>> >
>> >   Packet reordering for ROHC is discussed in [RFC4224], which is a
>> >   useful source of information.  In case of lossy links and other
>> >   reasons for reordering, implementation adaptations are needed to
>> >   allow all the schemes to be used in this case.  Although CRTP is
>> >   viewed as having risks for a number PW environments due to reordering
>> >
>> > Spencer (Nit): "a number of PW environments" ("of" is missing)
>> >
>> >   and loss, it is still the protocol of choice in many cases.  In these
>> >   circumstances, it must be implemented and deployed with care.  IPHC
>> >   should use TCP_NODELTA, ECRTP should send absolute values, ROHC
>> >   should be adapted as discussed in [RFC4224].  An evaluation and
>> >   simulation of ECRTP and ROHC reordering is given in [REORDER-EVAL].
>> >
>> > Spencer (Probably a Nit): It wasn't obvious to me whether these
>> > recommendations are sufficient to "implement and deploy with care", or
>> > whether additional precautions must be taken. Even putting these
>> > recommendations in a numbered list immediately after "deployed with
>> > care"
>> > would be sufficient, if these recommendations are sufficient.
>> >
>> > 6. HC Pseudowire Setup Example
>> >
>> >   The Label Mapping message sent from R4/HD to R1/HC would be almost
>> >   identical to the one sent in the opposite direction, with the
>> >   following exceptions
>> >
>> > Spencer (Nit): missing a colon here...
>> >
>> >   As soon as either R1/HC or R4/HD had both transmitted and received
>> >   Label Mapping Messages with the same PW Type and PW ID, it could
>> >
>> > Spencer: "it" is not entirely clear here. "It" usually refers to one
>> > thing
>> > (in my mind), and the subject of the sentence is two things ("either
>> > R1/HC
>> > or R4/HD"). Mumble. Would it help to say that each ROHC endpoint
>> > considers
>> > the PW established when it has seen both packets?
>> >
>> >   consider the PW established.  R1/HC could send ECRTP packets using
>> >   the label it received in the Label Mapping Message from R4/HD, Lr4,
>> >   and could identify received ECRTP packets by the label it had sent to
>> >   R4/HD, Lr1.  And vice versa.
>> >
>> >   The following 3 RTP packets from this flow would be sent as
>> >
>> > Spencer: "following" is not entirely clear here. Suggest "next"?
>> >
>> >   COMPRESSED_UDP_8, to establish the absolute and delta values of the
>> >   IPv4 identifier and RTP timestamp fields.  These packets would use
>> >   the same ECRTP CID as the previous 3 FULL_HEADER packets.  The MPLS
>> >   and PW headers at the beginning of these packets would be formatted
>> >   as follows:
>> >
>> >
>> >
>> > _______________________________________________
>> > Ietf mailing list
>> > Ietf@ietf.org
>> > https://www1.ietf.org/mailman/listinfo/ietf
>> >
>>
>>
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www1.ietf.org/mailman/listinfo/gen-art

_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www1.ietf.org/mailman/listinfo/gen-art