Re: [Gen-art] Gen-ART Last Call review of draft-ietf-payload-flexible-fec-scheme-16
Varun Singh <varun@callstats.io> Mon, 04 February 2019 23:13 UTC
Return-Path: <varun@callstats.io>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4710D12426E for <gen-art@ietfa.amsl.com>; Mon, 4 Feb 2019 15:13:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=callstats.io
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nVpaN6gfMmpL for <gen-art@ietfa.amsl.com>; Mon, 4 Feb 2019 15:13:00 -0800 (PST)
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49E9F127598 for <gen-art@ietf.org>; Mon, 4 Feb 2019 15:13:00 -0800 (PST)
Received: by mail-wr1-x434.google.com with SMTP id a16so1765876wrv.0 for <gen-art@ietf.org>; Mon, 04 Feb 2019 15:13:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=callstats.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D0OV43zPki0/lxVrFJ484YYl0WPs97vYdsZFBVHeImg=; b=GeHo4Fz/kYcy3SINdHXfgjYfIj+w77WqRX1Iro6E64AhPR2Uyxne47gygcG+KEsejQ HIGOhecQolIGfZo5XXHemZ7lodcnUpVyY0YAbIrz3vT+27y/MKq0eWncMSoDSPoWMQMQ 78t6URa7d58+sB1P+rlS5uTajyZDk2gY0sItc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D0OV43zPki0/lxVrFJ484YYl0WPs97vYdsZFBVHeImg=; b=gsDTesX7GNajhs+PavyKbIXyRTv5MDAyQW4pBTvQ5tu9xRAc1tvQflB34md2LXnCrY yWcxyBlkGLTVY6eOYRDfcdPmJREebs9UssmRzsPhdy9byfr5OG9a5O/QUJrGFv08r1Ou X7JVPYhEbgYuLRvLF5QIZpjw7Pwyl+r+SVIk3OaeElvwH9dq7GUiGJ4Ir28w5eSCJKXf omMGHcJYK/Pg1i/XhUteA+spBqW5aj9SeHJEcOJR/tfNp0DFgZ6Jm3r1x9XGpWnB/Lzh SsZ+vFseeXy7lqGDEeYU7HuylWs00Y5pid+M+d5wWHbwdAyS4Te4PTKo6vSeazQJqzqc lioA==
X-Gm-Message-State: AHQUAuYSNhWYnoxDFRatIFM44uguLvOUcmCDDCQj49X+ABmVo21rU2oF 5TVcfEc7HFUOn1Ze4ZZ5KAYw3ST9hLTmQWR7PIPsHQ==
X-Google-Smtp-Source: AHgI3IbNKyMIMAV2cSI8Bq6cQRUny1CUymos1GQujgfqRFRKeOI5+p5LttrfFirk8fGI1pUu93PhpWt7vvqcGeEDlAU=
X-Received: by 2002:adf:ec50:: with SMTP id w16mr1264169wrn.171.1549321978340; Mon, 04 Feb 2019 15:12:58 -0800 (PST)
MIME-Version: 1.0
References: <BN8PR15MB2802BD6D363951E396F0961F9A920@BN8PR15MB2802.namprd15.prod.outlook.com> <0a8ee63d79c94929b6964df1b3c15e1b@NASANEXM01C.na.qualcomm.com>
In-Reply-To: <0a8ee63d79c94929b6964df1b3c15e1b@NASANEXM01C.na.qualcomm.com>
From: Varun Singh <varun@callstats.io>
Date: Mon, 04 Feb 2019 18:12:47 -0500
Message-ID: <CACHXSv5JFthqPwRVL38ybq_FimkaEw2wxv-MVQ_Bf6TmuQB2=Q@mail.gmail.com>
To: Giridhar Mandyam <mandyam@qti.qualcomm.com>
Cc: Meral Shirazipour <meral.shirazipour@ericsson.com>, "draft-ietf-payload-flexible-fec-scheme.all@ietf.org" <draft-ietf-payload-flexible-fec-scheme.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000298980058119a221"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/gJ26HkUCryQ5wUeUGl5p2x2HoN0>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-payload-flexible-fec-scheme-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 23:13:04 -0000
Hi Giri, Both post-repair loss metrics should be referenced, one provides run-length perpacket feedback and the other provides loss and repair counters. Webrtc-stats reports on the latter and can already be used to toggle FEC in webrtc applications. On Mon, 4 Feb 2019 at 0.34, Giridhar Mandyam <mandyam@qti.qualcomm.com> wrote: > >-Section 8, "an application should avoid sending/receiving FEC repair > streams if it knows that sending/receiving those FEC repair streams would > not help at all in recovering the missing packets. It is RECOMMENDED that > the amount and type (row, column, or both) of FEC protection is adjusted > dynamically based on the packet loss rate and burst loss length observed by > the applications." > > > > >How would the application know that sending/receiving those FEC repair > streams would not help at all? any rule of thumb to add here? > > > > The editors propose that the above text be revised as follows: > > > > “… an application should avoid sending/receiving FEC repair streams if it > knows that sending/receiving those FEC repair streams would not help at all > in recovering the missing packets. *Examples of where FEC would not be > beneficial are: (1) if the successful recovery rate as determined by RTCP > feedback is low (see RFC 5725), and (2) the application has a smaller > latency requirement than the repair window adopted by the FEC configuration > based on the expected burst loss duration and the target FEC overhead. *It > is RECOMMENDED that the amount and type (row, column, or both) of FEC > protection is adjusted dynamically based on the packet loss rate and burst > loss length observed by the applications." > > > > Please let us know if this is acceptable. > > > > Thanks, > > > > -Giri Mandyam > > > > *From:* Meral Shirazipour <meral.shirazipour@ericsson.com> > *Sent:* Thursday, January 31, 2019 11:50 PM > *To:* draft-ietf-payload-flexible-fec-scheme.all@ietf.org; > gen-art@ietf.org > *Subject:* Gen-ART Last Call review of > draft-ietf-payload-flexible-fec-scheme-16 > > > > *CAUTION*: This email originated from outside of the organization. > > I am the assigned Gen-ART reviewer for this draft. The General Area Review > Team (Gen-ART) reviews all IETF documents being processed by the IESG for > the IETF Chair. Please treat these comments just like any other last call > comments. > > > > For more information, please see the FAQ at < > https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > > > Document: draft-ietf-payload-flexible-fec-scheme-16 > > > > Reviewer: Meral Shirazipour > > Review Date: 2019-01-31 > > IETF LC End Date: 2019-02-01 > > IESG Telechat date: NA > > > > > > Summary: This draft is ready to be published as Standards Track RFC . > > Major issues: > > > > Minor issues: > > > > Nits/editorial comments: > > -Section 1.1.1 Title "One-Dimensionsal "--->"One-Dimensional" > > > > -[Page 14] 3.2. , "signficant"--->"significant" > > > > -[Page 16], 4.2.1. , "pakcets"--->"packets" > > > > -[Page 35], 6.3.1. , "reciever"--->"receiver" > > > > -[Page 35], 6.3.1.1. , "signficant"--->"significant" > > > > -[Page 43], 7., "several Sesssion "--->"several Session " > > > > -Section 8, "an application should avoid > > sending/receiving FEC repair streams if it knows that sending/ > > receiving those FEC repair streams would not help at all in > > recovering the missing packets. It is RECOMMENDED that the amount > > and type (row, column, or both) of FEC protection is adjusted > > dynamically based on the packet loss rate and burst loss length > > observed by the applications." > > > > How would the application know that sending/receiving those FEC repair > streams would not help at all? any rule of thumb to add here? > > > > > > Best Regards, > > Meral > > --- > > Meral Shirazipour > > Ericsson > > Research > > www.ericsson.com > -- Founder, CEO, callstats.io http://www.callstats.io Interested in networking, media quality, and diagnostics. We are hiring!: www.callstats.io/jobs/
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Meral Shirazipour
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Giridhar Mandyam
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Meral Shirazipour
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Varun Singh
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Giridhar Mandyam
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Meral Shirazipour