Re: [Gen-art] Genart last call review of draft-ietf-curdle-ssh-ext-info-10

Mirja Kühlewind <mirja.kuehlewind@tik.ee.ethz.ch> Mon, 04 September 2017 12:19 UTC

Return-Path: <mirja.kuehlewind@tik.ee.ethz.ch>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AA081124F57 for <gen-art@ietfa.amsl.com>; Mon, 4 Sep 2017 05:19:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ecEYZnMTq71B for <gen-art@ietfa.amsl.com>; Mon, 4 Sep 2017 05:19:38 -0700 (PDT)
Received: from virgo01.ee.ethz.ch (virgo01.ee.ethz.ch [129.132.2.226]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1895D124E15 for <gen-art@ietf.org>; Mon, 4 Sep 2017 05:19:38 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by virgo01.ee.ethz.ch (Postfix) with ESMTP id 3xm86c6PcSzMpMY; Mon, 4 Sep 2017 14:19:36 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at virgo01.ee.ethz.ch
Received: from virgo01.ee.ethz.ch ([127.0.0.1]) by localhost (virgo01.ee.ethz.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1vg7dPAN5r2D; Mon, 4 Sep 2017 14:19:31 +0200 (CEST)
X-MtScore: NO score=0
Received: from [192.168.178.33] (pD9E11141.dip0.t-ipconnect.de [217.225.17.65]) by virgo01.ee.ethz.ch (Postfix) with ESMTPSA; Mon, 4 Sep 2017 14:19:30 +0200 (CEST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
From: Mirja Kühlewind <mirja.kuehlewind@tik.ee.ethz.ch>
In-Reply-To: <150093015937.32021.12465797358778837950@ietfa.amsl.com>
Date: Mon, 04 Sep 2017 14:19:29 +0200
Cc: gen-art <gen-art@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1AB79C67-79FF-4EC8-95A3-06BE9CFF6929@tik.ee.ethz.ch>
References: <150093015937.32021.12465797358778837950@ietfa.amsl.com>
To: Matthew Miller <linuxwolf+ietf@outer-planes.net>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/gM8gbDNfei48KmfNoz77OpGlFMs>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-curdle-ssh-ext-info-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 12:19:41 -0000

Thanks for the review and follow up!

> Am 24.07.2017 um 23:02 schrieb Matthew Miller <linuxwolf+ietf@outer-planes.net>:
> 
> Reviewer: Matthew Miller
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-curdle-ssh-ext-info-10
> Reviewer: Matthew Miller
> Review Date: 2017-07-24
> IETF LC End Date: 2017-07-30
> IESG Telechat date: N/A
> 
> Summary:
> 
> This document is ready with an issue.
> 
> I found this document very coherent and easy to follow.
> 
> Major issues:
> 
> Minor issues:
> 
> My only issue borders on nit, but sided with nit as I can see it
> potentially causing confusion for an implementer in the future.
> 
> Section 2.5. "Interpretation of Extension Names and Values" explicitly
> states in the second paragraph a condition where the relative order of
> extension-names in an EXT_INFO message is irrelevant.  However, the rest
> of the section seems to imply to me that relative order is not important;
> so to explicitly call out a scenario seems to imply that relative order
> *is* relevant/important, sometimes.  If relative order is expected to be
> important most of the time, I think it helpful to explicitly state that
> and give a rationale for it.
> 
> Nits/editorial comments:
> 
> * RFC 5226 is referenced by this document, but is obsoleted by RFC 8126.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art