Re: [Gen-art] Gen-ART LC review of draft-kompella-l2vpn-l2vpn-07

"Roni Even" <ron.even.tlv@gmail.com> Fri, 13 January 2012 17:47 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CBE5B21F858D; Fri, 13 Jan 2012 09:47:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.599
X-Spam-Level:
X-Spam-Status: No, score=-3.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Bzg3ob42CaQ; Fri, 13 Jan 2012 09:47:16 -0800 (PST)
Received: from mail-ey0-f172.google.com (mail-ey0-f172.google.com [209.85.215.172]) by ietfa.amsl.com (Postfix) with ESMTP id 712E021F8587; Fri, 13 Jan 2012 09:47:15 -0800 (PST)
Received: by eaad11 with SMTP id d11so272237eaa.31 for <multiple recipients>; Fri, 13 Jan 2012 09:47:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:x-mailer :content-language:thread-index; bh=LVjowe5VkJkZVX3TRCNsx9FJJNT0KPBxiSzAuj88+Wo=; b=auRTPXRvj/Y7UuiLOZWsM/wmKFzdZPDfsLkLJWy2yCvnm0O6VK3yXPuhOzaZMo2FVN y70J6COucqf00lTjy1Z2Cx0vsvPrCp47Fxe6XidymTj5tnSqyZhuZIuMYHgPLDVlO4NY Qo6z3aXnCdFQ3jzLykyrtJq1xswZ6QVr9DH20=
Received: by 10.213.22.139 with SMTP id n11mr487578ebb.14.1326476834599; Fri, 13 Jan 2012 09:47:14 -0800 (PST)
Received: from windows8d787f9 (bzq-79-180-198-96.red.bezeqint.net. [79.180.198.96]) by mx.google.com with ESMTPS id e12sm32130743eea.5.2012.01.13.09.47.11 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Jan 2012 09:47:13 -0800 (PST)
From: Roni Even <ron.even.tlv@gmail.com>
To: 'Kireeti Kompella' <kireeti@juniper.net>
References: <4e6757ab.87c5e30a.061b.0446@mx.google.com> <CD8C388C-83B9-4E55-A9B7-0223782D1646@juniper.net> <4f0fdb33.c3630e0a.7550.fffff20b@mx.google.com> <3BE55A51-26E0-415F-90C5-AF1905A91237@juniper.net>
In-Reply-To: <3BE55A51-26E0-415F-90C5-AF1905A91237@juniper.net>
Date: Fri, 13 Jan 2012 19:43:43 +0200
Message-ID: <4f106e21.8c1b0e0a.7e1f.ffffe57a@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Content-language: en-us
Thread-Index: AczSGcWVZIGwNpfQRl2KXMDU0zFrGQAAP4Yg
Cc: draft-kompella-l2vpn-l2vpn.all@tools.ietf.org, gen-art@ietf.org, 'IETF-Discussion list' <ietf@ietf.org>
Subject: Re: [Gen-art] Gen-ART LC review of draft-kompella-l2vpn-l2vpn-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2012 17:47:16 -0000

Hi,
I am OK with minor issue 2 now. 
Issue 3  was my only point
Roni

> -----Original Message-----
> From: Kireeti Kompella [mailto:kireeti@juniper.net]
> Sent: Friday, January 13, 2012 7:36 PM
> To: Roni Even
> Cc: Kireeti Kompella; draft-kompella-l2vpn-l2vpn.all@tools.ietf.org;
> gen-art@ietf.org; IETF-Discussion list
> Subject: Re: Gen-ART LC review of draft-kompella-l2vpn-l2vpn-07
> 
> On Jan 12, 2012, at 23:16 , Roni Even wrote:
> 
> > Hi,
> > I looked at the 08 version and the major issues are addressed.
> > What about minor issue number 3?
> 
> Good point!  I will fix (as Stewart suggests, maybe just remove the
> reference).
> 
> To your minor issue (2), I've clarified the structure.  Do you still
> want to see how it fits into the NLRI?
> 
> Thanks,
> Kireeti.
> 
> > Roni Even
> >
> >> -----Original Message-----
> >> From: Kireeti Kompella [mailto:kireeti@juniper.net]
> >> Sent: Friday, September 16, 2011 10:23 PM
> >> To: Roni Even
> >> Cc: Kireeti Kompella; draft-kompella-l2vpn-l2vpn.all@tools.ietf.org;
> >> gen-art@ietf.org; IETF-Discussion list
> >> Subject: Re: Gen-ART LC review of draft-kompella-l2vpn-l2vpn-07
> >>
> >> Hi Roni,
> >>
> >> On Sep 7, 2011, at 4:37 , Roni Even wrote:
> >>
> >>> I am the assigned Gen-ART reviewer for this draft. For background
> on
> >> Gen-ART, please see the FAQ at
> >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> >>
> >> Thanks!
> >>
> >>> Please resolve these comments along with any other Last Call
> >>> comments
> >> you may receive.
> >>>
> >>> Document: draft-kompella-l2vpn-l2vpn-07
> >>> Reviewer: Roni Even
> >>> Review Date: 2011-9-7
> >>> IETF LC End Date: 2011-9-27
> >>> IESG Telechat date:
> >>>
> >>> Summary: This draft is not ready for publication as an
> informational
> >> RFC.
> >>>
> >>> Major issues:
> >>>
> >>> The IANA considerations section says:
> >>> "the values  already allocated are in Table 1 of Section 4.  The
> >> allocation policy  for new entries up to and including value 127 is
> >> "Standards Action".  The allocation policy for values 128 through
> 251
> >> is "First Come First Served".  The values from 252 through 255 are
> >> for "Experimental Use"."
> >>
> >> Standards Action will be changed to Expert Review.
> >>
> >>> Yet this is document is intended for Informational status which
> >> contradict the standard action. This is also true for the second
> >> registry defined.
> >>>
> >>> Is this document really an Informational one?
> >>
> >> My only comment is that it is not Historic.
> >>
> >>> Minor issues:
> >>>
> >>> 1.       In section  1.2.2 "Since "traditional" Layer 2 VPNs (i.e.,
> >> real Frame Relay circuits connecting sites) are indistinguishable
> >> from tunnel-based VPNs from  the customer's point-of-view, migrating
> >> from one to the other raises  few issues." What are the few issues?
> >>
> >> A subtlety: "few issues" means not many, not deep; it's a careful
> way
> >> of saying, "just about no issues".  "A few issues" would require
> >> elaboration.
> >>
> >>> 2.       In section 4 "L2VPN TLVs can be added to extend the
> >> information carried in the NLRI, using the format shown in Figure
> 2".
> >> How is the TLV carried in the NLRI, in which field, section 4.1 only
> >> talk about the structure of the TLV.
> >>
> >> I'll take the figure from 3.2.2 of RFC 4761 and show where the TLVs
> go.
> >>
> >>> 3.       Section 4.2 refers to section 4 but I am not sure where
> this
> >> mechanism in section 4 is.
> >>
> >> Will clarify.
> >>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> Nits/editorial comments:
> >>>
> >>> 1.       Section 3.1 is called network topology but the whole text
> is
> >> an example of a network topology. Maybe the title should be "Example
> >> of a network toplogy".
> >>
> >> Sure.
> >>
> >>> 2.       Section 5 starts with "As defined so far in the document
> .."
> >> But the using IP only is already discussed in previous sections.
> >>
> >> Do you have a suggestion for rewording?
> >>
> >> Thanks,
> >> Kireeti.
> >>
> >>
> >>>
> >>>
> >>> <ATT00001..txt>
> >