IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-sidrops-cms-signing-time-06

Job Snijders <job@fastly.com> Fri, 08 March 2024 01:22 UTC

Return-Path: <job@fastly.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F737C14F5F4 for <gen-art@ietfa.amsl.com>; Thu, 7 Mar 2024 17:22:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.104
X-Spam-Level:
X-Spam-Status: No, score=-7.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kH0q7KisqPIK for <gen-art@ietfa.amsl.com>; Thu, 7 Mar 2024 17:22:35 -0800 (PST)
Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A247DC14F6EC for <gen-art@ietf.org>; Thu, 7 Mar 2024 17:22:35 -0800 (PST)
Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-56454c695e6so2797451a12.0 for <gen-art@ietf.org>; Thu, 07 Mar 2024 17:22:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1709860954; x=1710465754; darn=ietf.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cRECv58qVPXjhL7ZyvPCJyPmUYy+Jic49CBnQ9QJNDE=; b=WPFlbDTCLWJFCImHo9Xh7EDTv+h5YuRYdS8ZGBYwbiV4ua2wAcsT+NppLAflbOMBCb hBMMdMUswMhayTYyc12MYNacIrps4MLtZSvCM9yYFpiuP2kK2PAXbStuCBxpg4oXeYY7 LXMAuNbh3dMRVRG9LSSZr/OimRRG+GMWNiPkk=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709860954; x=1710465754; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cRECv58qVPXjhL7ZyvPCJyPmUYy+Jic49CBnQ9QJNDE=; b=Y0kC4lH9vH5b6F5JpX7pki7LrOMKOyuGmHGpN6Xry/hkwvCQxooU5LwkKpUpZYTyWr UX1nDp9dPtHkBC4oF+M5h/h4x5MqX5SuRN8dCRng9bxR8B8YUayH09K2zS587QxA3SFF Yg4hFnn8qVR/rJ/HmQvdXiZMuEwctc7orj/bWt1Mv6o/nonfD3aH5tLPAywq99WiiUfj AR0DvuCFCstiy6H8RyUqFqMu77PRbC3gdTenfoFY7YxVJaoErp7DqLOMj4jJEBPDMq0s ldYIJMq+9V+hsPH7xtWJxGpKecEc1VKOtDPk6xaOWe3uggj5HIh6mnawF+VrVWjGAM1Q 0bUQ==
X-Gm-Message-State: AOJu0Yxg8i199PNKDed+cT66yGdwRpBI5AUnej0ELCQVy3a6wP6GJmS0 n35K6hUoAyQ0l+/ORfppeQXDmZirllxOByVXST8bpzqDiuqJpPRV4DcLIXzufYY=
X-Google-Smtp-Source: AGHT+IGrxVfOCgid3Wnm+zfRQ2bMTQU1LLfpgk4Nh7MOT2ThZ0H7foEbzxOvuTV+f6VEhbG/XzfRxg==
X-Received: by 2002:a50:9353:0:b0:566:59a2:7a10 with SMTP id n19-20020a509353000000b0056659a27a10mr1276682eda.1.1709860953729; Thu, 07 Mar 2024 17:22:33 -0800 (PST)
Received: from snel ([2a10:3781:276:3:16f6:d8ff:fe47:2eb7]) by smtp.gmail.com with ESMTPSA id c21-20020aa7df15000000b005682dfd9182sm20613edy.61.2024.03.07.17.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 17:22:32 -0800 (PST)
Date: Fri, 08 Mar 2024 02:22:31 +0100
From: Job Snijders <job@fastly.com>
To: Gyan Mishra <hayabusagsm@gmail.com>
Cc: gen-art@ietf.org, draft-ietf-sidrops-cms-signing-time.all@ietf.org, last-call@ietf.org, sidrops@ietf.org
Message-ID: <ZepoV6kSCt5nJV-Z@snel>
References: <170985987812.47428.13412522670940084191@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <170985987812.47428.13412522670940084191@ietfa.amsl.com>
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/irmAwS0ZFOSQ-jt4r0xO-x6_N-Y>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-sidrops-cms-signing-time-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Mar 2024 01:22:39 -0000

Hi Gyan,

Thanks for taking the time to review this document.

On Thu, Mar 07, 2024 at 05:04:38PM -0800, Gyan Mishra via Datatracker wrote:
> Major issues:
> None
> 
> Minor issues:
> None
> Nits/editorial comments:
> In section 2.2 talks about file comparison and says
> 
> Old
> 
> If a file is found in DIR that is identical to the sender's file, the file will
> NOT be transferred to the destination directory.
> 
> New
> 
> If a file is found in DIR that has the identical size to the sender's file, the
> file will NOT be transferred to the destination directory.

Your suggested change relates to text that is quoted verbatim from an
external source, the rsync manual, so changing the wording in this
document probably is not desirable.

Kind regards,

Job

v2.23.0 | Report a Bug | By Email