[Gen-art] GenART review of draft-schaad-pkix-rfc2875-bis-03

Martin Thomson <martin.thomson@gmail.com> Fri, 07 December 2012 01:02 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AA5F21F85D3 for <gen-art@ietfa.amsl.com>; Thu, 6 Dec 2012 17:02:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.984
X-Spam-Level:
X-Spam-Status: No, score=-4.984 tagged_above=-999 required=5 tests=[AWL=-1.385, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qBtq-RSAWCag for <gen-art@ietfa.amsl.com>; Thu, 6 Dec 2012 17:02:52 -0800 (PST)
Received: from mail-la0-f44.google.com (mail-la0-f44.google.com [209.85.215.44]) by ietfa.amsl.com (Postfix) with ESMTP id 927E021F8587 for <gen-art@ietf.org>; Thu, 6 Dec 2012 17:02:51 -0800 (PST)
Received: by mail-la0-f44.google.com with SMTP id d3so5946760lah.31 for <gen-art@ietf.org>; Thu, 06 Dec 2012 17:02:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Tj4ccNi6GkO0Lm1AZy5qusloOiJmAv3vMXGb02eAaFo=; b=WvXzHCSF4fLFuJOnIeYBVZgBFlkfGJd9TCauqFfmNf2LjOjgAt0h6S4M9h1Oh2R084 ry6Nxy7Bm6dgtIY7IqEUs3TkDqk9Wbq7e4icnxRnH4DXhdpMh7X4+5pQs1PtwlggrrCC GO7+w9TFp29VSlUf+04/FDA/oFUGS5fpCRf+FpZZeHb2y1lFtt+7V8G5yb45qBmjbqnc CT+DzwaeOKO/XWNWfa/nMrhEJtRsKygtdVchrufwb/s4suLzhGRg4t3jnQTKp5A8Yyiq luLSxIo72wMZa8p6mRRnTpqM/bDJHCIw2MIUFyW2tqOGe8i/VknE6q5K1PFpXV3bicEv 1egA==
MIME-Version: 1.0
Received: by 10.112.44.164 with SMTP id f4mr1755806lbm.111.1354842170462; Thu, 06 Dec 2012 17:02:50 -0800 (PST)
Received: by 10.112.98.200 with HTTP; Thu, 6 Dec 2012 17:02:50 -0800 (PST)
Date: Thu, 06 Dec 2012 17:02:50 -0800
Message-ID: <CABkgnnW_bUGEQSeupWSmw5d8gT-jWDreCptihhvemzGU6pzuWw@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>, draft-schaad-pkix-rfc2875-bis.all@tools.ietf.org
Content-Type: text/plain; charset="UTF-8"
Subject: [Gen-art] GenART review of draft-schaad-pkix-rfc2875-bis-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2012 01:02:52 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments
you may receive.

Document: raft-schaad-pkix-rfc2875-bis-03
Reviewer: Martin Thomson
Review Date: 2012-12-06
IETF LC End Date: Aaaages
IESG Telechat date: (if known)

Summary: Looks good to me.  Ship it.

Nits/editorial comments:

Section 3 does not establish a notation convention for multiplication.
 I didn't find a specific place that this was a problem, but it seemed
appropriate since multiplications was, in some places denoted 'n*b'
and others as 'xy', even though multi-character identifiers are used
in many places.  This does imply that a precedence override is
necessary.  I suggest parentheses, since they are already used
extensively.

Section 3: s/MAC funtion/MAC functions/

Section 5: could use a more rigorous list construction, the
definitions all run together

Needs more ASN.1

--Martin