IETF Logo Mail Archive

Re: [Gen-art] Genart telechat review of draft-murchison-tzdist-tzif-15

Alissa Cooper <alissa@cooperw.in> Thu, 25 October 2018 07:37 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AE4F130DDC; Thu, 25 Oct 2018 00:37:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=sfJ1ctup; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=QybbuvvI
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dAR7pJpQ-OxT; Thu, 25 Oct 2018 00:37:50 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6124A130E31; Thu, 25 Oct 2018 00:37:50 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2BF1C22077; Thu, 25 Oct 2018 03:37:49 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 25 Oct 2018 03:37:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=B MirlqIfjbeV2xlpwCyM/rWBl7AngW6ZI0waaGtW4Eg=; b=sfJ1ctupsBIf+vQgd w/ctbFmgqZt0wW5M3qF4yS+2TRSxY3f26pk/zXn4bnY5EfD4yJWflbsoxwX0WZwj Xm/mZ6RnLNXg4yKzVwZhqnwc+1BdJwHgVTjiqvFpEXYDt8eHDXbQbzXSs9ZJwbT1 rIcnZ+LLb8PSOr7CbxkhSsmSdjtfNAZnNd7IOfIqrlKt1S5uTvBeP4/Pe2ifNV9J 1Nkz7A76+CmpIRRiY8VmBkT71pB9BkPOSoOHZkNISyMUEHtTRQKROUXy4IwMDKGU JpAeb7YEmizT0lYNJ/z1+1Z0JuL0N4DjEmqwXT8mGDKX/gJfdS0j9X/yQv+fYG1+ tiliw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BMirlqIfjbeV2xlpwCyM/rWBl7AngW6ZI0waaGtW4 Eg=; b=QybbuvvI6Y1qIRkCHqLU4Tym5Q+5rncJwyubB6E2+B7HtGhTfi2D7zc2L n0lvuUpMT1IXkg/nVliWlG0UBp0gc+ecnfLuQGzagVOL+p15IGaNjlUf26HCx/TC jsEH7TvgqBcZm4Il5ZCnM/7xhfO6oC63SnEu0WL8V4JVaWy4/QssrbaeRh+oc9C7 znNq/VFIGekRXG6PuAAp2SgPkSU1JVg+ptbB+I1QFfSDmVwZWesLtzEwrtHSrKA6 Kw9PcWPleykNOY1qgC94XazdIf0bPMGSysQAIJwAwpm/b8RjD0IbiBkrbw3WbvVt pBYTL4DyCf34jnBMqs9D2a02eOE4w==
X-ME-Sender: <xms:zHLRWwpGaKXcRH6xbpK_9aIoVFXs0d0M2jptZN33vgtTM0IXBCrSSw>
X-ME-Proxy: <xmx:zHLRW3Z0UxWAV5JPpsLnGI_bChP6a0HT11pf6Ub1HURKQbvrENhaQQ> <xmx:zHLRWx2sO7_NtHYtLYtw_pMOkH-n0rrJCHDN-xH8ZdgqHPGynHDERA> <xmx:zHLRW4p8tymMEozTutPz8WYFTZTs-R1SII1vk50lUBpIqUQt9CaHAA> <xmx:zHLRW6wx3nA_cBEIbS6lUklNpxe43gfU9wA5E58S2gS8gv2bneF_mA> <xmx:zHLRW5D6FcpSI4vxzp-2hOp0sgjZhm9mJkBOWvZ2LC_5VHpSgUKWhA> <xmx:zXLRW2gif6qmovdpfuBG3QGVDl92Pmybo36mXj3qzeLh8A3zTqfxug>
Received: from [10.82.174.167] (unknown [173.38.117.79]) by mail.messagingengine.com (Postfix) with ESMTPA id D1E08102EE; Thu, 25 Oct 2018 03:37:47 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <154043928215.6951.9240302929574732976@ietfa.amsl.com>
Date: Thu, 25 Oct 2018 09:37:45 +0200
Cc: General Area Review Team <gen-art@ietf.org>, draft-murchison-tzdist-tzif.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <68B16CB8-E6A2-4AA3-9AC9-A93411EE1478@cooperw.in>
References: <154043928215.6951.9240302929574732976@ietfa.amsl.com>
To: Dale Worley <worley@ariadne.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/pLZDNiaeXz31w5csEuU0AOQAJes>
Subject: Re: [Gen-art] Genart telechat review of draft-murchison-tzdist-tzif-15
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 07:37:52 -0000

Dale, thanks for your review. Paul, Eliot, thanks for your responses. I entered a No Objection ballot.

Alissa

> On Oct 25, 2018, at 5:48 AM, Dale Worley <worley@ariadne.com> wrote:
> 
> Reviewer: Dale Worley
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document:  draft-murchison-tzdist-tzif-15
> Reviewer:  Dale R. Worley
> Review Date:  2018-10-24
> IETF LC End Date:  2018-10-09
> IESG Telechat date:  2018-10-25
> 
> Summary:
>       This draft is basically ready for publication, but has nits
>       that should be fixed before publication.
> 
> There are two remaining nits:
> 
> 
> The semantics of the various data items -- what they mean and how they
> are to be used in processing -- is only hinted at.  I suspect that the
> draft is targeted at members of the community who already thoroughly
> understand the semantics of the data items (based on their names), but
> this is not stated.  There is a reference:
> 
>   see "Sources for Time
>   Zone and Daylight Saving Time Data" [tz-link] for more-detailed
>   information about civil timekeeping data and practice
> 
> but it does not positively assert that [tz-link] provides the
> specification of the data items in TZif.
> 
> It's very likely that this is Not A Problem within the community that
> would use this specification, but that needs to be positively
> ascertained, as there is no definitive statement in the draft itself.
> 
> 
> 3.2.  TZif Data Block
> 
>   time zone designations:  A series of octets constituting an array of
>      NUL-terminated (0x00) time zone designation strings.  [...]
>      The character encoding of time zone designation
>      strings is not specified; however, see Section 4 of this document.
> 
> I think this should be expanded to "The character encoding of time
> zone designation strings is not specified, other than that encoded
> characters MUST NOT contain a NUL (0x00) octet.  However, see Section
> 4 of this document."  This is because some important multi-octet
> encodings generate NUL octets, and while the TZif format does not fix
> the encoding, certain encodings (o rather certain encoded characters)
> MUST be forbidden.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.28.0 | Report a Bug | By Email | System Status