[Gen-art] Gen-ART Telechat review of draft-ietf-sip-ipv6-abnf-fix-05

Suresh Krishnan <suresh.krishnan@ericsson.com> Tue, 18 May 2010 05:49 UTC

Return-Path: <suresh.krishnan@ericsson.com>
X-Original-To: gen-art@core3.amsl.com
Delivered-To: gen-art@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id BC6343A6BFF for <gen-art@core3.amsl.com>; Mon, 17 May 2010 22:49:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.508
X-Spam-Level:
X-Spam-Status: No, score=-2.508 tagged_above=-999 required=5 tests=[AWL=-1.398, BAYES_05=-1.11]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WAZb-SZm9TPX for <gen-art@core3.amsl.com>; Mon, 17 May 2010 22:49:10 -0700 (PDT)
Received: from imr3.ericy.com (imr3.ericy.com [198.24.6.13]) by core3.amsl.com (Postfix) with ESMTP id B2D9A3A67EC for <gen-art@ietf.org>; Mon, 17 May 2010 22:48:37 -0700 (PDT)
Received: from eusaamw0712.eamcs.ericsson.se ([147.117.20.181]) by imr3.ericy.com (8.13.8/8.13.8) with ESMTP id o4I5mOqk016052 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 18 May 2010 00:48:25 -0500
Received: from [142.133.10.113] (147.117.20.212) by eusaamw0712.eamcs.ericsson.se (147.117.20.182) with Microsoft SMTP Server id 8.2.234.1; Tue, 18 May 2010 01:48:24 -0400
Message-ID: <4BF229C8.9090907@ericsson.com>
Date: Tue, 18 May 2010 01:46:48 -0400
From: Suresh Krishnan <suresh.krishnan@ericsson.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100411)
MIME-Version: 1.0
To: draft-ietf-sip-ipv6-abnf-fix.all@tools.ietf.org, General Area Review Team <gen-art@ietf.org>
Content-Type: text/plain; charset="iso-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Subject: [Gen-art] Gen-ART Telechat review of draft-ietf-sip-ipv6-abnf-fix-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 May 2010 05:49:12 -0000

I have been selected as the General Area Review Team (Gen-ART)
reviewer for this draft (for background on Gen-ART, please see
http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).

Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-sip-ipv6-abnf-fix-05
Reviewer: Suresh Krishnan
Review Date: 2010/05/17
IESG Telechat date: 2010/05/20

Summary: This document is ready for publication as a Proposed Standard.
I do have one comment that you may like to address.

Minor
=====
* The draft also fixes the ABNF for IPv4 addresses i.e. the 
<IPv4address> rule but is silent about why it is doing so. I think I 
understand why it is being fixed but I would like the authors to clarify.

The old rule read

IPv4address    =  1*3DIGIT "." 1*3DIGIT "." 1*3DIGIT "." 1*3DIGIT

and the new rule reads

IPv4address   = dec-octet "." dec-octet "." dec-octet "." dec-octet \ 
  dec-octet     = DIGIT                 ; 0-9
                    / %x31-39 DIGIT         ; 10-99
                    / "1" 2DIGIT            ; 100-199
                    / "2" %x30-34 DIGIT     ; 200-249
                    / "25" %x30-35          ; 250-255

It would be nice if you can some explanatory text in Section 2. 
Something like

"The <IPv4address> rule in RFC3261 allowed invalid IPv4 addresses to be 
specified and still be compliant to the ABNF. (e.g. An URI such as 
sip:bob@444.555.666.777:88 would still be considered valid.) The 
resolution for this error is simply to use the correct ABNF for the 
<IPv4address> production rule from Appendix A of RFC3986 [3]."

Thanks
Suresh