[Gen-art] review of draft-ietf-ccamp-general-constraint-encode-16.txt
Francis Dupont <Francis.Dupont@fdupont.fr> Wed, 14 January 2015 16:14 UTC
Return-Path: <Francis.Dupont@fdupont.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1C5E1A8991 for <gen-art@ietfa.amsl.com>; Wed, 14 Jan 2015 08:14:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.562
X-Spam-Level:
X-Spam-Status: No, score=-3.562 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, GB_I_LETTER=-2, HELO_EQ_FR=0.35, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qYqHZb1_-0Bf for <gen-art@ietfa.amsl.com>; Wed, 14 Jan 2015 08:14:19 -0800 (PST)
Received: from givry.fdupont.fr (givry.fdupont.fr [IPv6:2001:41d0:1:6d55:211:5bff:fe98:d51e]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05C581A8AF8 for <gen-art@ietf.org>; Wed, 14 Jan 2015 08:14:18 -0800 (PST)
Received: from givry.fdupont.fr (localhost [127.0.0.1]) by givry.fdupont.fr (8.14.3/8.14.3) with ESMTP id t0EGCVHZ058158; Wed, 14 Jan 2015 17:12:31 +0100 (CET) (envelope-from dupont@givry.fdupont.fr)
Message-Id: <201501141612.t0EGCVHZ058158@givry.fdupont.fr>
From: Francis Dupont <Francis.Dupont@fdupont.fr>
To: gen-art@ietf.org
Date: Wed, 14 Jan 2015 17:12:31 +0100
Sender: Francis.Dupont@fdupont.fr
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/tdqvRJ3ZoOak_ta74xHOX8PtjJc>
Cc: draft-ietf-ccamp-general-constraint-encode.all@tools.ietf.org
Subject: [Gen-art] review of draft-ietf-ccamp-general-constraint-encode-16.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jan 2015 16:14:21 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-ccamp-general-constraint-encode-16.txt Reviewer: Francis Dupont Review Date: 20150107 IETF LC End Date: 20150117 IESG Telechat date: unknown Summary: Ready Major issues: None Minor issues: None Nits/editorial comments: - you use a strange indentation for sub sections... Perhaps it is from the tempate?? Anyway it will be handled/fixed by the RFC Editor. - 2 page 6: 1 -- the device is switched(e.g., ROADM/OXC) ^ add a space here - 2.2 page 7: OxFF -> 0xff (letter O -> digit 0) - 2.2 page 8: RestrictType -> RestrictionType - 2.3 page 11: 0x01(Inclusive Range) ^ add a space here - 2.3 page 11: I can't understand the unnumbered in this statement: "... Note that the Action field can be set to 0x01 (Inclusive Range) only when unnumbered link identifier is used." - 2.6.1 page 16: I suggest: Num Labels -> Num Labels = N in the schema - 2.6.2 page 16: I suggest: Num Labels -> Num Labels = 2 in the schema - 2.6.3 page 17: missing parenthesis: "positions (Num Labels) and beyond SHOULD be set to zero" ^ add ) here? - 6 page 28: I don't fully understand why RFC 5307 is an informative reference and RFC 4203 (same with OSPF in place of IS-IS) is a normative one. - pages 31 and 32: perhaps another side-effect from the template: inusual (for a draft) IP statement & co... Thanks Francis.Dupont@fdupont.fr
- [Gen-art] review of draft-ietf-ccamp-general-cons… Francis Dupont
- Re: [Gen-art] review of draft-ietf-ccamp-general-… Leeyoung
- Re: [Gen-art] review of draft-ietf-ccamp-general-… Francis Dupont
- Re: [Gen-art] review of draft-ietf-ccamp-general-… Leeyoung
- Re: [Gen-art] review of draft-ietf-ccamp-general-… Jari Arkko
- Re: [Gen-art] review of draft-ietf-ccamp-general-… Leeyoung