Re: [Gen-art] Review: draft-ietf-ipsecme-ddos-protection-09

Jari Arkko <jari.arkko@piuha.net> Tue, 27 September 2016 14:47 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70C2A12B209; Tue, 27 Sep 2016 07:47:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.216
X-Spam-Level:
X-Spam-Status: No, score=-4.216 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-2.316] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pR58VL2LjWpc; Tue, 27 Sep 2016 07:47:53 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id E5B0612B233; Tue, 27 Sep 2016 07:38:40 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 1EC172CC9B; Tue, 27 Sep 2016 17:38:40 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Si8nYFBi7_-m; Tue, 27 Sep 2016 17:38:39 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 7244C2CC40; Tue, 27 Sep 2016 17:38:39 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_EBC4007F-40DD-4C5A-AB53-EFF22856C9F2"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <2691CE0099834E4A9C5044EEC662BB9D572DA459@dfweml501-mbb>
Date: Tue, 27 Sep 2016 17:38:39 +0300
Message-Id: <64B5C794-127F-44F7-87BC-E24F07349452@piuha.net>
References: <2691CE0099834E4A9C5044EEC662BB9D572DA459@dfweml501-mbb>
To: Lucy yong <lucy.yong@huawei.com>, draft-ietf-ipsecme-ddos-protection@ietf.org
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/ttSvAFeXEXo3sKE-OTG7AZPaprs>
Cc: General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Review: draft-ietf-ipsecme-ddos-protection-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2016 14:47:54 -0000

Many thanks for the review, Lucy!

Authors, do take note of the comments.

Jari

On 24 Sep 2016, at 00:28, Lucy yong <lucy.yong@huawei.com> wrote:

> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ipsecme-ddos-protection-09
>      Multi-Path Time Synchronization
> Reviewer: Lucy Yong
> Review Date: 23-Sept-2016
> IETF LC End Date: 28-Sept-2016
> IESG Telechat date: 29-Sept-2016
> 
> Summary: This document is nearly ready for publication as a standard track RFC. Some minor comments. Some nits need to be corrected.
> 
> PS: comment for IESG. The document specifies puzzles approach and related protocol to boost the difficulty for DDoS attacks. The protocol description is simple and short; however it spends many pages (section 7) to describe the processes at the Initiator and the Responder. Maybe in future IETF can consider accepting protocol software code in a RFC. This will be easier for author and no need for programmers to read the description and program it (sure they will not come out the same program logic).
> 
> Major issues: N/A
> 
> Minor issues:
> 
> Section 1: 2nd paragraph, bot-nets,
> Comment: what is the bot-nets?
> 
> Section 7.1.1.2, 1st paragraph
> Comment: “that must be used”, should it be “that MUST be used” or “that is used”?
> 
> 
> Nits/editorial comments:
> 
> Section 6:
> 
> s/the puzzle difficulty should/the puzzle difficulty SHOULD/
> 
> s/This will This will/This will/
> 
> Section 7.1
> 
> s/the IKE Responder should/the IKE Responder SHOULD/
> s/that puzzles/puzzles/
> 
> Section 7.1.1.1
> s/next to/nearly/
> s/the level should/the level SHOULD/
> 
> Section 7.1.1.2
> s/([RFC7696])/[RFC7696]/
> s/with another, and negotiate/with another and negotiate/
> s/an SA payload, containing/an SA payload containing/
> s/this type must/this type MUST/
> 
> Section 7.1.1.3
> s/should/SHOULD/ (3 places)
> s/blob/block/
> s/may continue to generate/MAY continually generate/
> 
> Section 7.1.3
> s/the solution to the puzzle contain/the puzzle solution contains/
> s/i.e./i.e.,/ (2 places)
> 
> Section 7.1.4
> s/must/MUST/ (2 places)
> 
> Section 7.2
> s/The Responder should/The Responder SHOULD/
> 
> Section 7.2.2
> s/message, containing/message containing/
> 
> Section 7.2.4
> s/operations i.e.  computing/operations, i.e., computing/
> 
> Section 8.1
> s/PRF must/PRF MUST/
> 
> Section 9
> s/Initiators should/Initiators SHOULD/
> 
> Section 10
> s/Care must/Care MUST/
> 
> 
> 
> 
> 
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art