Re: [Gen-art] Gen-ART LC review of draft-ietf-kitten-sasl-openid-06.txt

Eliot Lear <lear@cisco.com> Fri, 04 November 2011 10:28 UTC

Return-Path: <lear@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2AD4D21F8B1A for <gen-art@ietfa.amsl.com>; Fri, 4 Nov 2011 03:28:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -108.264
X-Spam-Level:
X-Spam-Status: No, score=-108.264 tagged_above=-999 required=5 tests=[AWL=-1.665, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TGFX75t2JHnz for <gen-art@ietfa.amsl.com>; Fri, 4 Nov 2011 03:28:07 -0700 (PDT)
Received: from ams-iport-4.cisco.com (ams-iport-4.cisco.com [144.254.224.147]) by ietfa.amsl.com (Postfix) with ESMTP id 1401E21F8B17 for <gen-art@ietf.org>; Fri, 4 Nov 2011 03:28:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=lear@cisco.com; l=2873; q=dns/txt; s=iport; t=1320402487; x=1321612087; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=QEXfgs+hD/VhvRaFzJPCn/FnkjcKOVZZKU5RhqGeuOI=; b=S27/5g4JhSH4bHb1PrzNL7XhJCYLroJ6XcM50AwM+pqWAnxxetsDkbiz YsZr81XivErmj4MlsYXied5W/9b2d/Vj8zMPbv5hgji47VtEhbkd6Ugzb UCzDAkJNVEUuEe7ux7EpiQzsFQlOm8FFMK/Qe0zOsokMVC3NwQVBa3qou k=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AgAFABW9s06Q/khN/2dsb2JhbABDhHqlEYEFgXIBAQEDARIBEFUBBQsLGAICBRYLAgIJAwIBAgFFBg0BBwEBFweHYJY+AYxLkg6BMIZlgRYElByRZw
X-IronPort-AV: E=Sophos;i="4.69,455,1315180800"; d="scan'208";a="2412456"
Received: from ams-core-4.cisco.com ([144.254.72.77]) by ams-iport-4.cisco.com with ESMTP; 04 Nov 2011 10:28:06 +0000
Received: from dhcp-144-254-50-78.cisco.com (dhcp-144-254-50-78.cisco.com [144.254.50.78]) by ams-core-4.cisco.com (8.14.3/8.14.3) with ESMTP id pA4AS54q017456; Fri, 4 Nov 2011 10:28:05 GMT
Message-ID: <4EB3BE36.9080409@cisco.com>
Date: Fri, 04 Nov 2011 11:28:06 +0100
From: Eliot Lear <lear@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: Brian E Carpenter <brian.e.carpenter@gmail.com>
References: <4E9B87D1.9040706@gmail.com>
In-Reply-To: <4E9B87D1.9040706@gmail.com>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-kitten-sasl-openid.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART LC review of draft-ietf-kitten-sasl-openid-06.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Nov 2011 10:28:08 -0000

Hi Brian,

Apologies for the belated review.  Please see comments below.

On 7/22/64 8:33 PM, Brian E Carpenter wrote:
> Please see attached review.

>
> "some sort of..."   "any number of ways" This is very loose language
> for a standards-track draft. I don't know what to suggest but it
> just seems too vague as it is. If all you can actually specify is
> a transport mechanism, then shouldn't the specification avoid hand-waving
> on other matters?

The issue is that OpenID was designed where you could serialize with
cookies.  You can't do that with a non-browser app in the middle. 
Still, the matter is internal to the RP.  There is no need for the
information to be interpreted by other parties, and as such we ought not
specify its form.  If you would like I can add some text around this
since it seems to be a point of confusion.

 
> > 2.2.  Discussion
> >
> >    As mentioned above OpenID is primarily designed to interact with web-
> >    based applications.  Portions of the authentication stream are only
> >    defined in the crudest sense.  That is, when one is prompted to
> >    approve or disapprove an authentication, anything that one might find
> >    on a browser is allowed, including JavaScript, fancy style-sheets,
> >    etc.  Because of this lack of structure, implementations will need to
> >    invoke a fairly rich browser in order to ensure that the
> >    authentication can be completed.
>
> Errm what? "Fairly rich" is a useless statement from a specification PoV.
> And in any case, Section 2 is "Applicability for non-HTTP Use Cases",
> so I don't understand what JS, style-sheets or browsers have to do
> with it.

The whole point of this mechanism is for non-browser apps to leverage
browsers for their authentication.  Note that you are quoting
"discussion", and that any implementer would understand the context of
what that means (especially given the previous sentence).


> The second sentence seems to be missing a noun after "astute". But more
> profoundly, this paragraph really isn't OK for a technical specification.
> It mixes up a vague explanation of server behaviour with an imprecise
> discussion of a solution not adopted. Could the paragraph be rewritten
> in a style that will help an implementor write code? Is it saying that
> on receipt of an "=" response the server should continue to wait?

We fixed the nit.  However, your profound comment is directed at
"Discussion".  A precise normative specification  as well as an example
follows below the above text.

> Why is kitten-sasl-openid
> on the standards track when it depends on a document that clearly
> could have
> been proposed as standards track but wasn't?

No attempt is made here to "back door" standardize OpenID, but rather to
simply make it available to SASL applications.

Eliot