[Gen-art] Genart last call review of draft-ietf-lisp-vendor-lcaf-09

Christer Holmberg via Datatracker <noreply@ietf.org> Mon, 11 April 2022 20:35 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 2DE833A182B; Mon, 11 Apr 2022 13:35:34 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-lisp-vendor-lcaf.all@ietf.org, last-call@ietf.org, lisp@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.46.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164970933406.11609.7107781510824246342@ietfa.amsl.com>
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Mon, 11 Apr 2022 13:35:34 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/w8r32njasR5PwAa8-Y4Fv0dHw1s>
Subject: [Gen-art] Genart last call review of draft-ietf-lisp-vendor-lcaf-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Apr 2022 20:35:35 -0000

Reviewer: Christer Holmberg
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lisp-vendor-lcaf-09
Reviewer: Christer Holmberg
Review Date: 2022-04-11
IETF LC End Date: 2022-04-12
IESG Telechat date: Not scheduled for a telechat

Summary:

The document is well written, and easy to read and understand. However, I do
have a couple of issues.

Major issues:

Q1:

I do wonder why the document is published as Experimental, however, due to the
following reasons:

   a)

   The document defines usage of the Type value 255.

   b)

   Section 3 says:

      "If a LISP device receives a LISP message containing a Vendor Specific
       LCAF with an OUI that it does not understand, it MUST drop the
       message and it SHOULD create a log message."

   This sounds like an update to LISP.

   c)

   Section 3 defines new header fields.

Minor issues:

N/A

Nits/editorial comments:

Q2:

Section 1 says:

   “The Vendor Specific LCAF allows organizations to create
   LCAF addresses to be used only internally on particular LISP
   deployments.”

Is “allows” the best wording? Where organizations previously disallowed to do
this?

Would it be more correct to say “defines how organizations can create…”?