[Gen-art] Re: Gen-ART Review of draft-ietf-ipoib-connected-mode-02.txt
Vivek Kashyap <vivk@us.ibm.com> Fri, 03 March 2006 18:23 UTC
Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1FFEvx-0001wa-Vt; Fri, 03 Mar 2006 13:23:22 -0500
Received: from [10.91.34.44] (helo=ietf-mx.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1FFEtv-0008Ko-Qx for gen-art@ietf.org; Fri, 03 Mar 2006 13:21:15 -0500
Received: from e34.co.us.ibm.com ([32.97.110.152]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1FFEtu-0007lX-9g for gen-art@ietf.org; Fri, 03 Mar 2006 13:21:15 -0500
Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e34.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id k23ILA3G012529 for <gen-art@ietf.org>; Fri, 3 Mar 2006 13:21:10 -0500
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k23IIX4Y258226 for <gen-art@ietf.org>; Fri, 3 Mar 2006 11:18:33 -0700
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id k23IL9n9021551 for <gen-art@ietf.org>; Fri, 3 Mar 2006 11:21:09 -0700
Received: from d03nm122.boulder.ibm.com (d03nm122.boulder.ibm.com [9.17.195.148]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id k23IL9Fe021538; Fri, 3 Mar 2006 11:21:09 -0700
In-Reply-To: <088901c6328e$2f639cc0$0500a8c0@china.huawei.com>
To: Spencer Dawkins <spencer@mcsr-labs.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0.2CF1 June 9, 2003
Message-ID: <OFC896FD2C.82417E50-ON88257126.0063BFBB-88257126.0064EAC3@us.ibm.com>
From: Vivek Kashyap <vivk@us.ibm.com>
Date: Fri, 03 Mar 2006 10:24:40 -0800
X-MIMETrack: Serialize by Router on D03NM122/03/M/IBM(Release 6.53HF654 | July 22, 2005) at 03/03/2006 11:24:44, Serialize complete at 03/03/2006 11:24:44
X-Spam-Score: 0.1 (/)
X-Scan-Signature: f884eb1d4ec5a230688d7edc526ea665
X-Mailman-Approved-At: Fri, 03 Mar 2006 13:23:21 -0500
Cc: Margaret Wasserman <margaret@thingmagic.com>, kashyapv <kashyapv@us.ibm.com>, General Area Review Team <gen-art@ietf.org>, "H.K. Jerry Chu" <jerry.chu@sun.com>, Bill Strahm <bill@strahm.net>
Subject: [Gen-art] Re: Gen-ART Review of draft-ietf-ipoib-connected-mode-02.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============0546297206=="
Errors-To: gen-art-bounces@ietf.org
thanks. I'm catching up a bit late and I see some responses. Responding to this mail since it covers all review comments. I'll make all changes togehter with other IESG comments. See comments below marked by <VK>. Vivek -- Vivek Kashyap Linux Technology Center, IBM vivk@us.ibm.com kashyapv@us.ibm.com Ph: 503 578 3422 T/L: 775 3422 "Spencer Dawkins" <spencer@mcsr-labs.org> 02/15/2006 04:16 PM To: "General Area Review Team" <gen-art@ietf.org> cc: "Margaret Wasserman" <margaret@thingmagic.com>, "H.K. Jerry Chu" <jerry.chu@sun.com>, "Bill Strahm" <bill@strahm.net>, Vivek Kashyap/Beaverton/IBM@IBMUS Subject: Gen-ART Review of draft-ietf-ipoib-connected-mode-02.txt I was selected as General Area Review Team reviewer for this specification (for background on Gen-ART, please see http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html). Summary: This document is on the right track for publication as a Proposed Standard. I do have some comments, but overall the document is in good shape. <VK> :) <VK> Specific review comments: There are a couple of places in the document that refer to 2^31-octet link MTUs for connected-mode Infiniband), and then talk about "reasonably large MTUs" without qualification. I would be more comfortable if the text talked about "reasonably large MTUs, up to the 64-kilobyte maximum IP length", just to manage expectations more clearly. <VK> This covers jumbograms as Brian mentioned. In that context we can probably leave the text as it is. <VK> The document does attempt to explain "why use connected mode if datagram mode is most appropriate for IP?". The introduction names two advantages of connected mode (larger MTUs and enhanced reliability), but it would be nice to be a bit clearer ("These are the advantages of Infiniband connected mode over datagram mode:") - I'm not even sure from the text if these are the only advantages or not. <VK> ok...can add a list. <VK> The document does talk about retransmission timer interaction with TCP RTO (in Section 7.1), and this is good, but the text suggests "the RC timers as well as the maximum message size supported at the IPoIB-RC connection must be set judiciously". This is actually harder than it looks, because TCP RTO is adaptive (with a minumum value of one second), so it would be nice to offer a little more guidance on selecting RC timer values. <VK> ok..I'll consult some IB folks and determine how to phrase the guidance. fyi..RC timers are sub-second. <VK> In Section 8.0, Security Considerations, "A node may be returned a false set of flags by an imposter" is just a little too out-of-context for me to parse. Naming the operation being attacked and/or the message containing the false set of flags would help. <VK> ok. <VK> Editorial comments noticed during Gen-ART review: In the second sentence of the Introduction, "The document [IPoIB_ARCH] provides" is awkward - the style used in the first sentence, "The InfiniBand specification [IB_ARCH] can be found" is clearer to me (this is a nit). <VK> will incorporate when above changes are made. <VK>
_______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www1.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Gen-ART Review of draft-ietf-ipoib-conn… Spencer Dawkins
- Re: [Gen-art] Gen-ART Review of draft-ietf-ipoib-… Brian E Carpenter
- Re: [Gen-art] Gen-ART Review of draft-ietf-ipoib-… Spencer Dawkins
- [Gen-art] Re: Gen-ART Review of draft-ietf-ipoib-… Vivek Kashyap