Re: [Gen-art] Genart last call review of draft-ietf-dnsop-attrleaf-fix-04

Dave Crocker <dcrocker@gmail.com> Mon, 24 September 2018 13:16 UTC

Return-Path: <dcrocker@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0728D130EA7; Mon, 24 Sep 2018 06:16:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EfWRF_cDQZLZ; Mon, 24 Sep 2018 06:16:22 -0700 (PDT)
Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DC677130EA6; Mon, 24 Sep 2018 06:16:18 -0700 (PDT)
Received: by mail-pg1-x529.google.com with SMTP id y4-v6so9132936pgp.9; Mon, 24 Sep 2018 06:16:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yw0bcKZBiY2iqw+bDCiHSIU872+9FwVHebtTjq0rnjo=; b=EKP3jArQ6zbAWMiCBADilbAGU3gfZ0ZNavjhD8cPcLOHqGQgnplu8n7Ja2F7llKQRy WRom+/Uvmc5l6hcLuuhIyxbucSkmu4aD44chN6TiLmI9rut2E13Y37GuXzTodaM0AuYd R80zdhmQ7a7qqgpG+WMIBWjl+xM0dU/pSeTJrQDa9exKSLJQi9B5C1Yf6VcJokDy4KkG 98VPU3AUGlG6BQ/lpC7S8+UT1cxY5/rkBcUsCDeh3a+EHVLZzH6X7469OtBNakH/lAJV LT4sC/vGuS7RyGVXaWXiZ6gnVHmojoKIQWUwC0gh2QQXHgxQ6js7V3SlLPdxPkcSwZeF sEGw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yw0bcKZBiY2iqw+bDCiHSIU872+9FwVHebtTjq0rnjo=; b=MWVYZ8HJrs8WRNtJZb7f9cjQH4omaixKQPjaLw7NEZe/ZmRFpA0UYgwGhiz57ubscH a6TsTNEUd0gr5BfMEYb290dKTqWOEIY/Qxzd+axLOZpQZszEvZ0L2vHLyhFZepsA/2on 6UeXNoBphSS3Vkk83OIwmgKrp/sRDuK4V4A/5zThFCuwT9wNU55IBVQT6jKP9cFdv5PC iZgpLNTH/jNjSRRenm5Jr4GRLXCzl7x8rZtzMxQmv4/LATFWujgWD/G5Ulsu/nG+HOmu aR1tT3THjg15sHlzZCD8Vdi0bgWRM9+rBJ2lF8VGMMZmDDc2MKHoH9B8Vucvnv82fPJu 3AMQ==
X-Gm-Message-State: APzg51C+NoT4fsoPXDzd7ZYrnZ2QFQADCSIFoIDajNdWlB2nSk7GcLIX VoLuu9TG5DJU18MqPeRuZ8r/mYmz
X-Google-Smtp-Source: ANB0VdaUnoUJfvJpS9per/iyLLClsXMjFcoa2frDJEKwiiDRE3dCikQug0u2zldmGPB2c6pRiZ+iKQ==
X-Received: by 2002:a62:56d9:: with SMTP id h86-v6mr10443305pfj.229.1537794977726; Mon, 24 Sep 2018 06:16:17 -0700 (PDT)
Received: from [192.168.1.168] (76-218-8-128.lightspeed.sntcca.sbcglobal.net. [76.218.8.128]) by smtp.gmail.com with ESMTPSA id 8-v6sm42035418pgu.10.2018.09.24.06.16.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 06:16:16 -0700 (PDT)
To: Francesca Palombini <francesca.palombini@ericsson.com>, gen-art@ietf.org
Cc: dnsop@ietf.org, draft-ietf-dnsop-attrleaf-fix.all@ietf.org, ietf@ietf.org
References: <153778321966.28052.14784074370899947199@ietfa.amsl.com>
From: Dave Crocker <dcrocker@gmail.com>
Message-ID: <b8adca70-da9e-697d-c80f-c3f3de9aaf37@gmail.com>
Date: Mon, 24 Sep 2018 06:16:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <153778321966.28052.14784074370899947199@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/x19KhsfTwu9ztwhUZpOGcL3T6lQ>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-dnsop-attrleaf-fix-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2018 13:16:24 -0000

Hi.  Thanks for the detailed comments.

Some responses...

On 9/24/2018 3:00 AM, Francesca Palombini wrote:
>     The use of underscored node names is specific to each RRTYPE that is
>     being scoped.
> 
> As an non-expert in the area, I would have appreciate a ref to a document
> introducing RRTYPE.

The term is basic to DNS, with RFC 1035 cited in the first sentence of 
the Introduction:

      "Original uses of an underscore character as a domain node name
       [RFC1035] prefix, which creates a space for constrained
       interpretation of resource records, were specified without the
       benefit of an [IANA-reg] registry."

Once such a citation has been included, is a document expected to repeat 
the citation for every term used from it?  The implication is that 
someone reading this sort of document is not expected to have basic DNS 
familiarity?

However this did cause me to look for the first use of "RRTYPE" and I 
discovered that RFC 1035 has "RR TYPE" but not "RRTYPE". I'm not sure 
where first use without the space started.


>     This section provides a generic approach for changes to existing
>     specifications that define straightforward use of underscored node
>     names, when scoping the use of a "TXT" RRset.
> 
> Same for "TXT" RRset.

Same response.


> 
>     An effort has been made to locate existing drafts that
>     do this, register the global underscored names, and list them in this
>     document.
> 
> Since the effort has been done, I would have appreciated the full list here.

This is the 'fix' document, not the registry definition document.  The 
latter is cited in the first paragraph of this document's Introduction:

       "A registry has been now defined, and that document
        discusses the background for underscored domain name use
        [Attrleaf]."

That's where the list is provided.


>     An
>     effort has been made to locate existing drafts that do this, register
>     the global underscored names, and list them in this document.
> 
> Same as previous comment.

Same response.


>     An effort has been made to locate
>     existing drafts that do this and register the associated 'protocol'
>     names.
> 
> Same as previous.

Same response.


> 3.1. and 3.2. is the formatting of the updated sections (after "And is to be
> updated to the new text:") wanted? Why not use the same format as in 3.3., with
> OLD and NEW?

OK.


> 
>     +  Those registered by IANA in the "Service Name and Transport
>              Protocol Port Number Registry [RFC6335]"
> 
> Move the end quote after Registry.

ok.  Good catch.


>     +  Those listed in "Enumservice Registrations [RFC6117].
> 
> Missing end quote after Registrations.

ditto.


>     " Signaling Trust Anchor Knowledge in DNS Security Extensions
> 
> Remove the space after the quote.

ok.


>   John Levine, Bob Harold, Joel Jaeggli, Ond&#345;ej Sury and Paul
> 
> In Acknowledgements, one name is not encoded correctly.

I believe this as a bug in the xml2rfc generator used by the tools site, 
for text format, since the correct text is produced by an xml to html 
generator.


> 
>>From running the idnits tool (https://tools.ietf.org/tools/idnits/), several
> comments, warnings and one error were raised, which I snipped and pasted below
> as a summary:

What's most interesting here is that the document passed IDNits during 
submission!  (Apparently nits only works on txt documents and I only 
submitted an xml version; I'd guess the submission process does not 
general a txt version on the fly, for nits to inspect...)


>    -- The draft header indicates that this document updates RFC****, but the
>    abstract doesn't seem to mention this, which it should. (see
>    https://www.ietf.org/id-info/checklist) --> I see that the abstract generally
>    mentions "the existing specifications that use underscore naming", but I
>    think to make this correct, it should explicitely list them as well.

That actually makes no sense to me, since that would be fully redundant 
with the Updates header field that is already provided.


>    -- The document seems to lack a disclaimer for pre-RFC5378 work (See the
>    Legal Provisions document at https://trustee.ietf.org/license-info for more
>    information.)

Another victim of the long lag time.  I've updated the IPR template 
reference.  We'll see whether it's the right one...


>    == Unused Reference: several documents are included in the list of
>    references, but no explicit reference was found in the text --> if my
>    editorial comments are taken, they should fix this one.

This actually poses an interesting challenge.  The references are used 
in the Updates header field, but apparently IDNits does not look there.


>    ** Downref: Normative reference to an Informational RFC: RFC 7553

That document is a specification.  This document modifies it.  No matter 
it's standards track status, it is a normative reference to this document.


> 
>    -- Obsolete informational reference (is this intentional?): RFC 3921
>       (Obsoleted by RFC 6121)

Ack. Not intentional; just an error introduced by 12 years of lag time...

d/


-- 
Dave Crocker
Brandenburg InternetWorking
bbiw.net