Re: [Gen-art] Genart last call review of draft-ietf-asap-siptrunkingcapability-link-03

Lars Eggert <lars@eggert.org> Wed, 12 April 2023 13:14 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36C44C151B25; Wed, 12 Apr 2023 06:14:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rDbkQ4j443Ti; Wed, 12 Apr 2023 06:14:14 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A472C151B26; Wed, 12 Apr 2023 06:14:09 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:fd06:59fa:7e15:d1b0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 4AD4120957; Wed, 12 Apr 2023 16:14:02 +0300 (EEST)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Lars Eggert <lars@eggert.org>
Mime-Version: 1.0 (1.0)
Date: Wed, 12 Apr 2023 16:13:59 +0300
Message-Id: <9373185C-A981-483A-8F8A-960B4B176F80@eggert.org>
References: <167912859037.33679.2612983847284088869@ietfa.amsl.com>
Cc: gen-art@ietf.org, last-call@ietf.org, draft-ietf-asap-siptrunkingcapability-link.all@ietf.org, asap@ietf.org
In-Reply-To: <167912859037.33679.2612983847284088869@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-MailScanner-ID: 4AD4120957.A47A0
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/xp1ofUAG3nFdtcm6VvP4FVrkSkQ>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-asap-siptrunkingcapability-link-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Apr 2023 13:14:18 -0000

Dan, thank you for your review. I entered a No Objection ballot.

Lars

> On 18. Mar 2023, at 10:36, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-asap-siptrunkingcapability-link-03
> Reviewer: Dan Romascanu
> Review Date: 2023-03-18
> IETF LC End Date: 2023-03-22
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> This is a short and clear document describing the usage of the
> 'sip-trunking-capability' link relation type by an enterprise SIP network to
> retrieve a SIP trunking capability set document containing the capabilities and
> configuration requirements of an ITSP.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1. The description of the 'sip-trunking-capability' link relation by IANA does
> not seem to be fully consistent with the scope of the document as defined in
> Section 1.
> 
> In Section 1:
> 
> The capability set document
>   [I-D.ietf-asap-sip-auto-peer] encapsulates a set of characteristics
>   of an ITSP, which when retrieved by enterprise telephony network
>   devices allows for automated establishment of SIP [RFC3261] trunking
>   between the two telephony networks.
> 
> Description:  Refers to a capability set document that defines
>      parameters or configuration requirements for automated peering and
>      communication channel negotiation of the Session Initiation
>      Protocol (SIP).
> 
> I would consider mentioning explicitly 'SIP trunking' in the Description of the
> 'sip-trunking-capability' link relation in the registry.
> 
> 2. Should not  [I-D.ietf-asap-sip-auto-peer] be a Normative Reference?
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art