[Gen-art] Re: review of draft-ietf-rohc-rfc3095bis-framework-03.txt

"Lars-Erik Jonsson" <lars-erik@lejonsson.com> Wed, 29 November 2006 16:25 UTC

Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1GpSFb-0003oB-IS; Wed, 29 Nov 2006 11:25:35 -0500
Received: from [10.91.34.44] (helo=ietf-mx.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1GpRG8-0002pc-FW for gen-art@ietf.org; Wed, 29 Nov 2006 10:22:04 -0500
Received: from mother.ludd.ltu.se ([130.240.16.3]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1GpRDA-0006Le-Tz for gen-art@ietf.org; Wed, 29 Nov 2006 10:19:02 -0500
Received: from jymden3 (jymden.campus.luth.se [130.240.198.36]) by mother.ludd.ltu.se (8.13.6+Sun/8.12.10) with SMTP id kATFIpui015591; Wed, 29 Nov 2006 16:18:52 +0100 (MET)
Message-ID: <017001c713ca$0fd99df0$24c6f082@jymden3>
From: Lars-Erik Jonsson <lars-erik@lejonsson.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>, gen-art@ietf.org
References: <200611261542.kAQFgMmx003133@tao.fdupont.fr>
Date: Wed, 29 Nov 2006 16:21:31 +0100
MIME-Version: 1.0
Content-Type: text/plain; format="flowed"; charset="iso-8859-1"; reply-type="original"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.2869
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2962
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 6cca30437e2d04f45110f2ff8dc1b1d5
X-Mailman-Approved-At: Wed, 29 Nov 2006 11:25:34 -0500
Cc: "Kristofer Sandlund (LU/EAB)" <kristofer.sandlund@ericsson.com>, "Magnus Westerlund (KI/EAB)" <magnus.westerlund@ericsson.com>, "Ghyslain Pelletier (LU/EAB)" <ghyslain.pelletier@ericsson.com>
Subject: [Gen-art] Re: review of draft-ietf-rohc-rfc3095bis-framework-03.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Errors-To: gen-art-bounces@ietf.org

As per Magnus request, the draft has been updated. See inline what has been 
changed.

BR,
/L-E


> -First comment is an exception, it is technical: 4.4 page 11 doesn't
> metion that ROHC has the capability to work without a feedback channel,
> i.e., on simplex/one-way links. As it is both an unique and important
> in some cases capability IMHO it should be mentioned somewhere...

This should be clear from other places in the draft, and does not really
fit well here where only the ROHC channel is discussed. There is also
a reference here to the terminology and channel mapping RCF, where
more material on how to map ROHC on top of different channel
scenarios can be found.


> -The second exception is the TCP profile in 6 page 32 which is not yet
> an RFC, so the RFC editor could have to wait for it and update the
> document (it is not an issue but RFC editor should be warned).

This is an Informational reference, so it is not a show-stopper in any
way. By the way, the TCP profile was just submitted to the AD. =)


> -There are many cases of "i.e." and "e.g." not folloed by a comma,
> 2.2 page 5 (2), 3.1 page 7, 4.4 pagee 11 (3), 12 (4), 4.6 page 13,
> 5 page 13, 5.2.5 page 235.3.1.4 page 26, 6 page 30.

This is not an error!


> -In 2.1 page 4 (NACK): Acknowledgement -> Acknowledgment
> -In 3.2 page 7: acknowledgements -> acknowledgments
> -In 5.2.4.1 last line of page 21: acknowledgement -> acknowledgment.

Corrected, now the document should be consistent in this regard.


> -In 4.3 page 10: "extendable" is not a valid English word?

Actually it is!


> -In 4.3 page 10, "feeback from implementers have also" -> has?

Corrected!


> -In 4.4 page 11 there are two "make it possible" which IMHO should be
> "make possible".

Not changed, current text seems correct to us!


> -In 4.4 at the top of page 12: their definition assume -> definitions.

There is one common definition in this regard. -> No change.


> -In 4.5 page 12: and it then -> and then.

Agree, changed!


> -In 5.1.1 page 14: one another need not even have CID spaces -> to have
> CID space

This became "...do not even need to have CID space..."


> -In 6 page 30: fields, or ... types, updates -> update (without the 
> comma?)

Agree, changed (but with the comma). 


_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www1.ietf.org/mailman/listinfo/gen-art