Re: [Geopriv] WGLC: draft-ietf-geopriv-flow-identity-00

Martin Thomson <martin.thomson@gmail.com> Thu, 13 September 2012 16:35 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: geopriv@ietfa.amsl.com
Delivered-To: geopriv@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D629A21F860B for <geopriv@ietfa.amsl.com>; Thu, 13 Sep 2012 09:35:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.759
X-Spam-Level:
X-Spam-Status: No, score=-3.759 tagged_above=-999 required=5 tests=[AWL=-0.160, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rwdlT53QYPmE for <geopriv@ietfa.amsl.com>; Thu, 13 Sep 2012 09:35:32 -0700 (PDT)
Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) by ietfa.amsl.com (Postfix) with ESMTP id A3B2E21F8607 for <geopriv@ietf.org>; Thu, 13 Sep 2012 09:35:31 -0700 (PDT)
Received: by lbky2 with SMTP id y2so2264117lbk.31 for <geopriv@ietf.org>; Thu, 13 Sep 2012 09:35:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=z2uBeK6HhxwMEJg0TZFFiNkhifQvXTfn7Ct4c1nJrl8=; b=Av1VMOdA3iQ+Dmzbxp1wdmR4zJhNKWRXWDFrHoW3x+J3ZIFq5TjybHU+w5d6mup/v0 MHvrdyYQVZRTO0GCM9JLS7Fy35i1sPKBvEfoU8jpidjrT80Ox2uo8QUDEvolZk1Mw9+4 dr6pkNlMa+DeZaMo2s4Uc+6oIEvTOFB5wPzx0lbzzOv9/AWGLPb/NNUt5LZ1hQ3MuG7v 0hL0vzMqUB/8VKsdwnlwc7DG1ZpoVYx+6RVbzh8/vyQnVQooiZkGNQpJa1g96fJArpKV VQYZGJHm53Os20ohoiz0VRaNWQEZvsVUOV5d3ygTJfHh7hxlv4+NFrJNMcPiiBNUaxIe 63lg==
MIME-Version: 1.0
Received: by 10.112.49.202 with SMTP id w10mr78266lbn.109.1347554130502; Thu, 13 Sep 2012 09:35:30 -0700 (PDT)
Received: by 10.112.1.36 with HTTP; Thu, 13 Sep 2012 09:35:30 -0700 (PDT)
In-Reply-To: <5295BA39-EC17-49CB-A08E-5D2BF7CC1B9C@cdt.org>
References: <5295BA39-EC17-49CB-A08E-5D2BF7CC1B9C@cdt.org>
Date: Thu, 13 Sep 2012 09:35:30 -0700
Message-ID: <CABkgnnVChq7JgRCPYyxDeC4C2S+rdye2mA0tQy0rNrXgFxWOmQ@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: Alissa Cooper <acooper@cdt.org>
Content-Type: text/plain; charset="UTF-8"
Cc: GEOPRIV WG <geopriv@ietf.org>
Subject: Re: [Geopriv] WGLC: draft-ietf-geopriv-flow-identity-00
X-BeenThere: geopriv@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Geographic Location/Privacy <geopriv.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/geopriv>, <mailto:geopriv-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/geopriv>
List-Post: <mailto:geopriv@ietf.org>
List-Help: <mailto:geopriv-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/geopriv>, <mailto:geopriv-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Sep 2012 16:35:33 -0000

Looks good.

Minor comment that the editor might like to consider for the
schema...or not: enumerated types are more efficient than branching
regular expressions when it comes to defining simple types.  This
would apply to "layer3" and "target".  "layer4" would require a union
type with an enumerated type and a number (though the number could be
range constrained in that case).

I'll let Ray use his discretion - it's clear that the current schema
is correct.  A more efficient schema can be built by implementers

Nit in Section 3, p1: s/show/shown/

On 13 September 2012 07:52, Alissa Cooper <acooper@cdt.org> wrote:
> Dear GEOPRIV,
>
> This is a Working Group Last Call for comments on draft-ietf-geopriv-flow-identity-00:
> <http://tools.ietf.org/html/draft-ietf-geopriv-flow-identity-00>
>
> Please send comments to the list no later than Friday, 5 October 2012.
>
> Remember that all comments are helpful, even if it's just "Looks good to me".  You can also say "Doesn't look good to me", but it's more helpful to say why!
>
> Thanks,
> Alissa
> _______________________________________________
> Geopriv mailing list
> Geopriv@ietf.org
> https://www.ietf.org/mailman/listinfo/geopriv