IETF Logo Mail Archive

[GROW] RtgDir review: draft-ietf-grow-mrt-add-paths-03

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Tue, 14 February 2017 10:20 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 717941294C4; Tue, 14 Feb 2017 02:20:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gkeN0e_GIVwf; Tue, 14 Feb 2017 02:20:40 -0800 (PST)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62958129416; Tue, 14 Feb 2017 02:20:36 -0800 (PST)
X-AuditID: c1b4fb2d-2a63298000001743-39-58a2d9f2fe10
Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.183.87]) by (Symantec Mail Security) with SMTP id C3.7B.05955.2F9D2A85; Tue, 14 Feb 2017 11:20:34 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.87) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 14 Feb 2017 11:20:11 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.onmicrosoft.com; s=selector1-ericsson-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OYJQYg6SuZ8RkgUrNx1vKAqT/RWed0YanwnGWD7Hrbs=; b=KK496YsbI+s/YOZTehF5YKKxDRTtH6hOdKTAGYEAkMHASsedRvAywf+IQjWNjuNKJKa2AT1AyzrsC/rvx19nXooVhgLlDCD9z8704RlgcKOidxzxu6L1lh28COizeOFurOh2rk3wCGoa1b1zIWYExh527ZvdAFXDUWIptgg1FTs=
Received: from AM2PR07MB0994.eurprd07.prod.outlook.com (10.162.37.152) by AM2PR07MB0994.eurprd07.prod.outlook.com (10.162.37.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.5; Tue, 14 Feb 2017 10:20:10 +0000
Received: from AM2PR07MB0994.eurprd07.prod.outlook.com ([10.162.37.152]) by AM2PR07MB0994.eurprd07.prod.outlook.com ([10.162.37.152]) with mapi id 15.01.0888.030; Tue, 14 Feb 2017 10:20:10 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-grow-mrt-add-paths-03
Thread-Index: AdKGqTVwlh+krP/jTxSPfPuKKmZuuw==
Date: Tue, 14 Feb 2017 10:20:10 +0000
Message-ID: <AM2PR07MB09949B3ABDBC211D66FD04F7F0580@AM2PR07MB0994.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniele.ceccarelli@ericsson.com;
x-originating-ip: [151.0.200.100]
x-ms-office365-filtering-correlation-id: d25b3e04-b5c0-43e0-b58b-08d454c30e74
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM2PR07MB0994;
x-microsoft-exchange-diagnostics: 1; AM2PR07MB0994; 7:fsJiIIyu9/By5/zNHe6evAUmIB9XK7FhphCbnZ4m8KJu8a0mE7bNQkfDfksVxnuUdLWRMkhXrq9jp1YUp/SdtBJwxr3/Wk407fOGc3iod13fwOhZ6gxSp554OGHH1zMr3N31HUPc0nG1ShKxfA1wQYV7Xw9mfjNkOghv78jT1pnFIL9u9orr8svRq1JHglDvA7Jo7Ob2aBuo/KvF55UnCJ0/LDnI01ImeAF2WeIWnUuy/nk7zgeUIcmg29hk6uDCBzq1i63Yj+ZoL5RmQRoHNaC5qWUEvN/iIefDTUyrGPE73zNT8vidlc7vaVIU+Av7KRFj2Msw6JnqN44TN6TVWuyZIoTUYtIhYQTAXufDuXooePy2thPOPhyrFUMjl31loWVpBVz3DguzSXvzIX2uVJyXNdycQwaJk7KvlDzY9NgZXTAfaoJtHppx0uj1GflWxuEN45ikRYRplurer1lp95QmVfr/3bm6ZB+RuCGc90JAO4DDa9xG9rDtgz4hEcWJAshh+xwfFl8+00aGBHsbeQ==
x-microsoft-antispam-prvs: <AM2PR07MB0994CCEF235DA45D9C9B0682F0580@AM2PR07MB0994.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123558025)(20161123555025)(20161123560025)(6072148); SRVR:AM2PR07MB0994; BCL:0; PCL:0; RULEID:; SRVR:AM2PR07MB0994;
x-forefront-prvs: 0218A015FA
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916002)(39450400003)(189002)(377424004)(199003)(53936002)(33656002)(6116002)(3846002)(102836003)(790700001)(101416001)(54356999)(2906002)(55016002)(97736004)(110136004)(54906002)(54896002)(50986999)(9686003)(236005)(6306002)(105586002)(99286003)(25786008)(106356001)(68736007)(7736002)(38730400002)(92566002)(450100001)(2900100001)(122556002)(230783001)(86362001)(74316002)(6506006)(6436002)(7906003)(4326007)(66066001)(606005)(77096006)(81156014)(81166006)(5660300001)(3280700002)(8676002)(189998001)(81003)(3660700001)(7696004)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR07MB0994; H:AM2PR07MB0994.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_AM2PR07MB09949B3ABDBC211D66FD04F7F0580AM2PR07MB0994eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2017 10:20:10.2405 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR07MB0994
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02SfyxVYRjH995zjnNYd3tdV57JP+4mavMjWt2JK+oPbbVZ7bpmWd04w/zc OVhqbX5El1KI4rohLCNSUVEUd1auWkKKhrKuX+uXMUkauc61+e/zPN/v+z7v99nLEJIGyp6J jk9iuXh1rMzCiiwNeaJynR+pCvEw1nrIs/oKRfK5S78s5AbdH0Je2TBJHyQDa2qWRUEo1Mon go2NTmE5d8Vpq6j7zw4l5q6is20ZnXQaallCuciSAbwXiktu0iaW4HsIpjSKXGS1zj0IGitW kakgcR4BQ8+HKUEpFkFmZjMtFC8RzHRUkbmIYSywNxj1R00oxQrQ9ruaLASuQ9CpeU2ZRthg OZSXVRMmlmJfqDfME4LfDVZ6OFObxE4wlj+08ToxPgkXS95uHEV4Oyz1NohMTGA7+GSsEAkJ MNS09xEC28Ls11Wz/ww0ZbWaPY7wrl5r5mMwMfATbfLjFzkbUQC/IaF8bYgUhBjI+D1uIbA3 aApeUYJJK4LvFdmUIDhAW/Ga+dYPFCwY/IQ9slDbmIWEwPYw9j7HzA4wM9pBCQkS4IfmBp2P nLVbAmm3SNqNBViDodRIatd3ROBd0PTUXbA4QtHlCVpgF8jS3aK39isRXY9seZbn4yI9vdxY Ljqc5xPi3eLZpIdo/Q91tay4tqK73/z1CDNItk08Z7gdIqHUKXxqnB4BQ8ik4qLhqhCJOEKd eo7lEk5xybEsr0c7GFJmJ95X91klwZHqJDaGZRNZblMVMZb2aUiy1N1+/kuyYpI5MTqjyfZU pgc09yXD33/V0w6pbc7VRiposeDAioPLxwj5oC48VOkXUEL29k+VenWnK/39UVkYZ6eadlIm LZIxy9bXI8JmkruCQ3fu1wUt6A9fGRj0eUSrVIG+0onjhXeOpNlUAfAX3HPygqmRWbh6bfyB jOSj1Ht2Exyv/g/ddr5LPwMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/5KdNjFImf7c1f4sI3PconmAObAk>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-grow-mrt-add-paths.all@ietf.org" <draft-ietf-grow-mrt-add-paths.all@ietf.org>, "grow@ietf.org" <grow@ietf.org>
Subject: [GROW] RtgDir review: draft-ietf-grow-mrt-add-paths-03
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2017 10:20:42 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-grow-mrt-add-paths-03
Reviewer: Daniele Ceccarelli
Review Date: 2017-02-14
IETF LC End Date: 2017-02-15
Intended Status: Proposed Standard

Summary:
No issues found. This document is ready for publication.

Comments:
Very difficult to read if not familiar with the subject, maybe some more words in the intro and in section 3 and 4 when defining the new subtypes would help, but in the end I don’t expect non subject experts to read it.

Major Issues:
"No major issues found."

Minor Issues:
"No minor issues found."

Nits:

Line numbering according to: https://www.ietf.org/tools/idnits?url=https://www.ietf.org/archive/id/draft-ietf-grow-mrt-add-paths-03.txt
Line 87 – “the so-called MRT subtypes are utilized.” I’d drop “so-called”. I had a look at RFC 6396 and they are defined as MRT subtypes.
Line 89 – Please extend NLRI on first usage and suggest adding RFC4271 as reference
Line 94 – please extend RIB on first usage
Figure 1 – Seems to be wrongly formatted, some characters are missing


192        The values provided above are suggested as they are used in

193        implementations.
This is very risky. I’d suggest to ask for early allocation if implementations exist before the values are allocated via the normal IETF process.

BR
Daniele

v2.23.0 | Report a Bug | By Email