Re: [GROW] I-D Action: draft-ietf-grow-bmp-path-marking-tlv-00.txt

[Luuk Hendriks <[e-mail]>]

Hi Camilo, all,


I remember being confused when reading the previous version about which
Path Statuses would apply to which RIBs, whether they apply to only a
single RIB or perhaps multiple, etc. The implementation note described
in 3.3 clears that up, and I think it deserves a more prominent place
earlier on in the document eventually.

All those implementation seem very useful and good food for thought,
thanks for adding them. Regarding the alternatives for combining
standard and enterprise status (3.4), do you think we have enough bits
available for replication of the standard definitions in the enterprise
space (option #1)? With the currently listed 11 statuses, the 11 LSB
bits are used, perhaps a couple more should be reserved (16 in total?
20?) for the standard definitions. That leaves 16 or 12 bits for the
actual enterprise statuses.
Might very well be sufficient, but at the same time it's sort of scarce
and new statuses should be defined with care.



Some nits:

Sec 1:

    'or in the BMP Update Message'
    ->
    'or in the BMP Route Monitoring Message' ?

    'BMP server'
    ->
    'BMP station' (for consistency with other documents)

Sec 2.1

If no reason code is carried, according to the text 'this field is
empty'. Does that mean it's two bytes worth of zeroes (MUST be zeroes)?
Or is the field omitted altogether? In other words, is the Length always
6, or is it 4 whenever there is no reason code?

The caption under Table 2 says 'Path Type' while the text uses the term
'Path Status'. There are 11 entries in the table, the text mentions '10'.


In Table 2, Reason Code 0x0007 is listed twice.


Sec 2.2

The second bullet point under Figure 3 says 'Type = 1 (15 bits)', I
think that ' = 1' is an (incorrect) leftover and should go?

The ordering of bullet points is inconsistent with the figure, i.e.
'PEN' is explained after Index is. Also with the 'N' meaning 'Number'
already, the 'Number' in 'PEN Number' is redundant.
Super nit: the capitalization of octets/Octets is inconsistent in those
bullet points.



Thanks,
 luuk




On Tue 19 Sep 2023, 11:36, Camilo Cardona wrote:
> Hello Grow,  
> 
> There is a new version of the draft-ietf-grow-bmp-path-marking, now a working group document.   
> 
> Compared to the previous version, we added some notes regarding implementation. Many of them were discussed thanks to the work from Maxence Younsi, who implemented the feature in FRRouting. He presented his work in the previous GROW session.  
> 
> Please give it a read, and let us know if there are any thoughts, criticism, etc.  
> 
> Thanks, 
> Draft authors
> 
> 
> > On 13 Sep 2023, at 09:07, [e-mail] wrote:
> > 
> > Internet-Draft draft-ietf-grow-bmp-path-marking-tlv-00.txt is now available.
> > It is a work item of the Global Routing Operations (GROW) WG of the IETF.
> > 
> >   Title:   BMP Extension for Path Status TLV
> >   Authors: Camilo Cardona
> >            Paolo Lucente
> >            Pierre Francois
> >            Yunan Gu
> >            Thomas Graf
> >   Name:    draft-ietf-grow-bmp-path-marking-tlv-00.txt
> >   Pages:   11
> >   Dates:   2023-09-11
> > 
> > Abstract:
> > 
> >   The BGP Monitoring Protocol (BMP) provides an interface for obtaining
> >   BGP Path information.  BGP Path Information is conveyed within BMP
> >   Route Monitoring (RM) messages.  This document proposes an extension
> >   to BMP to convey the status of a path after being processed by the
> >   BGP process.  This extension makes use of the TLV mechanims described
> >   in draft-ietf-grow-bmp-tlv [I-D.ietf-grow-bmp-tlv] and
> >   draft-ietf-grow-bmp-tlv-ebit [I-D.ietf-grow-bmp-tlv-ebit].
> > 
> > The IETF datatracker status page for this Internet-Draft is:
> > https://datatracker.ietf.org/doc/draft-ietf-grow-bmp-path-marking-tlv/
> > 
> > There is also an HTMLized version available at:
> > https://datatracker.ietf.org/doc/html/draft-ietf-grow-bmp-path-marking-tlv-00
> > 
> > Internet-Drafts are also available by rsync at:
> > rsync.ietf.org::internet-drafts
> > 
> > 
> > _______________________________________________
> > GROW mailing list
> > [e-mail]
> > https://www.ietf.org/mailman/listinfo/grow
> 

> _______________________________________________
> GROW mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/grow