Re: [GROW] AD Review of draft-ietf-grow-bgp-session-culling

Warren Kumari <warren@kumari.net> Mon, 11 September 2017 16:17 UTC

Return-Path: <warren@kumari.net>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E73DE133147 for <grow@ietfa.amsl.com>; Mon, 11 Sep 2017 09:17:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kumari-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N0SJYB1q5dUE for <grow@ietfa.amsl.com>; Mon, 11 Sep 2017 09:17:04 -0700 (PDT)
Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 714C6133143 for <grow@ietf.org>; Mon, 11 Sep 2017 09:17:04 -0700 (PDT)
Received: by mail-wm0-x22e.google.com with SMTP id f199so43760686wme.0 for <grow@ietf.org>; Mon, 11 Sep 2017 09:17:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kumari-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=moztg0dG4YyjH7Y6JRiox1OjPaBcvIqTfCN2cMXz4+c=; b=VG2U6piLHQzeun9+5NSHyYNOpklO9hN4s/gHd/bc/Thp0jOwr6O1yqs58z3G/zFhgx k2Ex57JTVL1PfYMUI6NtDuhub/BBCSgpOf8g0dgMOW67SwGgTPigBEgwa4iV9pTQ7kh5 9FVvljD+B3eNMYpZ741sYUjdVO+j3WYXPN1+5hTiqQjQ3uTi7o6wmlMp8/BX30uA6Udc 0oIl2RbDzeDN8xsKB2gJUVRoV5rqoZoIz+fHkDkOA2NF1ntWfDjCUcmS2Dp9YBmKv27h n8q8Wt8J/169X1WAjlz/WABfrelXVwwOFzdP9/USFrdiQBseoZ3/PTybnV2gP3gF/3Le HIXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=moztg0dG4YyjH7Y6JRiox1OjPaBcvIqTfCN2cMXz4+c=; b=EBW1VEPdeyl4l/4WMaKZb1u7ehNSa8JaLZkhTGXjftfCEO/E4s/pnkFT7FxiypMWpk hJXusm5flEOuGBHwFCllk0W/05ZNgUYhvWWxxCSFSTSxJHq9rJPqMkNBIOVfvf55ow0U Axm5HJUtcgHL0Qtdhp7mNSokucivNavfYaP8HH8M0/zzfS7Vey84q1iMUNbvQxMu1Pjo AhWFv/bRGAvx5bUeXv0kvptXXGwHjT9jaJLj2sjwLHRCyhlAyH57fzS4HaTZ5G+D3Vmy V0Iyhv+YDV3yNeYLuAIBwhIMAFsz2FC2hVSp+cvjnyvh6lhJctFkxV2lThJEOxWfJiPB +l/w==
X-Gm-Message-State: AHPjjUjZlaNOO+/S7XdkQA5i1eQIdv6ziGoBkC4G9fwQ66aBa74jX3lm 1csVN1Cy8ludTuI5bg4b1qw5mfGaQ7Ib
X-Google-Smtp-Source: AOwi7QCtpNI98Xa7hJ8xLttqXuRnOjBf6Ck3yDyzQ0FkARwDTwNmUkQFF8zotGg6gRpGVMKXmmZRngpkmpaBJThP9tc=
X-Received: by 10.28.148.203 with SMTP id w194mr4397468wmd.91.1505146622822; Mon, 11 Sep 2017 09:17:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.164.141 with HTTP; Mon, 11 Sep 2017 09:16:22 -0700 (PDT)
In-Reply-To: <20170911155756.4a5bcnc4sgakbw67@hanna.meerval.net>
References: <CAHw9_iL9zHeBxsBo41bPsbYbeFB2sM=A-_KyzLTop125=mHPAA@mail.gmail.com> <20170911155756.4a5bcnc4sgakbw67@hanna.meerval.net>
From: Warren Kumari <warren@kumari.net>
Date: Mon, 11 Sep 2017 12:16:22 -0400
Message-ID: <CAHw9_i+F6PRkWRhDCOC44oPEin_FUY0DENV_mi5bvJeEpgBoEg@mail.gmail.com>
To: Job Snijders <job@ntt.net>
Cc: draft-ietf-grow-bgp-session-culling@ietf.org, grow@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/H7iXWXBdkiS0sUFBxzA9RyZJsDM>
Subject: Re: [GROW] AD Review of draft-ietf-grow-bgp-session-culling
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 16:17:08 -0000

On Mon, Sep 11, 2017 at 11:57 AM, Job Snijders <job@ntt.net> wrote:
> Dear Warren,
>
> On Sun, Sep 10, 2017 at 06:55:00PM -0400, Warren Kumari wrote:
>> I've just completed my AD review of draft-ietf-grow-bgp-session-culling.
>>
>> I only had a few small nits:
>>
>> Section 3:
>> "Involuntary BGP Session Teardown: The Caretaker of the lower layer
>>   network disrupts BGP control-plane traffic in the upper layer,
>>   causing the BGP Hold Timers of the affected BGP session to expire,"
>> -- it took me a few readings to parse this sentence -- I think that
>> the "in the upper layer" is redundant and confuses the sentence.
>> I think just removing it and
>>
>> "Involuntary BGP Session Teardown:  The Caretaker of the lower layer
>>   network disrupts (higher layer) BGP control-plane traffic,
>>   causing the BGP Hold Timers of the affected BGP session to expire,..." ?
>
> works for me!
>
>> 2: Section 3.2. Involuntary BGP Session Teardown Recommendations
>> "Such culling of control-plane traffic will pre-empt the" - s/pre-empt/preempt/
>
> Thanks
>
>> 3: I really like the fact that this has actual exmaple config. I think
>> it would be nice it if also included some more vendors.
>
> Even more?! We already have config for four vendors in the Internet-Draft itself. :-)

Your counting and my counting differ:
A.1.  Cisco IOS, IOS XR & Arista EOS Firewall Example Configuration
A.2.  Nokia SR OS Filter Example Configuration


Are you counting IOS and IOS XR as 2 vendors? :-P

Anyway, as I said, I really like the examples, and the GH solution WFM.


>
> There also is a link to https://github.com/bgp/bgp-session-culling-config-examples which is a
> more 'live' version which can be updated as we go. The github repo
> currently has 7 platforms, and perhaps over time will grow based on
> contributions.
>
> The configuration example in the Internet-Draft itself mostly serves to
> demonstrate the concept in the universal language other than English:
> router configs. The example configs are not meant to be an exhaustive
> overview.
>
>> Anyway, I'm fine to start IETF LC like this, but it you are able to
>> post a new version I think things might go smoother.
>>
>> Please let me know either way.
>
> Sure, I'll bump.
>

Okey dokey. I'll hit the go button when you do - please poke me if I
happen to miss it.
W

> Kind regards,
>
> Job



-- 
I don't think the execution is relevant when it was obviously a bad
idea in the first place.
This is like putting rabid weasels in your pants, and later expressing
regret at having chosen those particular rabid weasels and that pair
of pants.
   ---maf