Re: [GROW] I-D Action: draft-ietf-grow-bmp-tlv-ebit-04.txt

Luuk Hendriks <luuk@nlnetlabs.nl> Wed, 01 November 2023 09:45 UTC

Return-Path: <luuk@nlnetlabs.nl>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B957DC15C2AB for <grow@ietfa.amsl.com>; Wed, 1 Nov 2023 02:45:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.806
X-Spam-Level:
X-Spam-Status: No, score=-2.806 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=nlnetlabs.nl
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f0xJ7cScQi_1 for <grow@ietfa.amsl.com>; Wed, 1 Nov 2023 02:45:53 -0700 (PDT)
Received: from mout-b-110.mailbox.org (mout-b-110.mailbox.org [195.10.208.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4962C15152E for <grow@ietf.org>; Wed, 1 Nov 2023 02:45:52 -0700 (PDT)
Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-110.mailbox.org (Postfix) with ESMTPS id 4SL2F76krwz9v5G; Wed, 1 Nov 2023 10:45:47 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nlnetlabs.nl; s=MBO0001; t=1698831947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tT1N46lX5CUPYVxNnGHAMzOTn99OMrxNhxeqaEzTtLY=; b=VlyO9yUtkZJWZTH/WdYoIWqqT9i0FCas9QHYNI+72EAuBUO/5yefPLhI6kFb4fVJSHTD7f 3rUVozXUq+/6euawmV64+QSSiGnG1wnFY4lXqex6kuq/BgCoICtrEIuR6fn2fI0d3UUdpS beEw6WCUuwCMC4mEdO1Z3ToLQzjhIVUbw1uqrHUeR5TB6gURXN6/IN+fyjxGPe8814S5D9 2PQxVJ+VXKJx2bBHllL5ZEorHriERlasRcT0KBgfnKuXrrLZScYdSlNFix8aJjuewSOSJL dzFRyALtXkQK6NTM2VyllMIVFHFaAf2smzlTeT85fX+Ib7Ky1siZu4UI53lXzA==
Date: Wed, 01 Nov 2023 10:45:46 +0100
From: Luuk Hendriks <luuk@nlnetlabs.nl>
To: Paolo Lucente <paolo@ntt.net>
Cc: grow@ietf.org
Message-ID: <ZUIeSplsSn++cjZc@corley.shackle.nl>
References: <169806830441.60184.10918905237643936867@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <169806830441.60184.10918905237643936867@ietfa.amsl.com>
X-Rspamd-Queue-Id: 4SL2F76krwz9v5G
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/wojMpbT-pvNwqmwY6tMjZwwFEsI>
Subject: Re: [GROW] I-D Action: draft-ietf-grow-bmp-tlv-ebit-04.txt
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Nov 2023 09:45:59 -0000

Hi Paolo, all,

Thanks for the update. I have a question about something that was actually
already part of the previous version:


Sec 3.2:

In a non-indexed enterprise-specific TLV, the Length includes the PEN, which
I guess helps in making it backward compatible.
For indexed TLVs, the Length does not include the Index (Sec3 in bmp-tlv-13),
but what about indexed enterprise-specific TLVs? Does the length include the
length of the PEN, but not the Index?

If indeed the PEN is included and the Index is not, would it make sense to swap
the Index and PEN fields? Feels more consistent to interpret/process to me, but
perhaps I'm missing any downsides of such a reordering.

Either way, I think the text should clarify what the Length is comprised of in
indexed enterprise TLVs.


cheers,
 luuk


On Mon 23 Oct 2023, 06:38, internet-drafts@ietf.org wrote:
> Internet-Draft draft-ietf-grow-bmp-tlv-ebit-04.txt is now available. It is a
> work item of the Global Routing Operations (GROW) WG of the IETF.
> 
>    Title:   Support for Enterprise-specific TLVs in the BGP Monitoring Protocol
>    Authors: Paolo Lucente
>             Yunan Gu
>    Name:    draft-ietf-grow-bmp-tlv-ebit-04.txt
>    Pages:   7
>    Dates:   2023-10-23
> 
> Abstract:
> 
>    Message types defined by the BGP Monitoring Protocol (BMP) do
>    provision for data in TLV - Type, Length, Value - format, either in
>    the shape of a TLV message body, ie.  Route Mirroring and Stats
>    Reports, or optional TLVs at the end of a BMP message, ie.  Peer Up
>    and Peer Down.  However the space for Type value is unique and
>    governed by IANA.  To allow the usage of vendor-specific TLVs, a
>    mechanism to define per-vendor Type values is required.  In this
>    document we introduce an Enterprise Bit, or E-bit, for such purpose.
> 
> The IETF datatracker status page for this Internet-Draft is:
> https://datatracker.ietf.org/doc/draft-ietf-grow-bmp-tlv-ebit/
> 
> There is also an HTMLized version available at:
> https://datatracker.ietf.org/doc/html/draft-ietf-grow-bmp-tlv-ebit-04
> 
> A diff from the previous version is available at:
> https://author-tools.ietf.org/iddiff?url2=draft-ietf-grow-bmp-tlv-ebit-04
> 
> Internet-Drafts are also available by rsync at:
> rsync.ietf.org::internet-drafts
> 
> 
> _______________________________________________
> GROW mailing list
> GROW@ietf.org
> https://www.ietf.org/mailman/listinfo/grow