Re: [Hipsec] Fwd: New Version Notification for draft-ietf-hip-dex-12.txt

Jeff Ahrenholz <j.ahrenholz@tempered.io> Wed, 12 February 2020 17:20 UTC

Return-Path: <j.ahrenholz@tempered.io>
X-Original-To: hipsec@ietfa.amsl.com
Delivered-To: hipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B056120907 for <hipsec@ietfa.amsl.com>; Wed, 12 Feb 2020 09:20:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4NTkeL5qkQGQ for <hipsec@ietfa.amsl.com>; Wed, 12 Feb 2020 09:20:13 -0800 (PST)
Received: from out.west.exch081.serverdata.net (cas081-co-1.exch081.serverdata.net [199.193.204.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2044C1208FF for <hipsec@ietf.org>; Wed, 12 Feb 2020 09:20:12 -0800 (PST)
Received: from MBX081-W5-CO-2.exch081.serverpod.net (10.224.129.85) by MBX081-W5-CO-2 (10.224.129.85) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 12 Feb 2020 09:20:10 -0800
Received: from MBX081-W5-CO-2.exch081.serverpod.net ([10.224.129.85]) by MBX081-W5-CO-2.exch081.serverpod.net ([10.224.129.85]) with mapi id 15.00.1497.000; Wed, 12 Feb 2020 09:20:10 -0800
From: Jeff Ahrenholz <j.ahrenholz@tempered.io>
To: Robert Moskowitz <rgm@htt-consult.com>, HIP <hipsec@ietf.org>
Thread-Topic: [Hipsec] Fwd: New Version Notification for draft-ietf-hip-dex-12.txt
Thread-Index: AQHV4C5DLFeDBA4SN0GWJkS6qi8vwagX0P2A
Date: Wed, 12 Feb 2020 17:20:10 +0000
Message-ID: <66046762-C4F2-47AD-BE69-7CAA1AEB6F2A@tempered.io>
References: <158131871520.13534.9437394233256375155.idtracker@ietfa.amsl.com> <29372f3d-0a9e-949d-ce64-338be8561500@htt-consult.com>
In-Reply-To: <29372f3d-0a9e-949d-ce64-338be8561500@htt-consult.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [216.168.34.194]
Content-Type: text/plain; charset="utf-8"
Content-ID: <986FDDA36E409F4AB8A8F51E7AD6C7B7@exch081.serverpod.net>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/hipsec/AxS4_vawUuDy2SHX9JThJ6ndKX0>
Subject: Re: [Hipsec] Fwd: New Version Notification for draft-ietf-hip-dex-12.txt
X-BeenThere: hipsec@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is the official IETF Mailing List for the HIP Working Group." <hipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hipsec>, <mailto:hipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hipsec/>
List-Post: <mailto:hipsec@ietf.org>
List-Help: <mailto:hipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hipsec>, <mailto:hipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2020 17:20:15 -0000

> I believe this version answers all the IESG issues.
>
> Please review, there are some important additions.
>
> EKR had a number of security concerns.  Some I feel don't apply to HIP, like use an AEAD for HIP packet security.
>
> But there are a number of added sections, particularly in Security Considerations that are worth the group's review that I have things stated properly.
>
> Also there is a new parameter, I_NONCE to add Initiator randomness into the Master Key generation.  There is some cleanup in the KEYMAT section to reflect this.
>
> So please take a read through.

I took a look at the new I_NONCE parameter...

Regarding this statement (Section 5.2.6):
"The I_NONCE parameter encapsulates a random value that is later used in the Master key creation process (see Section 6.3)."

Looking at Section 6.3 HIP DEX KEYMAT Generation, it discusses using Diffie-Hellman derived key Kij, but I don't see anything about using I_NONCE. There is a random #I  provided by the Responder from the PUZZLE parameter, but nothing about a random I_NONCE supplied by the Initiator.

minor nits:
s/when key is smaller or equal to 128 bits/when the key is smaller or equal to 128 bits/
In Section 4.1.1 HIP Puzzle Mechanism, the links (HTML version) to RFC 7401 sections 4.1.1 and 4.1.2 do not link to RFC 7401 but to the dex draft.

-Jeff