Re: [hybi] [permessage-deflate] Renaming s2c_ and c2s_ prefix to server_ and client_

Peter Thorson <webmaster@zaphoyd.com> Wed, 09 October 2013 14:16 UTC

Return-Path: <webmaster@zaphoyd.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E3A521E8090 for <hybi@ietfa.amsl.com>; Wed, 9 Oct 2013 07:16:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.595
X-Spam-Level:
X-Spam-Status: No, score=-0.595 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HTML_MESSAGE=0.001, TRACKER_ID=2.003]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Iuea9a-X5BAF for <hybi@ietfa.amsl.com>; Wed, 9 Oct 2013 07:16:33 -0700 (PDT)
Received: from authsmtp00.uchicago.edu (authsmtp00.uchicago.edu [128.135.12.120]) by ietfa.amsl.com (Postfix) with ESMTP id 9B7AC11E816E for <hybi@ietf.org>; Wed, 9 Oct 2013 07:16:33 -0700 (PDT)
Received: from [10.0.1.88] (c-68-51-76-178.hsd1.il.comcast.net [68.51.76.178]) (Authenticated sender: zaphoyd) by authsmtp00.uchicago.edu (Postfix) with ESMTP id 3ACC54980B0; Wed, 9 Oct 2013 09:16:24 -0500 (CDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_2A90F4C5-DF38-45A3-89EC-0C082273ECAC"
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Peter Thorson <webmaster@zaphoyd.com>
In-Reply-To: <CAH9hSJant3VBw0FBM69V9wPvi3WmJLikZdX4ySELy+CShgoOKA@mail.gmail.com>
Date: Wed, 09 Oct 2013 09:16:22 -0500
Message-Id: <5BEA69BA-D0D4-4F4A-8CFB-741A433EAAA6@zaphoyd.com>
References: <CAH9hSJant3VBw0FBM69V9wPvi3WmJLikZdX4ySELy+CShgoOKA@mail.gmail.com>
To: Takeshi Yoshino <tyoshino@google.com>
X-Mailer: Apple Mail (2.1510)
Cc: "hybi@ietf.org" <hybi@ietf.org>
Subject: Re: [hybi] [permessage-deflate] Renaming s2c_ and c2s_ prefix to server_ and client_
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Oct 2013 14:16:38 -0000

Mostly neutral here with a slight preference for s2c/c2s vs server_/client_ for the following reason:

server_no_context_takeover

If I am a server receiving a message does this parameter apply to me? well it says server.. but in fact it doesn't.
If I am a client receiving a message does this parameter apply to me? well it says server.. but in fact it does.

s2c_no_context_takeover

If I am a server receiving a message does this parameter apply to me? In the prefix, server is not in the receiving position, does not apply.
If I am a client receiving a message does this parameter apply to me? In the prefix, client is in the receiving position, does apply.

The original relies on the spec to encode the fact that the s and c in s2c are "server" and "client". The proposal relies on the spec to encode the fact that server_ implies server to client. I found the explicit mention of both ends in the parameter helpful for quickly working out whether a particular parameter applied to a particular piece of code without referencing the spec.

Whether that outweighs the initial cryptic-ness of "s2c/c2s" I don't have a strong opinion on. I'd prefer server_no_context_takeover to server_to_client_no_context_takeover. In the grand scheme of things the difference is minor and I'll be fine with updating WebSocket++ either way.

Peter

On Oct 9, 2013, at 3:06 , Takeshi Yoshino <tyoshino@google.com> wrote:

> (Splitting into an independent thread)
> 
> Joakim suggested that we should rename them.
> http://www.ietf.org/mail-archive/web/hybi/current/msg10201.html
>  > Since all websocket communications are initiated by client to server
>  > these should just be s/s2c_/server_/g and s/c2s_/client_/g
> 
> Initially, I chose these prefixes to make it easy to understand that they're attributes for each direction by including source and destination explicitly. But server_ and client_ are not so confusing, too. As these parameters are request about the peer's output, everyone should understand X_no_context_takeover and X_max_window_bits as parameters instructing compressor of X.
> 
> If we do this, we should do this right now. I don't have strong opinion about this change. If there's no objection, I'll take it.
> 
> _______________________________________________
> hybi mailing list
> hybi@ietf.org
> https://www.ietf.org/mailman/listinfo/hybi