Re: [hybi] I-D Action: draft-ietf-hybi-thewebsocketprotocol-11.txt

Alexey Melnikov <alexey.melnikov@isode.com> Tue, 30 August 2011 11:01 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E59C221F854C for <hybi@ietfa.amsl.com>; Tue, 30 Aug 2011 04:01:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.557
X-Spam-Level:
X-Spam-Status: No, score=-102.557 tagged_above=-999 required=5 tests=[AWL=0.042, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cX7bCGNiJjU1 for <hybi@ietfa.amsl.com>; Tue, 30 Aug 2011 04:01:01 -0700 (PDT)
Received: from rufus.isode.com (rufus.isode.com [62.3.217.251]) by ietfa.amsl.com (Postfix) with ESMTP id 7BD9621F8548 for <hybi@ietf.org>; Tue, 30 Aug 2011 04:00:59 -0700 (PDT)
Received: from [192.168.1.124] ((unknown) [62.3.217.253]) by rufus.isode.com (submission channel) via TCP with ESMTPA id <TlzDQQBpJoin@rufus.isode.com>; Tue, 30 Aug 2011 12:02:25 +0100
X-SMTP-Protocol-Errors: NORDNS
Message-ID: <4E5CB8F1.4080301@isode.com>
Date: Tue, 30 Aug 2011 11:18:25 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915
X-Accept-Language: en-us, en
To: Takeshi Yoshino <tyoshino@google.com>
References: <20110823102713.23958.79728.idtracker@ietfa.amsl.com> <4E538213.7020207@isode.com> <CAH9hSJaDcOEf0n59PSqfWJcEpLBKBGssX13FNViCUBFc2vxMXg@mail.gmail.com>
In-Reply-To: <CAH9hSJaDcOEf0n59PSqfWJcEpLBKBGssX13FNViCUBFc2vxMXg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: hybi@ietf.org
Subject: Re: [hybi] I-D Action: draft-ietf-hybi-thewebsocketprotocol-11.txt
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Aug 2011 11:01:02 -0000

Takeshi Yoshino wrote:

> Hi Alexey,
>
> I have some questions about section 5.2.2. and 5.3.
>
> ----
>
> implied WSP rule -> implied LWS rule ?

Changed "implied WSP" to "implied *LWS" as per RFC 2616.

> ----
>
> Are 
> Sec-WebSocket-Protocol-Client, Sec-WebSocket-Version-Client, Sec-WebSocket-Protocol-Server, Sec-WebSocket-Version-Server 
> just names of ABNF rules?
>
> i.e. Sec-WebSocket-Protocol-Client is the grammar for the right hand 
> side of the Sec-WebSocket-Protocol header in client handshake?

I think I've clarified this by the following new text:

    (for example the Sec-WebSocket-Key ABNF rule describes the 
Sec-WebSocket-Key
    header field).
    <t>Note that the following ABNF conventions are used in this section:
    Some names of the rules correspond to names of the corresponding 
header fields
    Such rules express values of the corresponding header fields, for 
example
    the Sec-WebSocket-Key ABNF rule describes the Sec-WebSocket-Key
    header field.

    ABNF rules with the "-Client" suffix in the name are only used in 
requests sent
    by the client to the server; ABNF rules with the "-Server" suffix in 
the name
    are only used in responses sent by the server to the client. For 
example,
    the ABNF rule Sec-WebSocket-Protocol-Client describes syntax of the
    Sec-WebSocket-Protocol header field sent by the client to the server.
    </t>

> ----
>
> This ABNF doesn't cover 1, 2, ... 99
>            version = "0" | ("1" DIGIT DIGIT) | ("2" DIGIT DIGIT)
>                        ; 0-255

I think I got it right this time:

            NZDIGIT       =  "1" / "2" / "3" / "4" / "5" / "6" /
                             "7" / "8" / "9"
            version = DIGIT | (NZDIGIT DIGIT) |
                      ("1" DIGIT DIGIT) | ("2" DIGIT DIGIT)
                      ; Limited to 0-255 range