Re: [hybi] AD review of draft-ietf-hybi-permessage-compression-21

Takeshi Yoshino <tyoshino@google.com> Wed, 24 June 2015 05:06 UTC

Return-Path: <tyoshino@google.com>
X-Original-To: hybi@ietfa.amsl.com
Delivered-To: hybi@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66DEC1ACCDC for <hybi@ietfa.amsl.com>; Tue, 23 Jun 2015 22:06:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.388
X-Spam-Level:
X-Spam-Status: No, score=-1.388 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7gpo4DUuXKso for <hybi@ietfa.amsl.com>; Tue, 23 Jun 2015 22:06:07 -0700 (PDT)
Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 038291AC43C for <hybi@ietf.org>; Tue, 23 Jun 2015 22:06:06 -0700 (PDT)
Received: by oigb199 with SMTP id b199so22372952oig.3 for <hybi@ietf.org>; Tue, 23 Jun 2015 22:06:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=eGktYrLd54IO6Mb5+H1tO0h2MOTP6fJr0M+ShvKR7vA=; b=STcDzHkdOPh8lBjCwwa+3eqrhNBJ4LPNrzn1oDIGsNxCHrcFplU7Vkgdfhl8ZVjUDz blLzMKSsdcKF5rjhmWNfoJlHfCY7vQNecC4FEClst0/E7E/R9+NZQHhsAMvC4ZEYve3a RdIsxI/CpfqunVpgVtSSerUyYy85GZ7Wjpp9E6z+2OvUjandCIdFkjz7ZRpq9R1O2WPZ FWuAVGJZXEPz/xUzmDMDb7a+z/sendlaubvVxDJ09+IF1uFYeQtWaMWM2yVXPsYHF7ae PeoWVWTek6RrLZIVZG3BVJxB7FMM363xxMORrXWIDHbe9Ytt4VRTjjoSKtKA2xXgQV3I nQ+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=eGktYrLd54IO6Mb5+H1tO0h2MOTP6fJr0M+ShvKR7vA=; b=IlsZyJdwhKD438oIl1hc5cB8arNcM+D0yOOL9iJyb/6R/onxnB9US8cS8DXElWJ1mL /I6kbVKuwh7zy48Q/A56PzSHEFk7ShiFvunqbx8i20MTGK2YzfRzgyPETe7PbrrkYqFO s/0RW5Bui04LrbLv+5Q6hrHPt1SLliTH6c1OO6BdQ1dugxfwU0O2YzO+eVkq645ZlpGW LFzUv3xu+c4n0nC8n5ZplItIuMhhjN2e6CHEjNv7MeT3rLI76pknOen8qjkZPo0iOaJ3 1ku0BsMoBp6iKBE8Bhj2CXwc4FQrpN1Kn1mEvwOhR0ChH9VloV9OUQNMRmC4jgxv0/QF AoWQ==
X-Gm-Message-State: ALoCoQl7g7qE6GxGkedA3pFTy7Om48BaCNjYE5AuiPB4Iwd8kwgP+kzsm1Kthuau1KgSFxYdlafP
X-Received: by 10.182.24.40 with SMTP id r8mr33271213obf.15.1435122366325; Tue, 23 Jun 2015 22:06:06 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.202.66.130 with HTTP; Tue, 23 Jun 2015 22:05:46 -0700 (PDT)
In-Reply-To: <CALaySJJN_-o5EPaQh9keKSXpZ3Dh4O5acvb-kEyvQ-54d7TOGw@mail.gmail.com>
References: <CALaySJ+RKjS2px77Tt2diqLmd7-c76t9DxQLDAD2tYVU0P7CQg@mail.gmail.com> <CAH9hSJZs4ackDp6vPn9BZgcPSS_8EBhcc08jRiQOBxFQrD_y1A@mail.gmail.com> <CALaySJJR90jrRzhMmkuYJEUeHX6drHATj+TS+04pTYKWiWQitQ@mail.gmail.com> <CAH9hSJY85vnrtGWf-C0i1gJN-+rK7E0ibLzan6i4CF=tBM87qQ@mail.gmail.com> <CALaySJJN_-o5EPaQh9keKSXpZ3Dh4O5acvb-kEyvQ-54d7TOGw@mail.gmail.com>
From: Takeshi Yoshino <tyoshino@google.com>
Date: Wed, 24 Jun 2015 14:05:46 +0900
Message-ID: <CAH9hSJY_BkbTVK_pBX7N7jsUXrJs0xunbzZcKCQULbNJJJExXQ@mail.gmail.com>
To: Barry Leiba <barryleiba@computer.org>
Content-Type: multipart/alternative; boundary="001a11c29f1adad26305193c76d1"
Archived-At: <http://mailarchive.ietf.org/arch/msg/hybi/mHT5zMMaeyFUouaLrc7HWXpYlAE>
Cc: "hybi@ietf.org" <hybi@ietf.org>
Subject: Re: [hybi] AD review of draft-ietf-hybi-permessage-compression-21
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hybi/>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2015 05:06:08 -0000

Addressed in -23 (diff:
https://www.ietf.org/rfcdiff?url2=draft-ietf-hybi-permessage-compression-23).
If this looks rather bad, I'd revert it to the previous one.

Thanks

Takeshi

On Mon, Jun 22, 2015 at 7:30 PM, Barry Leiba <barryleiba@computer.org>
wrote:

> >> He-he.. I had thought to put the "Otherwise" parts into #2 items, and
> >> that's what I'd meant.  But I'm OK with it as you've done -- as you
> >> say, it reads better and more consistently that way.
> >
> > I was wondering if you meant so or not. I refrained from doing so as
> they're
> > not ordered steps but are cases of an if-branch.
> >
> > I agree that it would be better to make them formatted into a list. How
> > about non-number list like this? Numbered one would be better?
> >
> >    2.  Process the compressed data as follows:
> >
> >        *  If this PMCE is the last extension to process of outgoing
> >           messages, build frame(s) by using the compressed data instead
> >           of the original data for the message payload, and set the
> >           "Per-message Compressed" bit of the first frame, then send the
> >           frame(s) as described in Section 6.1 of RFC6455.
> >
> >        *  Otherwise, pass the transformed message payload and modified
> >           header values including the "Per-message Compressed" bit value
>
> That would work...
>
> Barry
>