IETF Logo Mail Archive

Re: [I2nsf] [Last-Call] Genart last call review of draft-ietf-i2nsf-capability-data-model-09

Lars Eggert <lars@eggert.org> Thu, 03 February 2022 11:02 UTC

Return-Path: <lars@eggert.org>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F6EA3A10E1; Thu, 3 Feb 2022 03:02:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.099
X-Spam-Level:
X-Spam-Status: No, score=-7.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KL1AOS_KShuK; Thu, 3 Feb 2022 03:02:27 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8DAE83A10DD; Thu, 3 Feb 2022 03:02:26 -0800 (PST)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:3483:e6e7:fbe7:7efc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id EF7721D2FF0; Thu, 3 Feb 2022 13:02:11 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1643886132; bh=aLQ80ynSX4kqmvDOMIrh1G/cAW2oNhR6PCN6nn6ZvTA=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=t7tsm6blnA4B508Vl2aD220TtECVlZn9x5wJIMbZ8i580mZj2ea9JSLawI9lW+mCK pPe1/dy/rOUFLiyY3hBJ7lqEprIKKp8uvRlhIxNBG9CaC+LyutVlLnBFs9AhZuJxRy y+7Chwdl5qmM7x+Ia4aXMxWTIthYAG5zYVvFMBDc=
Content-Type: multipart/signed; boundary="Apple-Mail=_E58ED14F-C0C3-48AC-A707-B284B798884F"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <159912491436.25569.2899532332802019244@ietfa.amsl.com>
Date: Thu, 03 Feb 2022 13:02:10 +0200
Cc: gen-art@ietf.org, i2nsf@ietf.org, last-call@ietf.org, draft-ietf-i2nsf-capability-data-model.all@ietf.org
Message-Id: <8D01597F-519B-4381-AEC9-7292AAA880EF@eggert.org>
References: <159912491436.25569.2899532332802019244@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-MailScanner-ID: EF7721D2FF0.A682B
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/iKqGeAF9MnzOuZ8MkmNyjGp6dJM>
Subject: Re: [I2nsf] [Last-Call] Genart last call review of draft-ietf-i2nsf-capability-data-model-09
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 11:02:34 -0000

Dan, thank you for your review and thank you all for the following discussion. I have entered a No Objection ballot for this document.

Lars


> On 2020-9-3, at 12:21, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-i2nsf-capability-data-model-09
> Reviewer: Dan Romascanu
> Review Date: 2020-09-03
> IETF LC End Date: 2020-09-08
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> Ready with Issues
> 
> This document defines a YANG data model for the capabilities of various NSFs in
> the I2NSF framework to centrally manage the capabilities of the various NSFs.
> This is a very clear and well written document, and the use cases and the
> examples also help its readability. The document was already reviewed and found
> READY for publication by the YANG Doctors, so I did not perform a detailed YANG
> review but rather focused on the Gen-ART specific aspects. A couple of issues
> should be discussed and clarified before approval.
> 
> Major issues:
> 
> Minor issues:
> 
> 1. In the introduction:
> 
>> This YANG data model is based on the
>   information model for I2NSF NSF capabilities
>   [I-D.ietf-i2nsf-capability].
> 
> So, the YANG data model is based on [I-D.ietf-i2nsf-capability], and the YANG
> module references [draft-ietf-i2nsf-nsf-monitoring-data-model-03] and
> [I-D.ietf-i2nsf-sdn-ipsec-flow-protection]. However, these three documents are
> listed as Informative References. Without them the document cannot be
> understood and implemented, so I believe that these reference should be moved
> to Normative References.
> 
> 2. In the YANG module a few condition capabilities have no REFERENCEs. Where
> can the semantics be found?
> 
> context-capability
> acl-number
> application
> target
> user
> group
> geography
> 
> Nits/editorial comments:
> 
> 1. Some of the acronyms are not expanded at first occurrence (VoIP, VoLTE,
> DDoS, etc. )
> 
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email