Re: [i2rs] WG LC on draft-ietf-i2rs-yang-network-topo (9/27/2017 to 10/11/2017) - WG Consensus declared by Chairs

Kent Watsen <kwatsen@juniper.net> Fri, 20 October 2017 15:39 UTC

Return-Path: <kwatsen@juniper.net>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A642413219C for <i2rs@ietfa.amsl.com>; Fri, 20 Oct 2017 08:39:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.019
X-Spam-Level:
X-Spam-Status: No, score=-2.019 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vbPua22lzPzz for <i2rs@ietfa.amsl.com>; Fri, 20 Oct 2017 08:39:22 -0700 (PDT)
Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0093.outbound.protection.outlook.com [104.47.42.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96ABA13423A for <i2rs@ietf.org>; Fri, 20 Oct 2017 08:39:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YcDtnQ7UYvVrm1TLCfTElsTCQVBiVmMBrSMWZ+IHFaU=; b=kt/HNk2oSF+q2WrcHO3yUMJwZDw4JJVYig3uP9jffU6uuH4Z7rFoQLxn/lhWpK1v9QXQWxsGVfh1xMw9aGUtm0tSmaIF4aqanBC7tZlyQeBEpJ7mRa9qn+Fcv63KGfXXeOoN04ctd9S1AFaCQXXIJ64rLZGSCglSr9+CUPufiTc=
Received: from BLUPR05MB275.namprd05.prod.outlook.com (10.141.22.149) by BLUPR05MB273.namprd05.prod.outlook.com (10.141.22.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.2; Fri, 20 Oct 2017 15:39:21 +0000
Received: from BLUPR05MB275.namprd05.prod.outlook.com ([10.141.22.149]) by BLUPR05MB275.namprd05.prod.outlook.com ([10.141.22.149]) with mapi id 15.20.0156.005; Fri, 20 Oct 2017 15:39:21 +0000
From: Kent Watsen <kwatsen@juniper.net>
To: Susan Hares <shares@ndzh.com>, "i2rs@ietf.org" <i2rs@ietf.org>
CC: 'Russ White' <russ@riw.us>, 'Alia Atlas' <akatlas@gmail.com>
Thread-Topic: [i2rs] WG LC on draft-ietf-i2rs-yang-network-topo (9/27/2017 to 10/11/2017) - WG Consensus declared by Chairs
Thread-Index: AdNF63MZWih0I+dES7WO1d6UnmTwEQDrJ+AA
Date: Fri, 20 Oct 2017 15:39:21 +0000
Message-ID: <C7249566-393E-4CAF-91EF-F7CF3D596E58@juniper.net>
References: <006101d345eb$87c656f0$975304d0$@ndzh.com>
In-Reply-To: <006101d345eb$87c656f0$975304d0$@ndzh.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.20.0.170309
x-originating-ip: [66.129.241.13]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BLUPR05MB273; 6:i6kehOGfvPBdEcq2gNxPlKA8wSXHgRTI3iQ4p/9sCgg0N7G4E7RMmv+s0gGMeHdTnaSl9I/TqWrtnbaXQCtraIjGjiN1zwnrKekWPPU+zpOpgysvw95s1qVpIApAkCm0GxOqJ68ivgqZwZ8DnJXI1jnX4KOueRENkh7TOArYcAMjkrXABQ6m08vo8rfRBzp0DfjysFyHGoY7iN5ZZQn4qMe7z4eTS9imlMAyhCTSUTAjqIi7L91SSKliaSbVW+YCn8+oyqoYa9hLA/sAk0CyDLFsWekbfhR1zOZIggtgaVebE+jeXUnTBpEKOZNl06TtKZHWP6dShAZ5+vsHO8if1Q==; 5:L8w3R2JyJg/G5C2hH5hWtX/itbuSmMOCxKY/vEMbIV1NO0eI8ZekhIFWC6djXDxFTifHTCWio4BX5IMItst3Ewqac34W4VPRAdH2ckt4MYgOkHAK/gmpvwZAeJxy34+muoMdLAHX0Rb0HC6vaGXXgw==; 24:S1Hq4HSHGxYzucxx8ZGslFuS3FEAg5ad9eTyGlxO2TT0YuCgtGtSUeI2lpJc0YdZuaLxAB9i82gRZ+xpz/C+wl1vJKKftstP04cszwGpcnw=; 7:DOmOHFJyR1XEJ/dr563XLfLcWd839qUCmij5m31QO5V/i6aG2jX9BCWq8tdjMNrbbocMp1pjrbTgbRPOeyAL+HBZM5nQCJAu54pXjfBBeKECgn4aPTMJkEAJSf0a1ZcmDNWRL1ER8v9eldxCI4ou6qk+49rp1oMwfmTr9HxD9+1TccVtQnTRvHDIgk55NeGDxXtV/SyxvOo5oF3IJOXHEv6+YodZdGKZVyVB6mfk+2s=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: b9cb38e5-40a5-4cd5-c9b7-08d517d0bbc9
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603229); SRVR:BLUPR05MB273;
x-ms-traffictypediagnostic: BLUPR05MB273:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=kwatsen@juniper.net;
x-exchange-antispam-report-test: UriScan:(192374486261705)(100405760836317)(21748063052155);
x-microsoft-antispam-prvs: <BLUPR05MB27303B32CA2185179F4FE57A5430@BLUPR05MB273.namprd05.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(3231020)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR05MB273; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR05MB273;
x-forefront-prvs: 0466CA5A45
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(346002)(376002)(199003)(189002)(24454002)(5423002)(97736004)(3280700002)(101416001)(230783001)(36756003)(105586002)(83506002)(2501003)(14454004)(229853002)(53546010)(33656002)(83716003)(5660300001)(8936002)(106356001)(316002)(6246003)(54906003)(81156014)(2906002)(236005)(81166006)(66066001)(25786009)(58126008)(68736007)(53936002)(110136005)(82746002)(6116002)(102836003)(3846002)(99286003)(6486002)(4326008)(77096006)(86362001)(2950100002)(7736002)(54356999)(76176999)(50986999)(2900100001)(3660700001)(6306002)(39060400002)(54896002)(6512007)(189998001)(478600001)(6436002)(6506006)(8676002); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR05MB273; H:BLUPR05MB275.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_C7249566393E4CAF91EFF7CF3D596E58junipernet_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: b9cb38e5-40a5-4cd5-c9b7-08d517d0bbc9
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2017 15:39:21.2587 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB273
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/JreCwrYZuC96jupBMSinN0STOsE>
Subject: Re: [i2rs] WG LC on draft-ietf-i2rs-yang-network-topo (9/27/2017 to 10/11/2017) - WG Consensus declared by Chairs
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2017 15:39:26 -0000

I didn't respond to Alex's response to my YANG Doctor review earlier, but I did
just now review his response to me against, taking into account the current
(-16) version of the draft.  Most everything has been addressed, thank you.
The remaining items that I think worthy of mentioning again are listed below.
The WG can do with them as they will.

1) "ietf-network" uses prefix “nd”, should be “nw” and "ietf-network-topology"
uses  prefix “lnk” should be “nt” or maybe “nwtp”.   There is a documented
convention for prefix naming.  Juergen shared it with me once before.  I can't
find it now.  In general, I don't think the "historic" status of something should
get in the way of doing what's right. In this case, it seems like a minor thing
though, but still…

2) the groupings "link-ref" and "tp-ref" descriptions should indicate why they
are defined but not used in these modules.

3) there are *no* examples in the document.  Every YANG module draft should
have examples of its YANG modules.  Suggest create examples for some use-cases
in Appendix A.

4) The document defines its own "datastore" term, rather than import the term
from revised-datastores. A lot of time has been put into getting the terms right
in revised-datastores, and any ambiguity here could be a problem.  On the other
hand, this draft already has revised-datastores as a normative reference, so likely
any ambiguity will be overlooked, but the issue disappears entirely by importing
the term.

5) Both /nd:networks/network/network-id and /nd:networks/network/link/link-id
are the key fields to their respective lists, but they are not the first nodes listed in
the list.   This is unusual, breaking a convention of some sort, though it might be
be an informal convention.  Just the same, why surprise the reader by going against
expectations?


Thanks,
Kent  // assigned YANG doctor




On 10/15/17, 3:26 PM, "i2rs on behalf of Susan Hares" <i2rs-bounces@ietf.org<mailto:i2rs-bounces@ietf.org> on behalf of shares@ndzh.com<mailto:shares@ndzh.com>> wrote:

Greetings:

We’ve only received approval from this last call.  However, this is the 4th WG LC. All others have been positive and well-attended.  The draft has been kicked back for integration with security considerations and the NETMOD revised data stores.   We’ve resolved these issues.   This draft and the L3 Topology draft are key to other drafts.

The WG chairs plan  declare consensus on this draft, and send it to the IESG.  If anyone objects, please send email to the list by 10/20.

Susan Hares and Russ White