Re: [i2rs] modeling options for draft-ietf-i2rs-yang-network-topo

"Xufeng Liu" <xufeng.liu.ietf@gmail.com> Thu, 16 February 2017 15:38 UTC

Return-Path: <xufeng.liu.ietf@gmail.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C78A9129A4A for <i2rs@ietfa.amsl.com>; Thu, 16 Feb 2017 07:38:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8AHuBISF3upf for <i2rs@ietfa.amsl.com>; Thu, 16 Feb 2017 07:38:43 -0800 (PST)
Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B80D812965D for <i2rs@ietf.org>; Thu, 16 Feb 2017 07:38:42 -0800 (PST)
Received: by mail-lf0-x244.google.com with SMTP id h65so1766443lfi.3 for <i2rs@ietf.org>; Thu, 16 Feb 2017 07:38:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=pZxxTivVSJIqtxniFL7419Jj3FCBJaUl038PDZY+xAM=; b=JMFFVldJUZPArR6P3OubVHtr8hHq6S1tmLQPMXhIRwGV4dInlPok+D76W66ixUPF4Y sXaKpJXQ6YapNqAQba59eLKv8sboQe+AxnSdQHLUeRtnjv5cyxYGTvdS/ErsIMFlrwmo ZUkZkkAThCMQhzTliq5eH2/8QzjPdzg7DuwbH70Pp64X57eMRVDoA2pKgFpyRNLwxKaE T7FRuqudbjADGJNrroRbySdCxozaFdRcdMC3ghD0cHaa2oHcgcPydR4fm3q1byebclxk Ft00d3Ktnaf3d8Ye22FyYGW8C37vvil+xKJaxXs05G9rN3QQU87oJzFbz91qsB+ii8+d p2iQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=pZxxTivVSJIqtxniFL7419Jj3FCBJaUl038PDZY+xAM=; b=BguscEg6cv6I8k8NU4sPPdnK6IAqhrHBsmalBjSy22r4qVz4i+CJW0mcnVab+YyeQG R7kl3g8nTRylnu4Nnhm2yJ6G0dX3R8PT7pORX7xV4M1tHKmL0eHBrYwbj2cfGE3MWf++ mu8G3I4UCsLESsZ1UCcSRG+J5ZFBNoWoRLtiygGKGg5ArLTi7uR6/e3+JNEZtr0NKbYr D5q7FrZjq9kCNND366dyS8IrDRF0tpYCSVqHjQMeH8wLQ+wQFSn01pajRveXEzeILXqE 3VMQRR+x70QP5PVxIs8E3M8y2UXP2Ok/LOl2Y5ttpvkVAAkX5V41EPIrrIAtC9BMrDWc r3Bw==
X-Gm-Message-State: AMke39l8aFzlaARU26wEGFH1O1aFvU15m+A2SCf32w8332YQw9Zb6ZGKTljxAoyWj3MRRw==
X-Received: by 10.46.71.207 with SMTP id u198mr847608lja.42.1487259520786; Thu, 16 Feb 2017 07:38:40 -0800 (PST)
Received: from xliuus (wsip-98-191-72-170.dc.dc.cox.net. [98.191.72.170]) by smtp.gmail.com with ESMTPSA id f25sm1844602lji.26.2017.02.16.07.38.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 07:38:40 -0800 (PST)
From: Xufeng Liu <xufeng.liu.ietf@gmail.com>
To: 'Martin Bjorklund' <mbj@tail-f.com>, kwatsen@juniper.net
References: <AA7FA7D3-ED7B-4482-BBAC-7144E4944D92@juniper.net> <20170214.120910.763903356597953031.mbj@tail-f.com> <447B5293-75CE-4CE2-ADA4-D9E55EC7EA35@juniper.net> <20170214.174106.332845199336010868.mbj@tail-f.com>
In-Reply-To: <20170214.174106.332845199336010868.mbj@tail-f.com>
Date: Thu, 16 Feb 2017 10:38:37 -0500
Message-ID: <007601d2886a$bf085170$3d18f450$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKQx8r72RrckYMhXWnaB0v1b2P4ZAEWoFNQAqHHXJ0B1BTo7J/C4SUw
Content-Language: en-us
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/_6ploWjPYvlTQ2vjDDeuprlqf_0>
Cc: i2rs@ietf.org
Subject: Re: [i2rs] modeling options for draft-ietf-i2rs-yang-network-topo
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Feb 2017 15:38:45 -0000


> -----Original Message-----
> From: i2rs [mailto:i2rs-bounces@ietf.org] On Behalf Of Martin Bjorklund
> Sent: Tuesday, February 14, 2017 11:41 AM
> To: kwatsen@juniper.net
> Cc: i2rs@ietf.org
> Subject: Re: [i2rs] modeling options for draft-ietf-i2rs-yang-network-topo
> 
> Kent Watsen <kwatsen@juniper.net> wrote:
> >
> >
> > [moving yang-doctors to BCC]
> >
> >
> > >> OPTION 1: separate /foo and /foo-state trees
> > >> --------------------------------------------
> > >>
> > >> This option was/is described here:
> > >> https://www.ietf.org/mail-archive/web/i2rs/current/msg04316.html.
> > >>
> > >> PROS:
> > >>   a) does NOT break legacy clients (how we got here)
> > >>   b) consistent with convention used in many IETF modules
> > >>   c) able to show if/how opstate may differ from configured values
> > >>
> > >> CONS:
> > >>   a) questionably valid YANG leafref usage
> > >
> > > What does this mean?
> >
> > I'm referring to how the description statement explains that the
> > server may look to operational state in order to resolve the leafref,
> > which is to result in behavior similar to pre-configuration in RFC
> > 7223.
> 
> Ok, I didn't pay close attention to the proposal in the quoted email.
> 
> I would design this a bit differently.  The config true leaf "dependency"
should
> have a leafref to the config false node name, with require-instance false.
The
> description should explain that the configuration item will be used by the
server
> if all dependencies exist.  When the configuration item is used, it shows
up in the
> config false list.
> 
> This way, the leafref usage is valid and straight forward.
> 
> > >>   b) complex server implementation (to handle require-instance
> > >> false)
> > >
> > >Can you elaborate on this one?
> >
> > This is primarily a reflection of the CON listed above, in that it
> > seems that a server would need to have special handling for when
> > dependencies transition from being present to not-present and vice
> > versa, much like the code to handle when a physical card is plugged in
> > or removed.
> 
> Yes, but I think this is inherent to the problem at hand.  Even with the
config true
> solution defined in the current draft, it is not clear how things that
were created
> by the server would be deleted (if there were references to them).
> 
> > Note: I should've listed this as a CON for OPTION 2 as well.
> >
> >
> >
> > >>   c) eventually the module would need to migrate to the long-term
> > >>      solution, which would result in needing to also rewrite all
> > >>      modules that have augmented it (e.g., ietf-te-topology).
> > >>   d) leafref path expressions really only work for configuration
data,
> > >>      though a clever server could have a special ability to peak at
> > >>      the opstate values when doing validations.  Of course, with
> > >>      require-instance is false, the value of leafref based validation
> > >>      checking is negated anyway, even for config true nodes, so this
> > >>      may not matter much.
> > >>
> > >>
> > >>
> > >> OPTION 2: explicit client-option to also return tagged opstate data
> > >> -------------------------------------------------------------------
> > >>
> > >> This option takes a couple forms.  The first is module-specific and
> > >> the second is generic.  In both cases, the idea is modeled after
> > >> the with-defaults solution (RFC6243), wherein the client passes a
> > >> special flag into <get-config> causing the server to also return
> > >> opstate data, having a special metadata flag set, intermingled with
> > >> the configuration data.
> > >>
> > >>
> > >> 2A: Module-specific version
> > >>
> > >>    module foo {
> > >>       import ietf-netconf { prefix nc; }
> > >>       import ietf-yang-metadata { prefix md; }
> > >>       md:annotation server-provided {
> > >>          type boolean;
> > >>       }
> > >>       container nodes {
> > >>          config true;
> > >>          list node {
> > >>             key "name";
> > >>             leaf name { type string; }
> > >>             leaf dependency {
> > >>                type leafref {
> > >>                  path "../node/name"
> > >>                  require-instance false;
> > >>                }
> > >>             }
> > >>          }
> > >>       }
> > >>       augment /nc:get-config/nc:input {
> > >>          leaf with-server-provided {
> > >>             type boolean;
> > >>          }
> > >>       }
> > >>    }
> > >
> > > I don't think this solution is substantially different from the
> > > solution in draft-ietf-i2rs-yang-network-topo-10.  You have just
> > > moved a config false leaf to a meta-data annotation.  This solution
> > > suffers from the same problems as the solution in
> > > draft-ietf-i2rs-yang-network-topo-10.
> >
> > There are two primary differences:
> >
> > 1) It doesn't break legacy clients
> 
> The solution in the draft doesn't break legacy clients either - there's a
config
> false leaf among the config true.  No problem.
> 
> >    , because it requires the client to
> >    explicitly pass a 'with-server-provided' flag in the <get-config>
> >    request in order to get back the extended response.  Likewise, it
> >    doesn't break backup/restore workflows, as the server can discard
> >    any 'server-provided' nodes passed in an <edit-config> operation.
> 
> Huh?  This goes against the defined behavior of 6241 + 7950.  This is the
main
> problem with the solution in the current draft.
> 
> If a client sends a <get-config> for data in running, the server cannot
send back
> data that is not in running.
> 
> >    Lastly, it doesn't break <lock>/<unlock>, as there is no comingling
> >    of opstate data in the 'running' datastore.
> >
> > 2) It doesn't say anything about how the opstate data is stored on the
> >    server.  The opstate data is not modeled at all.  This approach
> >    only defines a presentation-layer format for how opstate data can
> >    be returned via an RPC.  The server is free to persist the opstate
> >    data anyway it wants, perhaps in an internal datastore called
> >    'operational-state' or in an uber-datastore with the opstate data
> >    flagged with a datastore='oper-state' attribute.  Regardless, it's
> >    an implementation detail, and the conceptual datastore model is
> >    preserved.
> 
> You are essentially defining a new operation, but do it by modifying the
> semantics of an existing one.  I don't think this is a good idea; it is
better to
> define a new rpc.

[Xufeng] Is using a new rpc is acceptable? If so, this could be a viable
option.

> 
> 
> /martin
> 
> _______________________________________________
> i2rs mailing list
> i2rs@ietf.org
> https://www.ietf.org/mailman/listinfo/i2rs